jdee / react_native_util Goto Github PK

Targets for tvOS are ignored and unmodified by the react_pod command. But everything under node_modules is removed from the Libraries group as of 0.5.2. It's likely that this breaks tvOS targets, since they will have dead file references in the Link Binary With Libraries build phase. The solution is to add a separate platform :tvos block to the Podfile with appropriate pods. This will follow the same logic as the iOS conversion and is not very difficult.

See the comment for Project#add_packager_script_from

# TODO: The build phase is added after all other build phases. Ideally it
# can be moved to the beginning. The packager is independent of the Xcode
# build process. It may be started at any time. Starting it early is an
# optimization that allows it to load while the build is in progress.
# Currently it's possible to simply drag the build phase in Xcode to a
# higher position after running the react_pod command.

This would be nice to fix. It might require extending the AbstractTarget or PBXNativeTarget class from xcodeproj.

Version 0.6.0 properly sets up tvOS targets in the generated Podfile. However, the React pod does not build for tvOS with 0.59.8. It may be that it builds for earlier versions or will be fixed in an upcoming release. The problem is related to the deprecated built-in WebView component, which has moved to react-native-webview. The podspec has been completely restructured in the master branch of react-native.

It seems like there are not that many RN apps for tvOS. There was even a proposal to remove it from the core of RN: react-native-community/discussions-and-proposals#111.

For now, this means converting an app to use CocoaPods will break a tvOS build. This gem may be able to work around it, or it may be fixed in the future.

pod install does not generate a buildable project right away. xcodebuild will fail if run immediately afterward. It is necessary first to open the newly-generate workspace and let Xcode generate a default scheme. This is one benefit of opening the workspace at the end.

It would be nice to generate a single, buildable commit with all changes. It will either be necessary to generate the scheme without Xcode's help or sleep after opening the workspace to allow the scheme to be generated before committing.