jdeathe / centos-ssh-memcached Goto Github PK

• Add source from jdeathe/centos-ssh:1.7.6
• Add a change log (CHANGELOG.md).
• Add support for semantic version numbered tags.
• Add minor code style changes to the Makefile.

Make a start with:

• Add functional tests using shpec.

• https://github.com/jdeathe/centos-ssh-memcached/blob/1.0.1/test/telnet-memcached.exp#L1

Error message:

/usr/bin/env: expect -f: No such file or directory

Update source image to 1.8.4 tag.

Update to release 1.8.2

• https://github.com/jdeathe/centos-ssh-memcached/blob/2.1.1/environment.mk#L42-L54
• https://github.com/jdeathe/centos-ssh-memcached/blob/2.1.1/src/opt/scmi/environment.sh#L46-L58

Missing:

• SSH_PASSWORD_AUTHENTICATION
• SSH_TIMEZONE
• SSH_USER_PRIVATE_KEY

Ref: https://docs.docker.com/engine/deprecated/

Deprecated In Release: v1.13.0
MAINTAINER was an early very limited form of LABEL which should be used instead.

Change that should have been in the last release got missed/reverted:
https://github.com/jdeathe/centos-ssh-memcached/blob/2.2.1/src/etc/systemd/system/centos-ssh-memcached%40.service#L141

Replace all /usr/bin/grep with /bin/grep

No CHANGELOG entry required as this will get removed in the next release anyway. Update README on docker hub following change.

No package memcached-1.4.4-3.el6 available.

Add environment variable MEMCACHED_AUTOSTART_MEMCACHED_WRAPPER to disable the startup of the service so the image can be used as client only.

Patch back #67

There should ideally be some validation on the values supplied via the environment variables and a Details summary in the logs to be consistent with the other images.

• MEMCACHED_AUTOSTART_MEMCACHED_WRAPPER (boolean)
• MEMCACHED_CACHESIZE (positive, non-zero, integer)
• MEMCACHED_MAXCONN (positive, non-zero, integer)
• MEMCACHED_OPTIONS (string)

MEMCACHED_OPTIONS allows for free entry of extra options so would be difficult to validate as its purpose is to allow entry of options that are non-standard.

Missed out some changes

• supervisord configuration files should have directives ordered alphabetically for consistency.
• There are still some replacements of echo with printf remaining in the systemd register unit file.

Patch back #45

Patch back #101

Patch back #71

• Update source image to jdeathe/centos-ssh:1.8.1
• Add a src directory for the image root files.
• Add STARTUP_TIME variable for the logs-delayed Makefile target.
• Add clearer, improved shpec test case output.
• Add a Docker healthcheck.

Patch back #91

Patch back #77

Missing SHPEC_ROOT := test/shpec from environment.mk

Several scripts use the syntax:

local readonly variable="value"

This is incorrect and should be replaced with:

local -r variable="value"

Patch back #61

Patch back #81

libmemcached
Client library and command line tools for memcached server

libmemcached is a C client library to the memcached server (http://danga.com/memcached). It has been designed to be light on memory usage, and provide full access to server side methods. It also implements several command line tools: memcat - Copy the value of a key to standard output. memflush - Flush the contents of your servers. memrm - Remove a key(s) from the server. memstat - Dump the stats of your servers to standard output. memslap - Generate testing loads on a memcached cluster. memcp - Copy files to memcached servers. memerror - Creates human readable messages from libmemcached error codes.

Version (latest package release) 0.31 (1.1.el6)

wrapper output logs should be written to /dev/stdout instead of a container file path so they will be handled by docker's logging drivers.

Bypassing the requirement of supervisor_stdout should mean output of the Memcached Details will work correctly without the need for waiting 1 second for startup.

https://github.com/jdeathe/centos-ssh/releases/tag/1.9.0

https://docs.docker.com/engine/reference/builder/#dockerignore-file

https://github.com/jdeathe/centos-ssh/releases/tag/2.4.0

The scmi script is added to the image from the upstream source image jdeathe/centos-ssh

Having it in the repository means it needs to be maintained but is never added to this image from the Dockerfile build.

Update source image to 1.8.3 tag.

• Remove intro from Overview & links
• Remove statement regarding the requirement of supervisor-stdout for log output.

Patch back #104

Patch back #47

Missing the setup step advising

Copy .env.example to .env and modify values as required.

Replace 1.9.0 with 2.1.0 in CHANGELOG

Patch back #94

To support the configured MEMCACHED_MAXCONN value the corresponding --sysctl parameters need setting in the container.