jczaplew / csv-express Goto Github PK

My code looks like this:

    twit.get('search/tweets', req.query, function(err, response) {
        const out = response.statuses.map(s => ({
            user_id: s.user.id,
            user_name: s.user.name,
            user_screen_name: s.user.screen_name,
            text: s.text,
        }));
        res.csv(out, true);
    });

It fails on the res.csv line like this:

Error: Can't set headers after they are sent.
    at validateHeader (_http_outgoing.js:491:11)
    at ServerResponse.setHeader (_http_outgoing.js:498:3)
    at ServerResponse.header (code/node_modules/express/lib/response.js:771:10)
    at ServerResponse.res.csv (code/node_modules/csv-express/lib/csv-express.js:68:8)
    at code/routes/index.js:78:13
    at Request._callback (code/node_modules/twitter/lib/twitter.js:227:5)
    at Request.self.callback (code/node_modules/twitter/node_modules/request/request.js:185:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (code/node_modules/twitter/node_modules/request/request.js:1161:10)

    "csv-express": "^1.2.2",
    "express": "^4.15.2",

I switched to your fork because it seems to be maintained while the original is not. So thank you for that !

I think you could improve the user experience though by improving the documentation.

Two things I noticed :

• res.csv([data] [, csvHeaders] [, responseHeaders] [, statusCode]) the data parameter should not be between brackets as it is required
• you didn't provide a full example with all parameters (I noticed because I was wondering if responseHeaders should be an object or an array)

Cheers

There is no option to set the csv file name.
Thank you

There is a typo error in the documentation code:

 res.csv([
      {"name": "Sam", "age": 1},
      {"name": "Mary": "age": 2}
  ], true)

"Mary": "age" - > "Mary", "age"

The current signature used here https://github.com/jczaplew/csv-express/blob/master/lib/csv-express.js#L100 is deprecated since Express 2.x

http://expressjs.com/2x/guide.html#res.send()
http://expressjs.com/en/3x/api.html#res.send
http://expressjs.com/en/4x/api.html#res.send

Current method signature is res.send([body])

Please applay the separator for the csv headers as well.

Nice regards form Ujov.

Can any one of please help me how to set delimiter as | in csv-express module

This is an artifact of the original version from nulltask and I never noticed because I don't use those options.

res.csv is not a function