jcoglan / packr Goto Github PK

In Chrome 46.0.2490.86 / Firefox 42, the minimized code with base62 encode does not work.

when executing the generated source, it shows "Uncaught TypeError: Cannot set property length of # which has only a getter"

document.getElementsByTagName('script') returns Array Like object depending on the kinds of browser. Then I suppose to replace from

document.getElementsByTagName('script')

to

Array.apply(null,document.getElementsByTagName('script'))

I just thought I'd document this issue here, but I recently upgraded to ruby 1.8.7 (2012-02-08 MBARI 8/0x6770 on patchlevel 358) [i686-darwin12.2.1], MBARI 0x6770, Ruby Enterprise Edition 2012.02

With the new version packr intermittently strips all spaces from javascript code (but not in strings). For example expected compressed output:

if(typeof YAHOO=="undefined"||!YAHOO){var YAHOO={}} ...

actual output:

if(typeofYAHOO=="undefined"||!YAHOO){varYAHOO={}} ...

This behaviour only occurs intermittently for certain runs of the ruby runtime. If the bug is happening, then all usages of Packr.pack will exhibit the behaviour while ruby is running. For another run of ruby, the bug doesn't happen at all.

I believe the problem lies with packr being dependant on hash ordering somewhere. Versions of ruby > 1.8.7 p352 return random hash orderings as per this security fix.

Unfortunately this bug took me a long time to track down because I didn't initially realise it was related to a ruby upgrade which had happened a long time previously.

Anyway, I suggest this at least be documented somewhere and preferably fixed, though I realise 1.0.2 is very old now. Not sure if the problem manifests in newer versions.