jcnelson / nftree Goto Github PK

Just noticed that running ./nftree.js with certain numbers of NFTs causes nulls in the proof map and errors..

    "hashes": proof.map(function(h) { return h.toString('hex') }),

     TypeError: Cannot read property 'toString' of undefined
    at /Users/mikey/hubgit/radicle-solutions/nftree/src/nftree.js:188:48
    at Array.map (<anonymous>)
    at makeMerkleProof (/Users/mikey/hubgit/radicle-solutions/nftree/src/nftree.js:188:21)
    at processOneDirectory (/Users/mikey/hubgit/radicle-solutions/nftree/src/nftree.js:263:21)
    at main (/Users/mikey/hubgit/radicle-solutions/nftree/src/nftree.js:426:24)
    at Object.<anonymous> (/Users/mikey/hubgit/radicle-solutions/nftree/src/nftree.js:453:1)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)```

For example running with 3, 4 NFTs works but 5 errors and 6, 7, 8 works and 9 fails.

Is is possible you can put some instructions of how to install and test this on Clarinet in Visual Studio Code?

Also i would like to know is there a simple way to Lock the Parent NFT In NFT Pool and have Child NFTS have shared ownership of the Parent.

Basically i want to fractionalise the Parent NFT without actually fractionising it but giving shared ownership to fixed number of Child NFTs, which can be openly traded on NFT platforms.

Thank you for this amazing repository Jude!

My questions are hopefully rather simple -

1. When uploading the NFT and metadata to IPFS or wherever they will be stored, how do we ensure that NFTree metadata captures what is stored and how does this get accounted for when constructing the NFTree?
2. Is there a way to automate or pre-configure ticket prices with rarity?

Thank you,
Jake

Hey @jcnelson!
I like the idea of using Merkel tree to pre-mint all NFT's in collection. 👏

In README.md file you mentioned instantiate-nftree function:

Once the NFT creator has the outputted NFT descriptor, they can call (instantiate-nftree) with it:

There is no such function in the project source files, and almost identical sentence can be found few lines above, so I think it's just an editorial mistake.

Both functions register-nftree and register-contract-nftree don't check if provided tree root has been already registered or not.
I can imagine a situation in which artist would like to release same collection more than once, but I would say it should be always done using separate, unique tree.