jbranham1 / mod_0_skills Goto Github PK

@jbranham1
Nice work here- you have shown that you've picked up the concepts we hope students will be taking from Mod0- You are officially technical ready! A bit more feedback for consideration as you continue to practice:

• Very nice job with your method names naming patterns, and in coming up with ideas for how each method modifies, or uses, an attribute. I also like seeing the boolean naming patterns!

• I noticed you have a lot of change methods. These tend to take a value and make it another thing. These are all great things! And I really like how simple and clear all those names are. I don't think you need to change them at all, but I would recommend thinking of the various ways you can modify attributes, for instance, you have a method that changes the calorie counts, but what might you name a method that adds 100 calories to the total every time? Or one that reduces the calorie count by a set amount? The inclination could be to think 'that's why I have a change method that can take care of both', but there could absolutely be reason to have all 3 of those methods, depending on the what actions should be readily available. For example, maybe adding butter, or sugar, is a common occurrence. Anyway, your methods are all great! Just a note to encourage thinking of different ways attributes will be modified.