Giter Club home page Giter Club logo

nbareact's People

Contributors

jbkuczma avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

nbareact's Issues

Add nugget for game (see description)

Each game has a property called "nugget" which seems to be a highlight statement (ex: "Wizards pull even with Pacers for No. 4 seed", "Harden: 32 points, 11 rebounds"). Think about adding this to either the game cell or the game detail page.

Invalid dat

Only comes up when running iOS simulator through Xcode.
screen shot 2016-06-27 at 3 50 09 pm

Add dividing lines for scoreboard

On the gameStatsTeamDev branch, look into adding dividing lines between headers, teams, and scores. May have to wrap each text component in its own view

Vertical align responsive images

Having trouble making the images stay vertically aligned with the text below them while using Bootstrap's responsive image class.

Add shadow to image

Since some of the team logos are all white and transparent, they can be difficult to see on the chosen background color. Look into adding a small shadow for better viewing.

Q&A: Why were the images taken out?

As much as I loved having the team logos and player images in Swish, they had to be removed for release on the App Store. There is a branch (swish_with_images) that contains Swish before the images were taken out.

As the development of Swish continues, I will try to update that branch as well with features that make it to master so the full app could still live on.

In the future if I can acquire rights to use the actual team logos or some custom made alternative version, then I will add them back in.

Make a <Loader /> component

Many of the screen contain a of loader implementation that is the same across the components. This should be made into its own component for ease of maintenance.

Team Stats Page

When a user clicks on the team logo from GameStatsTeam page, they will be taken to that team's own page. Possible ideas on what to include are season record, stat rankings, roster, player stats; will look into.

Add game info on press

When one of the game cells are pressed on the scores page, provide more details. Ideas: points scored by quarter, team stats, maybe player stats. We'll see what direction this idea takes.

Filter out duplicate plays

Notice this happens at the end of the 4th quarter (first might represent end of quarter and the second might represent end of game).
screen shot 2018-03-09 at 5 32 30 pm

Detailed player game log

Right now in the player page, a list of their games is displayed along with points, rebounds, and assists for the game. Clicking on a game from the player page should go to a new page that displays more stats from that game.

Change splash screen

As of now the splash screen is still the default one that comes bundled with React Native. I think this only pertains to iOS.

Preview/Recap article

There is an endpoint for a preview (if the game hasn't started) and recap (if the game is finished) article for a provided game. A fourth tab could be added to the game detail screen and render the appropriate article.

ios error

Bundling index.ios.js
Transforming modules โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–“โ–‘ 99.0% (391/393)...(node:11817) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 668): UnableToResolveError: Unable to resolve module ./App/Assets/Images/back_button_white.png from /Users/open/NodeProjects/react-projects/NBAreact/App/NBAreact.js: Directory /Users/open/NodeProjects/react-projects/NBAreact/App/App/Assets/Images/back_button_white.png doesn't exist

App Icon

At some point I'm going to need to design and create an app icon.

Initial launch screen

Something cool to have would be have a splash screen animation like how twitter launches on iOS

Refractor PlayerScreen

The PlayerScreen can now be reached 3 different ways:

  • From the roster
  • From the league leaders
  • From the player search

PlayerScreen is currently written for data returned from the roster API call, but LeagueLeaders and PlayerSearch API calls return different properties.

Property Roster Player Search League Leader
Player ID player_id personId player_id
Name player firstName & lastName player
Height height heightFeet & heightInches
Weight weight weightPounds
Years Experience exp yearsPro
School school collegeName
Number num jersey

Based on this, if we are navigating from a league leader item to the player screen, the player will have to be looked up from PlayersInLeague array from the Redux Store and that value will be used.

tl;dr Refractor PlayerScreen to use data for a player found in the PlayersInLeague array

No games are being played

If no games are being played, then the user is presented with a blank home screen. Maybe think about adding an image just so it isn't blank?

Web version

To show this app to a user without them downloading, I could try and make a web version with ReactJS.

To Do

  • Create new WebApp folder
  • Create main page
    • Style main page
  • Render games being played for given date
    • Have date reflect number of games being played
    • Render game rows
    • Render game data for each cell
    • Style game cells
  • Render team stats for a selected game
    • Set up modal to overlay current screen with selected game stats
      • Style modal
      • Fill modal with the data
  • Render league standings

Missing data

If a callback fails to produce data, address the problem. See below for example:
screen shot 2016-06-20 at 3 38 25 pm

Passing current date

The date in the header can be changed properly along with its corresponding text. I need to pass whatever the new date is to ScoresPage.js in order for the games to be displayed for that date.

App name

If I do decide to publish v2.0 I'm thinking the app name should be different; the repo will still be named NBAreact.

Current ideas:

  • Swish
  • Hoops

Info cut off

Smaller screen size leads to stats being cut off.
screen shot 2016-06-27 at 3 57 03 pm

Virtual buttons

Some android devices have virtual nav buttons and this can cause the the last playercell in a listview to not be displayed fully.
screen shot 2016-07-05 at 11 56 01 am

Android

If Android versions plans to be published it needs visual improvements. iOS seems fine.

Career stats for player screen

The player's screen currently only shows game stats for the current season. A great enhancement to this screen would be the option to show a player's career stats.

Boxscore not appearing

Sometimes when navigating to the boxscore tab, the list doesn't appear until any scrolling begins

Add shot chart

In the individual player page, look into adding a shot chart for the player.

Image shadows

The current way of having a shadow behind an image only seems to work with iOS and not Android.
screen shot 2016-07-05 at 11 59 59 am

Tab bar icons

Will need tab bar icons for:

  • Scores (scoreboard)
  • Standings (trophy)

Refresh game list capabilities

The games list should only be able to be refreshed if the date used to look up games in the app is today's app. The reason for this is data won't change when a game has finished or has yet to begin, and can help save data for users.

Add videos

Add a new tab that is strictly for videos. Could see if there is an API endpoint the NBA uses or scrape videos from /r/nba

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.