Giter Club home page Giter Club logo

h2geo-presets's People

Contributors

aallam avatar aeber avatar guillaumeamat avatar loicortola avatar nlehuby avatar panieravide avatar pdfext avatar tommybuonomo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

h2geo-presets's Issues

'constraints' does not seem to properly work

Hello
In indication_board.yml I have been using 'constraints', but with no effect
As you can see, if 'message' is equal to 'other', then we should have :
legal_type:FR=publicité
legal_status:FR=illégal
But i have not seen these attributes properly set when used
Then I suppose there is something wrong into the implementation of 'constraints', or maybe this implementation is missing.
Can you have a look please ?
Thank you in advance

'query' is not implemented and it is a pity : 'query' are really missing to have OSM contributor functional

Hello
I ve tried to use the 'query'. This is documented this way in the spec :
$.groups.$.item.$.query
The overpass query allowing to fetch the current item. This field is optional.

This is quite short and not very self explainable !
The query I wish is the following
[out:json][timeout:25];(node["advertising"="board"]"legal_type:FR"="préenseigne";);out body;
I note for information, that for dynamic umap, query are like this one 👍
http://overpass-api.de/api/interpreter?data=[out:json][timeout:25];(node["advertising"="board"]["legal_type:FR"="préenseigne"]({south},{west},{north},{east}););out body;

I ve tried several query syntaxes, none worked well. LOrtola conformed later that the 'query' is in fact not implemented. The query is needed anyhow to know if the object when want to set and add in OSM already exists or not. If it does already exist, there is obviously no need to add it again in OSM, but user of OSM contributor needs to know that !

Thank you to see if this 'query' can be added in implementation !

Is there a way to validate presets?

Do you use any tools to validate presets you create for h2geo? The simplicity of the OSM Contributor app is perfect for promoting an easy way to contribute to OpenStreetMap.

API Enhancements

From JungleBus Workshop:

  • MapContrib needs to be able to add specific tags which are private (<=> aka would not be pushed to remote repository)
  • Street Complete associates a statement (question) with each tag. We need to be able to add the possibility of specifying statements for each tag. Needs to be i18nable.
  • Add the ability to support icons on : a type level and a tag level. Icons can be specified in three different ways: either using a URI (cf issue #39 ), a URL, or an asset. Icons can be internationalizable.
  • Add the COLOR tag type. Possible values are: CSS colors and hex (6 hex chars, 3 hex chars)

'description' field of attribute is not displayed when form is being used in OSM contributor

Hello
The 'description' is set in the indication_board.yml but I cannot see this description when the form is displayed in OSM contributor. The only thing which is displayed when we are being using the form of OSM contributor is the value of 'key' of the attribute, or the values set in 'values', but the 'description' is not dislayed.
Can you see if there is something wrong ?
Thank you in advance

Clarify icons requirements

This may be a bug in OSM Contributor rather than in H2Geo, but sometimes, the icon defined in the preset does not show up in the app.

For instance, the first one is ok, and the second one is not (from the car preset):

I think we should add some requirements in the specs to help the preset makers:

  • accepted format(s) : SVG, PNG, etc
  • size constraints : only square images ? min /max size ?
  • etc

required=true has no real effect

hello
I have set required=true on some attributes of indication_board.yml for example on 'land-property' which can take two values 'private' or 'public'. It means that the value should be either 'private' or 'public'. Required=true should mean that this attribute cannot be unset. But the form interface proposes the 'undefined' value, which means that this attribute can be unset.
Then I presume that the 'required=true' is not properly implemented (or maybe not implemented ?)
Than you to verify

Localisation of attributes into form is not functional

hello
In indication_board.yml I have localised as much as I can attributes, and the defaults is always in French, but as a matter of fact, the only language which is displayed in English when this indication_board form is being used. The French is properly displayed before entering into the form, but into the form the language is English. So localisation is partly functional only.
Can you see if the localisation of form can be added in implementation please ?
Thank you in advance!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.