javiery3889 / pe Goto Github PK

Steps to reproduce

import /Users/javier/uni/y2s2/CS2103/pe/files-for-pe/addressbookdata/i|.csv

In the following sequence diagram under the "Sequence Diagrams Illustrating Exam Modification" section, the constructor method should be AddExamCommand(e) instead following the Class() format in the textbook here.

Describe the bug

In the program itself, the supported prefixes are stated in the command usage as shown below.

In contrast, this is not explicitly stated in the UG, as shown below.

Suggested fix

Perhaps it would be better to state the supported prefixes in the UG as well.

Steps to reproduce

find

Describe the bug

The UG currently states the following for the delete command:

If the user enters a single digit INDEX with a prefix string of "0" prepended, the command still runs successfully.

Steps to reproduce

Assume that the list has at least one person
delete 0000000001

Expected

Throw an error for invalid INDEX

Actual

Person at index 1 is deleted successfully

Suggested fix

Perhaps it would be better to reject such instances and throw an error for invalid index instead

There should be a X on the FindCommand lifeline to indicate it is ready to be garbage collected once it returns r to LogicManager.

Describe the bug

TheaddExam command section in the UG currently is as follows:

However, this definition of duplicate names is not clearly defined, as users are able to enter the same exam name with differing case with no error.

Steps to reproduce

addExam n|Midterm s|1000000
addExam n|midterm s|1

Expected

Product displays an error for duplicate exam names

Actual

Suggested fix

Perhaps it would be better to mention that exam names are case sensitive in the UG

test

Just a nit, but terms such as GUI and CLI can be omitted in this case as developers should have knowledge on them.