jasvr / p1-rgb_flashcards Goto Github PK
View Code? Open in Web Editor NEWRGB & HEX Flashcards
Home Page: https://jasvr.github.io/P1-rgb_flashcards/index.html
p1-rgb_flashcards's People
Contributors
Watchers
Forkers
mrrogercampbellp1-rgb_flashcards's Issues
single font-family property possible
I only notice the "Karla" font for your site, and only see the two font-family properties for it. In that case, it is conventionally to have the base font styles declared on the body selector, as it will apply to the rest of the elements in the page as well (all visual elements are children of the <body>
No JS
One of the project requirements is Javascript, and looking at your file structure I cannot find a Javascript file.
The Pure CSS animation is great, but there needs to be Javascript somewhere. Using an array of questions and answers and rendering them to the DOM is a solid and suitable use of JS, and there needs to be something.
Confusing file structure
The index2.html and ack.html files weren't clear to me what they were doing, and multiple CSS sheets is fine but the names again make it difficult to quickly see where each stylesheet is being used.
Using clear names is helpful not just in the code but with the files themselves. It might also be good to have a pages/ and styles/ directory in your repo to keep the different files organized (and those are common conventions).
CSS animation bug on mouse position
Because of how the flip animation works with the DOM elements, there's a very narrow range for each card that the mouse has to be in for the card to flip correctly, otherwise it is very jittery as it bounces between animation and non-animation states.
A lot of times, I have the :hover selector on the parent div, and that makes it so even when the child element is moving around the mouse is still consistently "hovering" on the parent container to prevent this kind of quirk.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.