janniklth / arithmetictree Goto Github PK

• brackets at the wrong position (infix)
• prefix and postfix probably also not working correct

brackets are not included in postfix and prefix which leads to fatal errors

• Tokenizer() can only evaluate one expression, why is the src not a parameter of the method?
• make a clear structure where more functions are called directly by the main.cpp
• evaluate if a utility class makes more sense for methods which can be static

simple method to visualize a tree to test the program

• replace getType with getValue
• replace type string with enum

• mark arguments with -m for example
• independent from the order

• its better if you can switch the order
• little bit complicated because of spaces
• solution idea: count opening and closing brackets

• Programms works fine, but every time before running there are some errors which disappear when running

implement tree depth

• count opening and closing brackets
• only allow numbers, brackets and operators

Describe the bug
spacings aren't allowed in arguments
if you want to type in a arithmetic expression an error could occure if you type in spacings

Solution
Need to ask, if we can also make a user input

Add info required by the exercise to every file, class an method

• author
• version

• print tree from top to bottom
• maybe use https://github.com/YoussefRaafatNasry/bst-ascii-visualization

• maybe just on windows
• occurring on Leons laptop
• a lot of chars are printed as "@"

• implement main file given from the lecturer
• use arguments to pass the string
• maybe implement console input as well

nothing works with postfix, prefix needs to be tested

implement node count

• var naming (lowercase and underscore)
• meaningful method naming
• meaningful comments
• paragraphs before curly brackets
• mark overrides functions as override
• use auto type
• use explicit
• ...