jamillosantos / go-ceous Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 258 KB

An ORM experiment in GO

License: MIT License

Go 100.00%

go-ceous's People

Contributors

Watchers

go-ceous's Issues

Pointer to embedded fields break inserts

Briefing

Let's say we have this model:

type Response struct {
    ceous.Embedded
    Status int `ceous:"status"
}

type Call struct {
    ceous.Model `tableName:"calls"`
    Response *Response `ceous:"response"`
}

The generated code for the model:

// Value returns the value from a field given its column name.
func (model *Call) Value(name string) (interface{}, error) {
	switch name {
	case "response_status_code":
		return model.Response.StatusCode, nil
	case "response_headers":
		return model.Response.Headers, nil
	case "response_body":
		return model.Response.Body, nil
	case "tags":
		return model.Tags, nil
// this methods continue ......
}

Problem

By the Value method implementation is possible to see that if model.Response can be nil and break the whole thing.

ColumnAddress has the same problem:

func (model *Call) ColumnAddress(name string) (interface{}, error) {
    switch name {
    case "response_status_code":
        return &model.Response.StatusCode, nil
    case "response_headers":
        return &model.Response.Headers, nil
    case "response_body":
        return &model.Response.Body, nil
    // ...
}

When trying to Insert without specifying the right fields, for example, it might panic because Response can be nil.

Implement default scenarios

Briefing

Let's say the system has a Users. Users can be deleted, but not really. Instead, the system soft deletes them to keep who did some actions. So, for the UserQuery deleted users should always be filtered out. For those cases would be nice to have some sort of "default scenario".

Default scenarios are filters applied to the query as soon as it gets created. It would work as a filter method that is run whenever the Query is initialized.

Of course, we would have an option to disable it.

The default connection is not set

Briefing

The Queries and Stores are not using the default connection by default. For every initialization, we have to set the connection.

Updating and inserting models with embedded fields

Briefing

This description seems like #24. But, is a different issue. Follow on.

Let's say we have this model:

type Response struct {
    ceous.Embedded
    Status int `ceous:"status"
}

type Call struct {
    ceous.Model `tableName:"calls"`
    Response Response `ceous:"response"`
}

The generated code for the model:

// Value returns the value from a field given its column name.
func (model *Call) Value(name string) (interface{}, error) {
	switch name {
	case "response_status_code":
		return model.Response.StatusCode, nil
	case "response_headers":
		return model.Response.Headers, nil
	case "response_body":
		return model.Response.Body, nil
	case "tags":
		return model.Tags, nil
// this methods continue ......
}

Problem

When inserting the model without specifying any fields we get:

sql: converting argument $2 type: unsupported type models.Response, a struct

What happens is that the Call.Request field is considered to be a type and tries to be persisted in the database. But, it is a struct which has fields.

jamillosantos / go-ceous Goto Github PK

go-ceous's People

Contributors

Watchers

go-ceous's Issues

Pointer to embedded fields break inserts

Implement default scenarios

The default connection is not set

Updating and inserting models with embedded fields

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent