jameswalmsley / fullfat Goto Github PK

This should allow FullFAT to be more easily integrated into an i-node based system.

There was a commit that changed the license from GPL to BSD: 04d46c7 but it seems that it got detached from the master branch. Was the commit made by an accident or this version of library is actually available under the terms of the BSD licence?

In function "FF_DetermineFatType" when checking FAT12 you compare first byte (which is FATID) to 0xF8. This check is good for FAT formatted partitions but prevents from reading some floppy images.

According to Wikipedia FATID value can be either 0xF0 or in [0xF8-0xFF] range.

I have some image files formatted in FAT12 with different values in FATID from accepted range. They can be read by FullFAT without any problems after modifying check function.

Did you specifically restricted library to work only on partitioned disks or is it ok to extend check range?

The following functions declare complete FF_DIRENT objects on the stack, which can be quite large when LFNs are enabled.

FF_FindDir()
FF_CreateShortName()
FF_CreateFile()
FF_MkDir()

I propose a FF_PDIRENT type that uses pointers to the original path string provided,
with start and end pointers to delimit sub-strings.