jamesrandall / azurefromthetrenches.commanding Goto Github PK

More of a request than an issue.

There is some code I'm experimenting with in FunctionMonkey, but the roadblock Im running into is in: AzureFromTheTrenches.Commanding.Implementation.CommandRegistry
The RegisterHandler method is private and the Register methods that calls it assume .Single in some places that I want multiple (one class handling a generic cookie cutter abstraction of different handlers for REST). The easiest solution (and I have tested with reflection) would be to expose the RegisterHandler method publically in the interface. Thoughts?

Awesome library BTW. Im having more fun with FunctionMonkey(and by proxy this commanding lib) than I have in a long time.

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
1> at FunctionMonkey.Compiler.HandlebarsHelpers.HttpVerbsHelper.HelperFunction(TextWriter writer, Object context, Boolean toLowerCase, Object[] parameters) in C:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\HandlebarsHelpers\HttpVerbsHelper.cs:line 28
1> at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid5[T0,T1,T2,T3,T4](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4)
1> at FunctionMonkey.Compiler.HandlebarsHelpers.HttpVerbsHelper.<>c.b__0_1(TextWriter writer, Object context, Object[] parameters) in C:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\HandlebarsHelpers\HttpVerbsHelper.cs:line 15
1> at lambda_method(Closure , TextWriter , Object )
1> at HandlebarsDotNet.Handlebars.HandlebarsEnvironment.<>c__DisplayClass7_0.b__0(Object context)
1> at FunctionMonkey.Compiler.Implementation.JsonCompiler.Compile(IReadOnlyCollection`1 functionDefinitions, OpenApiOutputModel openApiOutputModel, String outputBinaryFolder, String outputNamespaceName) in C:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\Implementation\JsonCompiler.cs:line 34
1> at FunctionMonkey.Compiler.Implementation.FunctionCompiler.Compile() in C:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\Implementation\FunctionCompiler.cs:line 71
1> at FunctionMonkey.Compiler.Program.Main(String[] args) in C:\wip\myOpenSource\functionMonkey\Source\FunctionMonkey.Compiler\Program.cs:line 44

Could you please add the condition !x.IsAbstract() in CommandRegistry:

    public ICommandRegistry Discover(params Assembly[] assemblies)
        {
            Type commandHandlerBase = typeof(ICommandHandlerBase);
            foreach (Assembly assembly in assemblies)
            {
                Type[] handlers = assembly.GetTypes().Where(x => !x.IsAbstract() && commandHandlerBase.IsAssignableFrom(x)).ToArray();
                foreach (Type handler in handlers)
                {
                    Register(handler);
                }
            }
            return this;
        }

I'm using some abstract CommandHandler base classes with unspecified generic parameters that will crash FunctionMonkey when registered to the CommandRegistry.

Have a look here for info on the new HostingStartup attribute

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/platform-specific-configuration?view=aspnetcore-2.2

In short, I have several projects within a solution that all use this as (to me) it's a great way to add startup code to separate projects. I have a X.Core project where I'd like to setup the framework like below.

        // Add the Commanding Framework
        var adapter = new CommandingDependencyResolverAdapter(
            (fromType, toInstance) => services.AddSingleton(fromType, toInstance),
            (fromType, toType) => services.AddTransient(fromType, toType),
            resolveTo => _serviceProvider.GetService(resolveTo));
        var registry = adapter.AddCommanding();

Then need a way of getting the ICommandRegistry via the IWebHostBuilder builder I guess, so I can register query handlers from the other projects.

Please see this gist for a repo - https://gist.github.com/cjrpriest/b536bb69630fd8ff60b1e0089b5abae1

I get this exception thown on line 37:

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at AzureFromTheTrenches.Commanding.Implementation.CommandExecuter.<ExecuteCommandWithHandlers>d__10`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureFromTheTrenches.Commanding.Implementation.CommandExecuter.<ExecuteAsync>d__9`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at AzureFromTheTrenches.Commanding.Implementation.CommandExecuter.<ExecuteAsync>d__9`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureFromTheTrenches.Commanding.Implementation.CommandDispatcher.<DispatchAsync>d__6`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AzureFromTheTrenches.Commanding.Implementation.CommandDispatcher.<DispatchAsync>d__5.MoveNext()

Thanks :)

Hi,

Gett error when I try to execute method:
await _commandDispatcher.DispatchAsync(getStandardOrganizationQuery);

Error:
System.Private.CoreLib: Exception while executing function: LoadWorkflows. AzureFromTheTrenches.Commanding: Error occurred during command execution. AzureFromTheTrenches.Commanding: A handler of type ImportAsAService.Application.StandardOrganizations.Queries.GetStandardOrganization.GetStandardOrganizationQueryHandler is registered but resolution returned null. Please check IoC configuration.

I have implemented Azure function v3 in NET Core 3.1.

My startup.cs file:

[assembly: FunctionsStartup(typeof(Startup))]

namespace ImportAsAService.Service
{
    internal class Startup : FunctionsStartup
    {
        public override void Configure(IFunctionsHostBuilder builder)
        {
            var serviceProvider = builder.Services.BuildServiceProvider();
            var adapter = new CommandingDependencyResolverAdapter(
                (fromType, toInstance) => builder.Services.AddSingleton(fromType, toInstance),
                (fromType, toType) => builder.Services.AddTransient(fromType, toType),
                (resolveTo) => serviceProvider.GetService(resolveTo));
            var registry = adapter.AddCommanding();

            registry.Register<GetStandardOrganizationQueryHandler>();

            ... other service registration
        }
    }
}

I don't understand what I'm missing here. Please help me.

Thank you,
Indulis