sprite-factory assumes unique basenames are used about sprite-factory HOT 6 CLOSED

You're right, that is an issue. The current library simply assumes that all the files live in a single directory and have unique names - in fact its a fluke that it picks up images in the sub-directories at all!

Obviously, short term, the recommendation would be to either sprite those sub-directories individually, or put all images into a single directory and give them unique names (e.g. "icons_client.png" and "titles_client.png")...

... but I can see that being a useful feature. I think the trick to backward compatibility would be to get the sprite factory to use a relative path name (e.g relative to input - the top level folder being sprited). So if the target is a single folder (like the current tests) then the base file name will end up being used (same as today), but if the target contains sub folders (like your example) then the library should take the relative path (e.g. icons/client.png) and replace '/' with '_', ending up with "icons_client" as the css class name

... but might take a little effort to get it working cleanly. I'll try to look into this for the next version.

Thanks for the suggestion.

from sprite-factory.

Ah, good thinking. That sounds like the right approach to me.

I'm happy to have a shot at implementing this if that'd be helpful. Let me know what works for you.

from sprite-factory.

I'll take a look at it this weekend and let you know how it goes.

from sprite-factory.

Latest master branch should fix this issue.

For your earlier example, you should now see unique classnames icons_client and titles_client in the generated CSS.

Let me know if that works for you, and I'll see about releasing a new version of the Gem.

Thanks!

from sprite-factory.

I released a new gem - version 1.4.2 with this fix in it.
notes

from sprite-factory.

Thanks @jakesgordon, 1.4.2 works a treat.

from sprite-factory.