jahia / bootstrap4 Goto Github PK

Current behavior

When adding a new grid/layout component, can can choose several mixin that allow to

1. CREATE ABSOLUTE AREAS
2. CREATE CONTAINER
3. CREATE HTML5 SEMANTIC ELEMENTS
4. CREATE ROW AND COLUMNS
5. LIMIT THE NUMBER OF ELEMENTS

This order is really not intuitive and should be

1. CREATE HTML5 SEMANTIC ELEMENTS
2. CREATE CONTAINER
3. CREATE ROW AND COLUMNS
4. LIMIT THE NUMBER OF ELEMENTS
5. CREATE ABSOLUTE AREAS

It would be great to be able to select our custom root from a page picker. For that I would like to have a new choice in the root choicelist which enable the mixin below.

[bootstrap4mix:customNavbarRoot] > jmix:templateMixin mixin
 extends = bootstrap4nt:navbar
 - customRoot (weakreference, picker[type='page']) < 'jnt:page'

<c:set var="curentPageNode" value="${jcr:getMeAndParentsOfType(renderContext.mainResource.node,'jnt:page')}"/>
return an array but is not managed as his.

e.g. If I create this hierarchy Page Lvl0 -> Lvl1 -> Lvl2

if I add a navbar in Lvl2 and select currentPage as starting point, curentPageNode is equals to [node /sites/i8/lvl0/lvl1/lvl2, node /sites/i8/lvl0/lvl1, node /sites/i8/lvl0]

to fix this we have to check if currentPage is not empty and extract the first element

<c:if test="${fn:length(curentPageNode) > 0}">
    <c:set var="curentPageNode" value="${curentPageNode[0]}"/>
</c:if>

We are migrating our references Jahia templates from Bootstrap V3 to BootstrapV4.

Definition :

[bootstrap3nt:navBarItemLanguageSwitcher] > jnt:content, bootstrap3mix:navBarItem, jmix:studioOnly
 - typeOfDisplay (string, choicelist[resourceBundle]) = 'isoLocaleCountryCode' mandatory indexed=no < 'isoLocaleCountryCode', 'languageCode', 'doubleLetter', 'letter', 'nameInLocale', 'nameCurrentLocale', 'flag'

in file:
BootstrapV3 definition

Associated view

But there is no equivalent in Boostrap V4... is it possible to add it in the V4 standard components?
Regards,

REM: same problem for bootstrap3nt:navBarItemLoginForm, bootstrap3nt:navBarItemSimpleSearchForm, etc... that are not migrated.

when you rename, or change the row type (predefined or customs...) the module create new node and don't remove existing one.
It would be great to rename row node or to move the content from one to another in order to keep the content and also to be sure the system doesn't create "ghost" node.

in the image below, I just change predefined grid to custom grid to select a 7/5 (new node col0 and col1) instead of 8/4 and this create a couple of dead node (main & side) I cannot see in edit mode.

It would be great to have a modal for the login instead of the current dropdown list

The card property freeFooter has the same name than the sublist freeFooter. So there is a conflitct.

Hi,
I tested the new switch language bar and it is very helpful !
However, I think it could have an issue in the HTML generated which use a <a class="nav-link"> instead of a button. The result with the default BS4 css is the following :

The link in the language switcher use the primary color and I am not sure it is the expected color for this element.
If you use a button you have this result :

So you don't need to write a specific css and the color of the button is the default color of the text...
The code with the button is that one :

<div class="btn-group">
    <button type="button" class="btn dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
        FR
    </button>
    <div class="dropdown-menu">
        <a class="dropdown-item" href="#">EN</a>
    </div>
</div>

It seems that there is a bug during list rename

String newListName = currentListName.replace(gridName + '-', '').replace(gridName, '');

For instance here is the result of the output

 - Rename [grid1-main] to [1-main] /sites/www/home/landing-pages/agile-content-management/pagecontent/agile-content-management/grid/grid1-main
 - Check if list [1-main] exists and if it's empty for path /sites/www/home/landing-pages/agile-content-management/pagecontent/agile-content-management/grid/1-main
 - Rename /sites/www/home/landing-pages/agile-content-management/pagecontent/agile-content-management/grid/grid1-main to /sites/www/home/landing-pages/agile-content-management/pagecontent/agile-content-management/grid/1-main

Need to check if it's old ghost content, and if yes, then we should report it. Here is an example:

Hi,
Bootstrap is used to design responsive website, and most of them have 2 different logo, one for large screen and one for mobile screen.
So I think it should be useful to have a property available by default in the Brand mixin to manage mobile logo.

I tried to install Bootstrap4 module from Jahia Studio but it gave the following error:

Package https://store.jahia.com/files/live/sites/private-app-store/contents/modules-repository/packages/Bootstrap4/Bootstrap4-4.6.2/bootstrap4_package_4.6.2.jar need the license org.jahia.core to be installed.

Fix version:

Functional requirement

As a

I want to

In order to

Acceptance criteria

Given

When

Then

Designer notes

Developer notes

QA notes

Documentation notes

Non-functional requirements

• Security
  • Identity management
  • Authentication
  • Authorization
  • Session management
  • Data validation
  • Error handling
• Performances
• Migration
• Documentation

I created a button (collapse) to display or not a Form.

I want to create a Goals in jExperience to track click on this collapse.

But, to be able to track the action jExperience needs a ID or a Name into the link and for now we don't have one.
So, we have to :

• option 1 : define an arbitrary ID/Name

• option 2 : offer a field in the contributor UI to fill an id or a name to the link.

Maybe option 2 is better because the link ID has to be "stable" in the time in order to keep the tracking history safe.

The mixin jmix:browsableInEditorialPicker should be added on the grids/tabs/mediaObject/collapse/button/cards/carousel