Giter Club home page Giter Club logo

Comments (6)

JaGeo avatar JaGeo commented on July 20, 2024 1

Meanwhile, @naik-aakash and I will be thinking about how to make this documentation part more discoverable.

from lobsterpy.

srmnitc avatar srmnitc commented on July 20, 2024 1

Perfect @JaGeo! That works, I was able to run the tests. Once again, a link to the dev docs would be nice, but everything works very well. Feel free to close the issue.

from lobsterpy.

JaGeo avatar JaGeo commented on July 20, 2024 1

Could you please download the latest main branch, upgrade the pymatgen version (pip install --upgrade pymatgen) and check if the error persists? I assume it is a related to a very recent upgrade in pymatgen. @naik-aakash fixed that error yesterday here on the main branch.

from lobsterpy.

srmnitc avatar srmnitc commented on July 20, 2024 1

Could you please download the latest main branch, upgrade the pymatgen version (pip install --upgrade pymatgen) and check if the error persists? I assume it is a related to a very recent upgrade in pymatgen. @naik-aakash fixed that error yesterday here on the main branch.

This solution worked, thanks.

from lobsterpy.

JaGeo avatar JaGeo commented on July 20, 2024

Thank you, @srmnitc . Could you check if this description works: https://jageo.github.io/LobsterPy/dev/dev_installation.html ?

If not, please let us know and we are happy to help.

from lobsterpy.

srmnitc avatar srmnitc commented on July 20, 2024

One of my tests failed, could you please tell me if I should do anything more?

============================================================================================== FAILURES ===============================================================================================
_______________________________________________________________________________ TestCLI.test_calc_quality_summary_nacl ________________________________________________________________________________

self = <tests.cli.test_cli.TestCLI object at 0x7f009bdecf90>, tmp_path = PosixPath('/tmp/pytest-of-menon/pytest-59/test_calc_quality_summary_nacl0')

    def test_calc_quality_summary_nacl(self, tmp_path):
        os.chdir(TestDir / "test_data/NaCl_comp_range")
        calc_quality_json_path = tmp_path / "calc_quality_json.json"
        args = [
            "description-quality",
            "--potcar-symbols",
            "Na_pv Cl",
            "--bvacomp",
            "--doscomp",
            "--erange",
            "-20",
            "0",
            "--file-calc-quality-json",
            str(calc_quality_json_path),
        ]
        captured_output = io.StringIO()
        sys.stdout = captured_output

        test = get_parser().parse_args(args)
>       run(test)

/mnt/c/Users/menon/Documents/winrepos/projects-joss/LobsterPy/tests/cli/test_cli.py:376:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/mnt/c/Users/menon/Documents/winrepos/projects-joss/LobsterPy/lobsterpy/cli.py:1166: in run
    quality_dict = Analysis.get_lobster_calc_quality_summary(
/mnt/c/Users/menon/Documents/winrepos/projects-joss/LobsterPy/lobsterpy/cohp/analyze.py:1608: in get_lobster_calc_quality_summary
    vasprun = Vasprun(path_to_vasprun)
/home/menon/miniconda3/envs/lobsterpy3/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py:296: in __init__
    self.update_potcar_spec(parse_potcar_file)
/home/menon/miniconda3/envs/lobsterpy3/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py:1054: in update_potcar_spec
    if potcar := self.get_potcars(path):
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <pymatgen.io.vasp.outputs.Vasprun object at 0x7f00960593d0>, path = True

    def get_potcars(self, path: str | Path) -> Potcar | None:
        """
        Returns the POTCAR from the specified path.

        Args:
            path (str | Path): The path to search for POTCARs.

        Returns:
            Potcar | None: The POTCAR from the specified path or None if not found/no path specified.
        """

        if not path:
            return None

        if isinstance(path, (str, Path)) and "POTCAR" in str(path):
            potcar_paths = [str(path)]
        else:
            search_path = os.path.split(self.filename)[0] if path is True else str(path)
            potcar_paths = [
>               f"{search_path}/{fn}" for fn in os.listdir(search_path) if fn.startswith("POTCAR") and ".spec" not in fn
            ]
E           FileNotFoundError: [Errno 2] No such file or directory: ''

/home/menon/miniconda3/envs/lobsterpy3/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py:1010: FileNotFoundError
======================================================================================== slowest 30 durations =========================================================================================
16.99s call     tests/cli/test_cli.py::TestCLI::test_cli_interactive_plotter_coops
4.83s call     tests/cli/test_cli.py::TestCLI::test_cli_interactive_plotter_cobi
3.64s call     tests/cli/test_cli.py::TestCLI::test_calc_quality_summary_nacl
1.26s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args0]
1.24s call     tests/cli/test_cli.py::TestCLI::test_hideplot_cli
1.14s call     tests/cli/test_cli.py::TestCLI::test_cli_interactive_plotter
0.57s call     tests/cli/test_cli.py::TestCLI::test_icoxxlist_plots
0.48s call     tests/cli/test_cli.py::TestCLI::test_iaplot_saved
0.47s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args2]
0.47s call     tests/cli/test_cli.py::TestCLI::test_json_saved
0.38s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args1]
0.34s call     tests/cli/test_cli.py::TestCLI::test_plot_saved
0.32s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args3]
0.31s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args5]
0.30s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args4]
0.22s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args8]
0.21s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args7]
0.21s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args15]
0.20s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args11]
0.19s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args13]
0.18s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args14]
0.18s call     tests/cli/test_cli.py::TestCLI::test_lobsterin_generation
0.17s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args16]
0.17s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args10]
0.17s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args17]
0.16s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args6]
0.16s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args18]
0.16s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args12]
0.15s call     tests/cli/test_cli.py::TestCLI::test_cli_results[args9]
0.15s call     tests/cli/test_cli.py::TestCLI::test_lobsterin_generation_error
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
1 failed, 34 passed in 40.02s

from lobsterpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.