Giter Club home page Giter Club logo

Comments (17)

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024 1

Here is my additional comment:

For the potpaw.64, as stated on vasp wiki, the updated potentials with respect to the potpaw.54 set are as follows:

image

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024 1

I am uploading the scripts that I used at the time to get the information for 1.
Script_to_get_available_basis_functions.zip
There is a list of all available basis functions in LOBSTER (PBE VASP fit basis set).

  1. I think I excluded them at the time. You might need to check the format
  2. As said, we are working on this part as well. We might release more information

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

So, I simply used the occupations from the POTCAR files to determine which orbitals should be occupied and therefore are needed for the projection (min). Then, we added all potentially available unoccupied orbitals to max.
In LobsterPy and the workflows, we iterate over all combinations in between min and max possible basis per element.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

The spaces are an artefact of how I produced the files.

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024
  1. The trailing space should be removed, IMHO.
  2. The standard basis set used in your package is inconsistent with the one shown on vasp wiki, say, for Cd, the Valence electron configuration of the standard PBE.54 potential is shown as follows:

image

But the one used in your package, which we also have discussed before, is as follows:

image

  1. What do the fractional superscripts mean used on the vasp wiki for indicating the Valence electron configuration, as shown below:
    image

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024
  1. The trailing space should be removed, IMHO.
  2. The standard basis set used in your package is inconsistent with the one shown on vasp wiki, say, for Cd, the Valence electron configuration of the standard PBE.54 potential is shown as follows:

image

But the one used in your package, which we also have discussed before, is as follows:

image

  1. What do the fractional superscripts mean used on the vasp wiki for indicating the Valence electron configuration, as shown below:
    image
  1. I personally think it is a small issue.
  2. As said: we rely on the POTCARs for the determination of the valence. We use their valence electron count to figure out what they treat as valence electrons.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024
  1. The trailing space should be removed, IMHO.
  2. The standard basis set used in your package is inconsistent with the one shown on vasp wiki, say, for Cd, the Valence electron configuration of the standard PBE.54 potential is shown as follows:

image
But the one used in your package, which we also have discussed before, is as follows:
image

  1. What do the fractional superscripts mean used on the vasp wiki for indicating the Valence electron configuration, as shown below:
    image
  1. I personally think it is a small issue.
  2. As said: we rely on the POTCARs for the determination of the valence. We use their valence electron count to figure out what they treat as valence electrons.
    To compare with the VASP wiki, you would need to look into the min file.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

I will try to dig out the script that I used to produce these files. If you are interested, you are surely invited to add the corresponding files for the new POTCARs to pymatgen and extend the functionality. (I opened an issue on pymatgen on this topic a while back)

materialsproject/pymatgen#3840

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024

As far as I can think of at the moment, I am mainly interested in the following aspects w.r.t the basis sets of VASP potcars:

  1. Basis sets on-the-fly generation based on the system's POTCAR under study and dynamically determine which type of basis set should be used for the materials' current properties of interest.
  2. Extending the above idea to GW potentials.
  3. The standard for determining whether a basis set is appropriate or not.

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024

I don't know why you posted this #306 (comment) twice.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

I don't know why you posted this #306 (comment) twice.

By accident

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024

I am uploading the scripts that I used at the time to get the information for 1.
Script_to_get_available_basis_functions.zip
There is a list of all available basis functions in LOBSTER (PBE VASP fit basis set).

  1. However, LOBSTER itself does not provide the following file used in your script, aka, availabe_basis_functions:
#read in all available basis functions
available_basis_functions={}
with zopen("availabe_basis_functions") as f:
    data = f.read().split("\n")

image

So, I'm still not sure how you made the availability basis_functions file here.

  1. If I understand correctly, according to the latest lobster version's user manual shown above and the description here, as shown below, Lobster itself has not fully implemented the corresponding support for the latest VASP potpaw.64. So, is our discussion about updating basis sets still reasonable?

image

  1. Also see here for the related Data and code of https://doi.org/10.1002/cplu.202200123.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

I am uploading the scripts that I used at the time to get the information for 1.
Script_to_get_available_basis_functions.zip
There is a list of all available basis functions in LOBSTER (PBE VASP fit basis set).

  1. However, LOBSTER itself does not provide the following file used in your script, aka, availabe_basis_functions:
#read in all available basis functions
available_basis_functions={}
with zopen("availabe_basis_functions") as f:
    data = f.read().split("\n")

image

So, I'm still not sure how you made the availability basis_functions file here.

  1. If I understand correctly, according to the latest lobster version's user manual and the description here, as shown below, Lobster itself has not fully implemented the corresponding support for the latest VASP potpaw.64. So, is our discussion about updating basis sets still reasonable?

image

  1. Also see here for the related Data and code of https://doi.org/10.1002/cplu.202200123.
  1. I got the file from the LOBSTER developers.
  2. If it is not implemented and supported yet, then we might wait until it is. You can also ask the Lobster people about it.

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024
  1. I got the file from the LOBSTER developers.

May I ask if the LOBSTER developers allow users to freely redistribute this file? If so, could you privately send me a copy? Otherwise, I can try contacting the LOBSTER developers to request one.

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

I think it is uploaded here. It's just a text file including all available basis functions.

from lobsterpy.

hongyi-zhao avatar hongyi-zhao commented on August 22, 2024

Sorry, you are right, it has been included in the Script_to_get_available_basis_functions.zip you uploaded earlier, as shown below

werner@x13dai-t:~/Public/repo/github.com/JaGeo/Script_to_get_available_basis_functions$ find . -type f -name 'availabe_basis_functions'
./MaxBasis/availabe_basis_functions
./MinBasis/availabe_basis_functions

from lobsterpy.

JaGeo avatar JaGeo commented on August 22, 2024

In my opinion: this was anwered

from lobsterpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.