Giter Club home page Giter Club logo

react-native-action-sheet-component's Issues

Wrong position when using Icons

ActionSheet has 3 items, every with icon in size 42, position: doesn't matter, problem is in both.
Initial position is wrong, first (for top position is last) item is visible:
start_position
If 'Show' appearing works correctly:
end_position
If 'Hide' after that position will be right. Problem only with initial position.

Actionsheet do not completely hide when having too many children

As title, it is easy to reproduce, please see below:

      ActionSheetManager.show({
        style: ThemeStyles.generalItemBg,
        separatorStyle: ThemeStyles.generalItemBorder,
        showSelectedIcon: false,
        children: [
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />,
          <ActionSheetItem
            key={uuid.v4()}
            text={<Text style={ThemeStyles.authorComment}>Share This!</Text>}
            onPress={() => )}
          />
         ]})

ActionSheet bottom position

Test case using react-native-navbar

  render() {
    return (
      <View style={{ flex: 1, backgroundColor: '#DDDDDD' }}>
        <NavigationBar
          style={{ backgroundColor: '#ABC' }}
          title={{ title: 'Home' }}
          rightButton={{ title: 'Choose', handler: () => this.actionSheet.show() }}
        />
        <ActionSheet
          ref={(actionSheet) => { this.actionSheet = actionSheet }}
          position="bottom"
          onChange={this.onChange}
        >
          <ActionSheetItem
            text="Github"
            value="item1"
            selectedIcon={checkedIcon}
            onPress={this.onItemPress}
          />
          <ActionSheetItem
            text="Facebook"
            value="item2"
            selectedIcon={checkedIcon}
            onPress={this.onItemPress}
          />
        </ActionSheet>
      </View>
    )
  }

When selecting an item the first time, there is still some white overlap from the action sheet at the bottom of the view. But subsequent item selections clear it up.

image

ActionSheetManager is not showing items

I have a problem with ActionSheetManager when usage like this:

import React, { Component } from 'react';
import { Button } from 'react-native';
import ActionSheetManager, { ActionSheet, ActionSheetItem } from 'react-native-action-sheet-component';

export default class App extends Component {
  render() {
    const options = {
      children: [
        <ActionSheetItem
          key='item-1'
          text="Item 1"
          value="item1"
        />,
        <ActionSheetItem
          key='item-2'
          text="Item 2"
          value="item2"
        />
      ],
    };

    return (
      <Button onPress={() => ActionSheetManager.show(options)} title="Open" />
    );
  }
}

Index is always -1 

import React, { Component } from 'react'
import { View, Text, StyleSheet, TouchableOpacity } from 'react-native'
import Ionicons from 'react-native-vector-icons/Ionicons'
import { ActionSheet, ActionSheetItem } from 'react-native-action-sheet-component'
import NavigationBar from 'react-native-navbar'

const checkedIcon = <Ionicons name="ios-checkmark-outline" size={30} />

export default class ActionSheetExample extends Component {
  constructor(props) {
    super(props)

    this.state = {
      selectedItems: [],
    }
  }

  onChange = (value, index, values) => {
    console.log('OnChange()', 'value:', value, 'index:', index, 'values:', values)
    this.setState({ selectedItems: values })
  }

  onItemPress = (value, index) => {
    console.log('OnItemPress()', 'value:', value, 'index:', index)
  }

  showActionSheet = () => {
    this.actionSheet.show()
  }

  render() {
    return (
      <View style={{ flex: 1, backgroundColor: '#DDDDDD' }}>
        <NavigationBar
          style={{ backgroundColor: '#ABC' }}
          title={{ title: 'Home' }}
          rightButton={{ title: 'Choose', handler: () => this.actionSheet.show() }}
        />
        <ActionSheet
          ref={(actionSheet) => { this.actionSheet = actionSheet }}
          position="bottom"
          onChange={this.onChange}
        >
          <ActionSheetItem
            text="Github"
            value="item1"
            index={0}
            selectedIcon={checkedIcon}
            onPress={this.onItemPress}
          />
          <ActionSheetItem
            text="Facebook"
            value="item2"
            index={1}
            selectedIcon={checkedIcon}
            onPress={this.onItemPress}
          />
        </ActionSheet>
      </View>
    )
  }
}
OnItemPress() value: item1 index: -1
OnChange() value: item1 index: -1 values: ["item1"]
OnItemPress() value: item2 index: -1
OnChange() value: item2 index: -1 values: ["item2"]

At first I thought index would be auto set by the ActionSheet, so then I tried specifying explicitly in props (see above).

Perhaps ActionSheet could set index automatically if not specified in props?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.