jack-gledhill / imago Goto Github PK

Reported by: JackTEK#6669

Short Description

Using an invalid token returns a 500 instead of a 403/401

Steps to Reproduce

• Use an invalid token on the /api/upload route
• Observe what ShareX has to say about it

Expected Result

You get a 403/401

Actual Result

You get a 500, indicating something hard-errored somewhere

Software version: Imago v4.2.0 (unreleased)
System settings: Windows 10 Home (1909)

Reproducibility

✅ JackTEK#6669: Confirmed bug

Attachments

Nothing was attached to this report.

Development Notes

Nothing to note for this report.

This is missing a dark mode and it's burning my eyes! Please fix!

Proposal
Allow mobile support for Imago. This enhancement would include the following upgrades:

• Support for mobile browsers, Currently, Pressing the "Login" button does not do anything on mobile browsers (Tested on Safari Mobile, FireFox Mobile, and Chrome Mobile. Also occurs in non-chromium desktop browsers. See #6 for more info)

• Login page background and login box should scale to the size of the device, to make the page look clean just as it does on desktop

Why?
This enhancement could have many purposes for many users. First, It would allow moving content from mobile devices to Desktop. As mentioned in #3, Upload servers can be very useful for moving images or other files from a mobile device on to a desktop device, with simplicity and ease. Currently however, This is not a possibility due to the lack of mobile support

Expected and Current result
Currently, The mobile site looks smashed, the background does not scale, and the ascetics are overall terrible. Although this isn't a major issue, it would be nice for the site to look just as beautiful as it does on Desktop. The expected result here is simple: The page elements, background, and all content would scale down and position to places that are more mobile-friendly. Maybe tabs could be hidden and opened again with a drop down or something of such. Also currently, you are unable to login to the site via a mobile browser. This is most likely related to the issues mentioned in #6, however it is still relevant to this issue as it makes using the site on mobile impossible, rather then just ugly.

Image

Proposal
Change Imago webhooks to feature more information-rich, better looking, and overall more fancy style messages, to assist users is knowing more information about an upload, and to keep logs looking nice.

Why
This enhancement would be a good idea for a few reasons. First of all, It would be nice to have more information in the webhook logs. Currently these webhook logs act as simple events to show what occurred, and don't really provide any information on when, who, and how it occurred. They also simply don't look all that great. A good example of this can be found from ShareX Upload Server, which is a different upload server created by Tanner. In ShareX Upload server, when an event happens, such as a new file being uploaded, It also posts to Discord logs (Does not use webhooks, however same concept). As you can see from this image, their logging messages are in code block, color coded (using markdown syntax highlighting), provide a ton of useful information (such as IP, links, file type), and overall look very nice. For Imago, there could be some very useful information to provide, such as the User who uploaded it, The file size, The file type, and more. For short links, information such as the original, and new link, the user, and other information could be provided. Currently, Imago webhooks look this this. One thing I will compliment here are the administrator messages. The use of emojis look very nice, however the information could be presented in a cleaner more table-like way. The upload/action webhook however, I very much so dislike. For shortlinks, the only information provided is the user, old and new link, and for file uploads you do not get a webhook method at all. I think this could have major improvements on not only the looks of these logs, but the overall experience of knowing when/where/who uploaded and did whatever action. Maybe the use of embed's here could be a very nice touch?

Proposal
Add a feature to upload files and images directly from the website dashboard, to make it easier to upload files without the use of ShareX. An example of this can be found used by ShareX Upload Server, where you can upload files directly from the site.

Why is this an improvement?
This would be a major improvement to imago. Having to use ShareX or another server to upload files could be a hassle in some cases. For example, If someone wanted to upload a file on mobile, and go to the link on PC to download the file (transfer it easily from mobile to PC) then this would be possible, and would be a very quick and efficient method. It also allows users on Linux, who can't use ShareX, not have to worry about using other software comparable with Linux. This makes uploading files easier, more efficient, and overall less of a hassle.

Can you possibly add a wiki page, with the installation process, as the site you linked is not longer available. Thanks <3

Reported by: JackTEK#6669

Short description

Login background is not resized to fill screen properly

Steps to reproduce

1. Go to a login screen on a laptop-sized screen
2. Observe the background image

Expected result

The image should be properly resized to fill the screen

Actual result

It seems to flood out of the screen with no option to scroll

Software version: Imago v4.2.1-stable

Approvals

✅ JackTEK#6669: Confirmed bug

Denials

Nothing to show.

Attachments

📌 JackTEK#6669: Example

Notes

Nothing to show.

Proposal
Allow imago support on browsers that are NOT chromium based.

Why?
This would be an extreme enhancement to Imago, and should've been implemented in the first place, so much though that it's a bug. Currently, Logging in the Imago only works on Chromium-based Desktop Browsers, Tested on Edge, Chrome, and Chromium, FireFox Developer Edition, Firefox, Safari, Safari Mobile, Chrome Mobile IOS, FireFox Mobile IOS. You may notice, all of the bold browsers are Chromium-based Desktop browsers. This is a major downside to Imago for a few reasons:

1. Creates a large struggle for Linux users, as many use FireFox (As it's stock, and better supported)
2. Is simply stupid. Supporting only a select few browsers is extremely restrictive, and leaves many users forced to use a browser they wouldn't otherwise use, just to have Imago. This could cause many users to not use the platform, due to the hassle of moving from their favorite browser. This enhancement would give Imago much more support for browsers and users, and would most likely contribute to the popularity of the project!

What occurs? What should occur?
Currently, attempting to login on a non-Chromium-based browser causes the site to simply refresh. When pressing the login button (And/or pressing enter) the site simply refreshes, and will not log in. The expected result is that the site will log the user in like normal, and that it would support many more popular-browsers.

Opening in reference to #4
I'm running this directly on a public IP (no nginx) and get an error when I try to upload with ShareX

[2020-04-22 20:07:31,575] ERROR in app: Exception on /api/upload [POST]
Traceback (most recent call last):
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/root/imago/imagoweb/plugins/api.py", line 219, in upload_file
    file.save(f"static/uploads/{discriminator}")
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/werkzeug/datastructures.py", line 3066, in save
    dst = open(dst, "wb")
FileNotFoundError: [Errno 2] No such file or directory: 'static/uploads/aM8OBnt2.png'
[2020-04-22 20:07:32,618] ERROR in app: Exception on /api/upload [POST]
Traceback (most recent call last):
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/root/imago/imagoweb/plugins/api.py", line 219, in upload_file
    file.save(f"static/uploads/{discriminator}")
  File "/root/anaconda3/envs/imago/lib/python3.6/site-packages/werkzeug/datastructures.py", line 3066, in save
    dst = open(dst, "wb")
FileNotFoundError: [Errno 2] No such file or directory: 'static/uploads/Oh6vhksQ.png

I'm running this in a conda environment as opposed to a virtual environment.

I think I missed something during setup. I made a postgresql db and username but when I view the table for users, nothing shows up. Is there an installer setup that I should run? I get redirected to /api/login but never signed up.