jacaseyclyde / multimessenger_smbhbs Goto Github PK

Is your feature request related to a problem? Please describe.
The normalization parameter in our AGN-proxy model is not very intuitive.

Describe the solution you'd like

• Update the AGN-proxy model parameterization to utilize the number densities of SMBHBs and AGN directly.

Describe alternatives you've considered
This isn't totally necessary from a technical standpoint, but it avoids some future headaches.

Additional context
Relevant to Issue #3.

Is your feature request related to a problem? Please describe.
I am not sure the dependencies are all correct.

Describe the solution you'd like

• Verify the contents of requirements.txt.
• Verify the contents of setup.py.

Describe alternatives you've considered

• Verify the conda environment.

Additional context
None.

Is your feature request related to a problem? Please describe.
Using Mingeralli et al. (2017) to initially estimate the local number density is confusing to follow from an analysis perspective.

Describe the solution you'd like
We should use the self-consistent AGN-based model from the get-go, and then compare it to M17 after the fact.

Describe alternatives you've considered
None. This needs to happen to be clear and self-consistent as a model.

Additional context
Jenny and Andy are both adamant about this. It makes a lot of sense to do it this way.

Is your feature request related to a problem? Please describe.
We expect to be able to measure the gravitational wave background and need to constrain the SMBHB population with this measurement.

Describe the solution you'd like
Markov Chain Monte Carlo fitting of SMBHB population models.

Describe alternatives you've considered
We might be able to get away with a simpler solution by fitting just the local density while keeping the mass and volume of the background fixed. However, the volume may be in question.

Additional context
We should differentiate from the various Middleton & Chen models.

Is your feature request related to a problem? Please describe.
Considering we use AGN as a basis, we should be able to analyze at least the local duty cycle.

Describe the solution you'd like

• Create an analysis of what the local AGN duty cycle is.

Describe alternatives you've considered

• Analyze the evolution of the duty cycle over redshift.

Additional context
None.

Is your feature request related to a problem? Please describe.
Documentation throughout the project is generally lacking right now.

Describe the solution you'd like
Improved documentation in both the python files that define models and the notebooks that run the analysis.

• Update documentation in agn_proxy.py
• Update documentation in major_merger.py
• Add Introduction to notebook 1
• Add documentation/explanations to notebook 1
• Add documentation/explanations to notebook 2
• Add documentation/explanations to notebook 3
• Add documentation/explanations to notebook 4

Describe alternatives you've considered
Consolidation of similar code into more generalized functions, reducing the overall load of documentation.

(optional)

• Write generalized functions to consolidate analysis code
• Write generalized functions to consolidate plot generation codes

Additional context
Documentation will help others understand this code, including future versions of the authors.