j-puls / thorium-ui Goto Github PK

Currently, when you click on the outer NavItem portion of a NavLink, nothing happens. The click event should be passed to the child component so that a click anywhere within the parent will trigger navigation

Styling the body currently breaks the styling conventions used by all other Thorium based components. To reduce confusion and streamline the API, this should be internalized.

Because Thorium-UI is focused on internalizing styling into the JavaScript rather than importing CSS, this can lead to a steady decrease in component performance (and increased JS execution at runtime). The entire code base needs to constantly be monitored for areas where additional performance can be squeezed out where possible.

Places to keep an eye on

• useEffect hooks - occasionally a sub-optimal effect implementation can lead to multiple "invisible" re-renders
• dynamic imports - make sure only the essential parts of packages and modules are being imported, and only when they're actually needed
• style definitions - styles in Thorium-UI are just JavaScript objects. The bulkier these are, the longer they will take to import and parse. Default styles should be kept to a minimum

If you have a suggestion for a major performance overhaul, please create a new issue so it can be discussed in detail.

Currently, there are very minimal tests written for Thorium-UI components. This is mainly due to the volatile state that the project is in currently. As a stable build of the framework draws closer, it will become increasingly important to have reliable test cases.