iyzico / iyzipay-ruby Goto Github PK

I can work on a PR if that's needed.

After developments done on the backend side,

• Boolean field trusted should be added under Buyer object inside payment auth requests.
• bankCardHolderName should be added to payment auth's responses as a String.

To avoid NoMethodError (undefined method 'include?' for 3350.0:Float).

The documentation declares both price and paidPrice as Decimals. However, when passing Float to the gem, it raises NoMethodError. format_price method in pki_builder.rb should convert floats to strings before performing include? check.

Aynen bu adreste belirtildiği şekilde işlemi yapıyorum, ancak 3d secure sayfasını da başarıyla geçtikten sonra

{"status"=>"failure", "error_code"=>"5087", "error_message"=>"Üye işyerine ait ödeme kaydı bulunamadı", "locale"=>"tr", "system_time"=>1635256083213, "conversation_id"=>"123456789"}

bu şekilde hata alıyorum. Bunun sebebi ve çözümü nedir?

Ruby 2.1 and 2.2 are no longer maintained and they don't receive security updates. We should consider dropping older versions. This will allow us to use newer dependencies (#33, #34) and focus on other features.

Is this gem maintained? If not, I could help, there're some issues and pull requests that need to be resolved.

Right now options have to be passed in every request in the app. With global configuration we can set options only once. Configurable may be used for this.

adds pos order id to payment resource

Rails 5 depends on rack 2.x. So the rack should be updated.

Rails: 6.0.2.1
Ruby: 2.7.0p0 (2019-12-25 revision 647ee6f091)
Bundler: 2.1.4

Release 1.0.45 seems to fail when installing with bundler in Rails6.

I have created a brand new Rails6 project and added iyzipay to the gemfile.
When I run bundle, bundler installs version 1.0.44 of the gem,
which depends on rest-client ~> 1.8, which is not working properly as tests shows that:

...
KeyError:
      key not found: :ciphers
      # /Users/furkanenes/.rvm/gems/ruby-2.7.0/gems/rest-client-1.8.0/lib/restclient/request.rb:163:in `fetch'
      # /Users/furkanenes/.rvm/gems/ruby-2.7.0/gems/rest-client-1.8.0/lib/restclient/request.rb:163:in `initialize'
      # /Users/furkanenes/.rvm/gems/ruby-2.7.0/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in `new'
      # /Users/furkanenes/.rvm/gems/ruby-2.7.0/gems/rest-client-1.8.0/lib/restclient/request.rb:41:in `execute'
      # /Users/furkanenes/.rvm/gems/ruby-2.7.0/gems/rest-client-1.8.0/lib/restclient.rb:69:in `post'
      # ./lib/iyzipay/http_client.rb:8:in `post'
      # ./lib/iyzipay/model/threeds_payment.rb:12:in `retrieve'
      # ./spec/threeds_payment_spec.rb:218:in `block (2 levels) in <top (required)>'
...
# Same error occurs in all 39 tests

I believe this is a rest-client related problem due to this issue.

The solution is simply updating rest-client to ~> 2.0, which is already done in iyzipay 1.0.45.
But the problem is that when you force bundler to install iyzipay 1.0.45 in your gemfile, like:

gem 'iyzipay', '~> 1.0.45'
# or
gem 'iyzipay', '1.0.45'

Following output occurs when you run bundle:

Fetching gem metadata from https://rubygems.org/............
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "rack":
  In snapshot (Gemfile.lock):
    rack (= 2.2.2)

  In Gemfile:
    rails (~> 6.0.2, >= 6.0.2.1) was resolved to 6.0.2.1, which depends on
      actionpack (= 6.0.2.1) was resolved to 6.0.2.1, which depends on
        rack (~> 2.0, >= 2.0.8)

    iyzipay (~> 1.0.45) was resolved to 1.0.45, which depends on
      rack (~> 1.6.4)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

I think the problem is that rack dependency of rails6 (actionpack 6) fails to comply with iyzipay rack dependency, which is 1.6.4.

I have forked the repository and updated rack dependency to 2.0, which forced me to update rspec and rspec-rails dependencies to 3.8.0.

Currenty the tests and my rails6 project are working perfectly well but further testing is required in order to maintain backwards compability of the gem.

I'll generate a PR and hope that this simple solution works for everybody.

There is some lackness on subscription params in this document. There is no customer key or its definition for customer info but in node js lib tests for subscription you used customer key. I think you should specify how should be params and put a test JSON params on documents.

rest-client hasn't been updated for a while. rest-client itself locks the major version of mime-types and http-cookie, this may cause conflicts when using the gem in apps with newer versions of those gems.

It's causing issues when you have the latest version of rest_client(v2.0) in your Gemfile