BUG: Memory leak bugs due to returned new reference is not decreased on failure (static analyzer reports) about pyxattr HOT 5 CLOSED

Thanks for the report, much appreciated! I'll take a look in some while, right now away from proper machine to test.

Just for my curiosity, which analyser did you use? I'd like to integrate it in GitHub hooks or at least release process, if it's freely available.

from pyxattr.

It is an experimental analyzer developed on the top of Clang Static Analyzer. When the tool is publicly available, I will reply to this issue to tell you. Currently, I am busy writing the paper for this research.

from pyxattr.

Sounds good, thank you - and thanks for finding the bugs!

from pyxattr.

I've committed a fix for the first issue, which was very clear. For the second batch of issues, in the module initalisation, I'm not entirely sure what's the correct way of handling initialisation error - is deconstructing (via ref count decrease) the module the right thing? It seems so, but testing behaviour here is hard.

from pyxattr.

Ah, actually the tutorial shows exactly this. Then it's a clear and simple fix.

from pyxattr.