Comments (4)
Sorry, noticed an omission in the patch. Update enclosed.
from pyxattr.
Hi,
Refactoring the way error handling is dome is, I consider, more a matter of taste. I'd like to discuss that separately from fixing an actual bug. Can you rebase and split the patch into bug-fix and rework-error-handling?
from pyxattr.
Code quality has nothing to do with “taste” (whatever that might mean).
from pyxattr.
Error handling methods, as long as correct, are a matter of style, and not of "quality". I'll fix the PyList_Append error checking, if you do want to send a pull request for the refactoring, please do that separately.
from pyxattr.
Related Issues (20)
- compile fails on docker python:2.7 HOT 3
- Broken signature for 0.6.1 HOT 3
- support Path objects HOT 2
- pyxattr-0.5.x installation error HOT 2
- pyxattr fails to install on Windows 10 with cl : Command line error D8021 : invalid numeric argument '/Werror' HOT 4
- Better error message when trying to write EAs too big for file system HOT 4
- Build failure with 0.7.1 HOT 10
- Build Fail HOT 3
- 0.7.2: sphinx warnings HOT 8
- Consider adding incremental read and seek interface for large attribute values HOT 6
- Ability to read and write MacOS extended attributes on CIFS volume HOT 5
- pip install requires Python.h and gcc HOT 3
- Tests should only look at the user namespace HOT 10
- BUG: Memory leak bugs due to returned new reference is not decreased on failure (static analyzer reports) HOT 5
- Is there batch operations? HOT 1
- Fix example and maybe add typing HOT 2
- PyPy3.10: `xattr.getxattr()` does not accept `pathlib.Path` whereas it works on CPython HOT 12
- 0.8.1: documentation uses `recommonmark` which is now deprecated HOT 5
- library name collision: xattr and pyxattr = `import xattr`?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyxattr.