ist402-groupc / ip-project Goto Github PK

What Worked Well

1. Had all main parts just need to connect them all

What Needs Improvements

1. static getProperties requires name: { type: String }, page: { type: Number }
2. need a firstUpdated to update changes from data
3. Project doesn't provide assignment requirements

Next Steps

1. Review teammates work and create personal replica that fits your style (don't copy word for word)

What parts worked well or that you found the approach novel and should be incorporated into the final solution for your team?

• The option's updated(changedProperties) method seems to be written well and something we could use in the team's final solution

What parts could be improved upon?

• I think that more documenting on what the new methods are doing to retrieve data, for example more documentation for getNASAData() as well as on the render() method
• The nasa-image-search tag was also not used on the index.html file so nothing can load on the final webpage

What are the next recommended course of action?

• Compare this option's solution to the other options submitted and see if there are parts that we can incorporate into the team's final solution where we merge all three options

what worked well

From someone who doesn't know code at all, I really like the checkbox. The code on "checked" and "unchecked" worked quite interesting. Another great point is you didn't delete the "hello world" code, but the web page only showed the NASA program.

what part can be approved

Honestly, I can't point out any questions since I barely understand how your code worked! Great job!

What worked well

This option meets all the requirements of the assignment. The page number input works flawlessly and returns the correct data.

What can be improved

When both the search term and the page number values are changed, the API is called twice. Add a setTimeout so the element will wait for both new values before starting the fetch.

Next steps

I think this is the code we should base our final element on. I think we'll create a new repo to add this code to and paste in the additional options. We'll then clone this new repo onto our local machines to work on the lab going forward.

Returning the data into a ul element works great. You did an excellent job implementing the check box as well. I like how you implemented a while loop instead of the traditional for loop. I would suggest commenting on what works and what confused you for others to see what is going on.