Giter Club home page Giter Club logo

Comments (6)

ChristoSnake avatar ChristoSnake commented on May 26, 2024

This works as intended with the rpm install. I'm running Breeze Dark, and my v2 follows the OS nicely:

image

PS: I'm on SUSE Tumbleweed, so latest KDE Plasma, KDE Frameworks, QT, etc.

from teams-for-linux.

jijojosephk avatar jijojosephk commented on May 26, 2024

@ChristoSnake I think you're talking about the in-app setting provided by Microsoft. @andreaippo is behind teams-for-linux provided setting.

from teams-for-linux.

ChristoSnake avatar ChristoSnake commented on May 26, 2024

Interesting...

I am not using the "followSystemTheme" startup option and its default is false, which means by not specifying the option in my config.json my Teams should not follow the system theme. Yet it does exactly that!

I've just switched it using the GUI, and it works as dictated by the in app GUI:

  • Dark = dark
  • Light = light
  • Classic = seems the same as Light
  • High contrast = ouch, my poor eyes!
  • Follow system theme = immediately follows my (dark) system theme.

from teams-for-linux.

andreaippo avatar andreaippo commented on May 26, 2024

Thanks for the feedback everyone.

I had added that config option when I was still on v1, and hadn't thought that it might be useless (or actually, counterproductive) when moving to v2.

I'll try removing it and will report back.

EDIT:

well, this is weird:

image

EDIT2:

I did a Quit (clear storage) and it must have done something, because now that part of the settings UI works and is 1:1 with the web counterpart:

image

OS theme sync also works instantly if I leave it to Follow operating system theme, without the need for the "followSystemTheme": true feature flag

Imma remove it from my config.json, great! :)

from teams-for-linux.

andreaippo avatar andreaippo commented on May 26, 2024

Interesting...

I am not using the "followSystemTheme" startup option and its default is false, which means by not specifying the option in my config.json my Teams should not follow the system theme. Yet it does exactly that!

I've just switched it using the GUI, and it works as dictated by the in app GUI:

* Dark = dark

* Light = light

* Classic = seems the same as Light

* High contrast = ouch, my poor eyes!

* Follow system theme = immediately follows my (dark) system theme.

I guess that having that flag enabled was breaking things for me on v2. You had it working perfectly because you never set it, and teams v2 must have done something to finally play nice with Linux OS theming, so that the flag isn't needed anymore, and if you had it set (like me) it was actually breaking stuff.

Imma mention this in the configuration documentation.

from teams-for-linux.

andreaippo avatar andreaippo commented on May 26, 2024

Closing

from teams-for-linux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.