Giter Club home page Giter Club logo

Comments (5)

qianyizh avatar qianyizh commented on May 3, 2024

Very good.

I think we need a specialized data structure to be fed into GraphOptimization. As usual, it should be a IJsonConvertible object, and JSON is the default IO format of it. Similar to PinholeCameraTrajectory, it can read data from .log file too.

Actually, can we have a class like PoseGraph, it is defined as:

class PoseGraphNode : public IJsonConvertible
{
    public:
        Eigen::Matrix4d pose_;
};

class PoseGraphEdge : public IJsonConvertible
{
    public:
        int target_node_id_, source_node_id_;
        Eigen::Matrix4d trnasormation_;
        bool uncertain_;          // odometry edge always have uncertain = false, loop closure edges have them as true
};

class PoseGraph : public IJsonConvertible
{
    public:
        std::vector<PoseGraphNode> nodes_;
        std::vector<PoseGraphEdge> edges_;
};

from open3d.

syncle avatar syncle commented on May 3, 2024

Great. Let's say .pose for the extension of pose graph file.
I would need to add following files:

IO\FilePOSE.cpp
IO\ClassIO\PoseGraphIO.cpp&h
Core\Geometry\PoseGraph.cpp&h

from open3d.

syncle avatar syncle commented on May 3, 2024

I think we also need to have information field in PoseGraphEdge, how do you think?

from open3d.

qianyizh avatar qianyizh commented on May 3, 2024

No pose file. Just json. All these small meta data should be in json format.
And I do have a class check for each of the json file.

And yes, information matrix for each of the PoseGraphEdge.

Add the files you need.

from open3d.

syncle avatar syncle commented on May 3, 2024

Finished implementation. See #50

from open3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.