Giter Club home page Giter Club logo

listviewwithsublistview's People

Contributors

ishrakland avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

listviewwithsublistview's Issues

UWP Crash

When I try to click sun-item (not the first) I've got the exception {Windows.UI.Xaml.UnhandledExceptionEventArgs}

Does not show anything.

when use this line
Command="{Binding Source={x:Reference currentPage}, Path=BindingContext.RefreshItemsCommand}"

Does not show anything.

Suggestions

Hi Ishrak,
I see it's fairly old code, but I found it relly helpful.
Some suggestions:

  • you might want to remove unused using statements
  • in HotelsGroupViewModel, you have a property and a backing variable (items and Items).
    In the constructor (lines 30-31) you initialise them both, one would be enough.
  • HotelViewModel is derived from ObservableRangeCollection
    This is a big no-no in programming in general, however, in this case it is a key part of the implementation, you might want to add a comment about it: ListView requires a collection of a collection of items (List<List>). The only way you can achieve this if HotelViewModel IS a collection of RoomViewModels, it can't be implemented as a type with a property holding the collection of those.

Missing Referances

Description	Project	File	Line	Suppression State

Error CS0012 The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'

UWP Problem

Hi @ishrakland I can make it work on android but couldn't make it on UWP. I can see their replacement in UWP page but couldn't see the text. Why is that happening?

Git Ignore?

A Git ignore to all the the bin and obj files would have been great!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.