Giter Club home page Giter Club logo

tophu's People

Contributors

dependabot[bot] avatar gmgunter avatar pre-commit-ci[bot] avatar scottstanie avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

tophu's Issues

scipy `DeprecationWarning` in`scipy.signal.remez`: use keyword arguments instead of positional

from https://github.com/isce-framework/dolphin/actions/runs/7615612433/job/20740529928?pr=197

tests/test_unwrap.py:161: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/dolphin/unwrap/_unwrap.py:228: in unwrap
    return multiscale_unwrap(
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/dolphin/unwrap/_tophu.py:165: in multiscale_unwrap
    tophu.multiscale_unwrap(
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/tophu/_multiscale.py:647: in multiscale_unwrap
    coarse_unwrapped, coarse_conncomp = coarse_unwrap(
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/tophu/_multiscale.py:339: in coarse_unwrap
    igram_lores = lowpass_filter_and_multilook(
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/tophu/_multiscale.py:108: in lowpass_filter_and_multilook
    coeffs2d = np.outer(*coeffs1d)
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/tophu/_multiscale.py:97: in get_filter_coeffs
    return bandpass_equiripple_filter(
../../../micromamba/envs/dolphin-env/lib/python3.11/site-packages/tophu/_filter.py:173: in bandpass_equiripple_filter
    coeffs = scipy.signal.remez(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

args = (39, [0.0, 0.13333333333333333, 0.2, 0.5], [1.0, 0.0], [0.01, 0.0011506300634948063])
kwargs = {'fs': 1.0, 'grid_density': 16, 'maxiter': 25}, extra_args = 1
args_msg = 'weight=[0.01, 0.0011506300634948063]'

    @functools.wraps(f)
    def inner_f(*args, **kwargs):
        extra_args = len(args) - len(all_args)
        if extra_args <= 0:
            return f(*args, **kwargs)
    
        # extra_args > 0
        args_msg = [
            f"{name}={arg}"
            for name, arg in zip(kwonly_args[:extra_args], args[-extra_args:])
        ]
        args_msg = ", ".join(args_msg)
>       warnings.warn(
            (
                f"You are passing {args_msg} as a positional argument. "
                "Please change your invocation to use keyword arguments. "
                f"From SciPy {version}, passing these as positional "
                "arguments will result in an error."
            ),
            DeprecationWarning,
            stacklevel=2,
        )
E       DeprecationWarning: You are passing weight=[0.01, 0.0011506300634948063] as a positional argument. Please change your invocation to use keyword arguments. From SciPy 1.14, passing these as positional arguments will result in an error.

[Feature request]: Timing info per tile, and other debug metrics

I've been thinking about what possible metrics would be easy to track for benchmarking/debugging unwrapping.

  • One basic nice-to-have: printing the time taken per tile along with the tile position. This could be useful to plot after to see if one single area took up all the time, or if it was the coarse unwrapping which took the longest.
  • Even though some unwrappers make it difficult to track stuff about the internals while they're running (e.g. snaphu), perhaps we could set up something to watch the processes as they run. My first attempt in dolphin is the CPURecorder class that I started to get basic benchmark info for different workflow stages. The code is very open to changes/reworks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.