Giter Club home page Giter Club logo

node-lru-cache's Introduction

lru-cache

A cache object that deletes the least-recently-used items.

Specify a max number of the most recently used items that you want to keep, and this cache will keep that many of the most recently accessed items.

This is not primarily a TTL cache, and does not make strong TTL guarantees. There is no preemptive pruning of expired items by default, but you may set a TTL on the cache or on a single set. If you do so, it will treat expired items as missing, and delete them when fetched. If you are more interested in TTL caching than LRU caching, check out @isaacs/ttlcache.

As of version 7, this is one of the most performant LRU implementations available in JavaScript, and supports a wide diversity of use cases. However, note that using some of the features will necessarily impact performance, by causing the cache to have to do more work. See the "Performance" section below.

Installation

npm install lru-cache --save

Usage

// hybrid module, either works
import { LRUCache } from 'lru-cache'
// or:
const { LRUCache } = require('lru-cache')
// or in minified form for web browsers:
import { LRUCache } from 'http://unpkg.com/lru-cache@9/dist/mjs/index.min.mjs'

// At least one of 'max', 'ttl', or 'maxSize' is required, to prevent
// unsafe unbounded storage.
//
// In most cases, it's best to specify a max for performance, so all
// the required memory allocation is done up-front.
//
// All the other options are optional, see the sections below for
// documentation on what each one does.  Most of them can be
// overridden for specific items in get()/set()
const options = {
  max: 500,

  // for use with tracking overall storage size
  maxSize: 5000,
  sizeCalculation: (value, key) => {
    return 1
  },

  // for use when you need to clean up something when objects
  // are evicted from the cache
  dispose: (value, key) => {
    freeFromMemoryOrWhatever(value)
  },

  // how long to live in ms
  ttl: 1000 * 60 * 5,

  // return stale items before removing from cache?
  allowStale: false,

  updateAgeOnGet: false,
  updateAgeOnHas: false,

  // async method to use for cache.fetch(), for
  // stale-while-revalidate type of behavior
  fetchMethod: async (
    key,
    staleValue,
    { options, signal, context }
  ) => {},
}

const cache = new LRUCache(options)

cache.set('key', 'value')
cache.get('key') // "value"

// non-string keys ARE fully supported
// but note that it must be THE SAME object, not
// just a JSON-equivalent object.
var someObject = { a: 1 }
cache.set(someObject, 'a value')
// Object keys are not toString()-ed
cache.set('[object Object]', 'a different value')
assert.equal(cache.get(someObject), 'a value')
// A similar object with same keys/values won't work,
// because it's a different object identity
assert.equal(cache.get({ a: 1 }), undefined)

cache.clear() // empty the cache

If you put more stuff in the cache, then less recently used items will fall out. That's what an LRU cache is.

For full description of the API and all options, please see the LRUCache typedocs

Storage Bounds Safety

This implementation aims to be as flexible as possible, within the limits of safe memory consumption and optimal performance.

At initial object creation, storage is allocated for max items. If max is set to zero, then some performance is lost, and item count is unbounded. Either maxSize or ttl must be set if max is not specified.

If maxSize is set, then this creates a safe limit on the maximum storage consumed, but without the performance benefits of pre-allocation. When maxSize is set, every item must provide a size, either via the sizeCalculation method provided to the constructor, or via a size or sizeCalculation option provided to cache.set(). The size of every item must be a positive integer.

If neither max nor maxSize are set, then ttl tracking must be enabled. Note that, even when tracking item ttl, items are not preemptively deleted when they become stale, unless ttlAutopurge is enabled. Instead, they are only purged the next time the key is requested. Thus, if ttlAutopurge, max, and maxSize are all not set, then the cache will potentially grow unbounded.

In this case, a warning is printed to standard error. Future versions may require the use of ttlAutopurge if max and maxSize are not specified.

If you truly wish to use a cache that is bound only by TTL expiration, consider using a Map object, and calling setTimeout to delete entries when they expire. It will perform much better than an LRU cache.

Here is an implementation you may use, under the same license as this package:

// a storage-unbounded ttl cache that is not an lru-cache
const cache = {
  data: new Map(),
  timers: new Map(),
  set: (k, v, ttl) => {
    if (cache.timers.has(k)) {
      clearTimeout(cache.timers.get(k))
    }
    cache.timers.set(
      k,
      setTimeout(() => cache.delete(k), ttl)
    )
    cache.data.set(k, v)
  },
  get: k => cache.data.get(k),
  has: k => cache.data.has(k),
  delete: k => {
    if (cache.timers.has(k)) {
      clearTimeout(cache.timers.get(k))
    }
    cache.timers.delete(k)
    return cache.data.delete(k)
  },
  clear: () => {
    cache.data.clear()
    for (const v of cache.timers.values()) {
      clearTimeout(v)
    }
    cache.timers.clear()
  },
}

If that isn't to your liking, check out @isaacs/ttlcache.

Storing Undefined Values

This cache never stores undefined values, as undefined is used internally in a few places to indicate that a key is not in the cache.

You may call cache.set(key, undefined), but this is just an alias for cache.delete(key). Note that this has the effect that cache.has(key) will return false after setting it to undefined.

cache.set(myKey, undefined)
cache.has(myKey) // false!

If you need to track undefined values, and still note that the key is in the cache, an easy workaround is to use a sigil object of your own.

import { LRUCache } from 'lru-cache'
const undefinedValue = Symbol('undefined')
const cache = new LRUCache(...)
const mySet = (key, value) =>
  cache.set(key, value === undefined ? undefinedValue : value)
const myGet = (key, value) => {
  const v = cache.get(key)
  return v === undefinedValue ? undefined : v
}

Performance

As of January 2022, version 7 of this library is one of the most performant LRU cache implementations in JavaScript.

Benchmarks can be extremely difficult to get right. In particular, the performance of set/get/delete operations on objects will vary wildly depending on the type of key used. V8 is highly optimized for objects with keys that are short strings, especially integer numeric strings. Thus any benchmark which tests solely using numbers as keys will tend to find that an object-based approach performs the best.

Note that coercing anything to strings to use as object keys is unsafe, unless you can be 100% certain that no other type of value will be used. For example:

const myCache = {}
const set = (k, v) => (myCache[k] = v)
const get = k => myCache[k]

set({}, 'please hang onto this for me')
set('[object Object]', 'oopsie')

Also beware of "Just So" stories regarding performance. Garbage collection of large (especially: deep) object graphs can be incredibly costly, with several "tipping points" where it increases exponentially. As a result, putting that off until later can make it much worse, and less predictable. If a library performs well, but only in a scenario where the object graph is kept shallow, then that won't help you if you are using large objects as keys.

In general, when attempting to use a library to improve performance (such as a cache like this one), it's best to choose an option that will perform well in the sorts of scenarios where you'll actually use it.

This library is optimized for repeated gets and minimizing eviction time, since that is the expected need of a LRU. Set operations are somewhat slower on average than a few other options, in part because of that optimization. It is assumed that you'll be caching some costly operation, ideally as rarely as possible, so optimizing set over get would be unwise.

If performance matters to you:

  1. If it's at all possible to use small integer values as keys, and you can guarantee that no other types of values will be used as keys, then do that, and use a cache such as lru-fast, or mnemonist's LRUCache which uses an Object as its data store.

  2. Failing that, if at all possible, use short non-numeric strings (ie, less than 256 characters) as your keys, and use mnemonist's LRUCache.

  3. If the types of your keys will be anything else, especially long strings, strings that look like floats, objects, or some mix of types, or if you aren't sure, then this library will work well for you.

    If you do not need the features that this library provides (like asynchronous fetching, a variety of TTL staleness options, and so on), then mnemonist's LRUMap is a very good option, and just slightly faster than this module (since it does considerably less).

  4. Do not use a dispose function, size tracking, or especially ttl behavior, unless absolutely needed. These features are convenient, and necessary in some use cases, and every attempt has been made to make the performance impact minimal, but it isn't nothing.

Breaking Changes in Version 7

This library changed to a different algorithm and internal data structure in version 7, yielding significantly better performance, albeit with some subtle changes as a result.

If you were relying on the internals of LRUCache in version 6 or before, it probably will not work in version 7 and above.

Breaking Changes in Version 8

  • The fetchContext option was renamed to context, and may no longer be set on the cache instance itself.
  • Rewritten in TypeScript, so pretty much all the types moved around a lot.
  • The AbortController/AbortSignal polyfill was removed. For this reason, Node version 16.14.0 or higher is now required.
  • Internal properties were moved to actual private class properties.
  • Keys and values must not be null or undefined.
  • Minified export available at 'lru-cache/min', for both CJS and MJS builds.

Breaking Changes in Version 9

  • Named export only, no default export.
  • AbortController polyfill returned, albeit with a warning when used.

Breaking Changes in Version 10

  • cache.fetch() return type is now Promise<V | undefined> instead of Promise<V | void>. This is an irrelevant change practically speaking, but can require changes for TypeScript users.

For more info, see the change log.

node-lru-cache's People

Contributors

aheckmann avatar alexgleason avatar amilajack avatar cblage avatar chriscinelli avatar eugene1g avatar gkoberger avatar indutny avatar isaacs avatar jimbly avatar jldailey avatar jounqin avatar julianlam avatar kapouer avatar kentcdodds avatar kevinohara80 avatar kikobeats avatar mbroadst avatar mcavage avatar mikeybyker avatar nil1511 avatar nornagon avatar polotek avatar push1st1k avatar sebastinez avatar tedpennings avatar th507 avatar theganyo avatar tootallnate avatar trentm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

node-lru-cache's Issues

Memory leaks

I don't have anything other than anecdotal evidence to support this right now, but at high volume lru-cache leaks memory. It's not noticeable on most projects, but on my high volume sites I find that the servers are bleeding memory and require restarts every few hours. This is consistent with any caching modules that uses lru-cache as the underlying mechanism (mongoose-cache, async-cache, etc).

I'm still looking into this and trying to do memory profiling to determine what the bug is. I assume it has something to do with storing complex objects. But I just wanted to give a heads up in case anyone else plans on using this at large scale.

Breaking change in 2.7.1

I am getting the following error on 2.7.1 when calling has(undefined);

.../node_modules/lru-cache/lib/lru-cache.js:18
    throw new TypeError("key must be a string or number. " + typeof key)

While it makes sense to throw now, it did not throw in 2.7.0.
Should this be a major release instead?

More detailed log

jacobp:/tmp
$ npm i [email protected]
[email protected] node_modules/lru-cache
jacobp:/tmp
$ node
> var cache = require('lru-cache')(10)
undefined
> cache.has(undefined)
false
> 
(^C again to quit)
> 
jacobp:/tmp
$ npm i [email protected]
[email protected] node_modules/lru-cache
jacobp:/tmp
$ node
> var cache = require('lru-cache')(10)
undefined
> cache.has(undefined)
TypeError: key must be a string or number. undefined
    at typeCheckKey (/private/tmp/node_modules/lru-cache/lib/lru-cache.js:18:11)
    at LRUCache.has (/private/tmp/node_modules/lru-cache/lib/lru-cache.js:217:3)
    at repl:1:7
    at REPLServer.defaultEval (repl.js:164:27)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.<anonymous> (repl.js:393:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)
    at REPLServer.Interface._onLine (readline.js:210:10)
> 

package.json must be actual JSON, not just JavaScript

npm ERR! Darwin 13.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.10.32
npm ERR! npm v2.1.4
npm ERR! file /Users/democle/.npm/lru-cache/2.5.0/package/package.json
npm ERR! code EJSONPARSE

npm ERR! Failed to parse json
npm ERR! Unexpected end of input
npm ERR! File: /Users/democle/.npm/lru-cache/2.5.0/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

proactive pruning

The documentation indicates that given a maxAge "Items are not pro-actively pruned out as they age". Are there any plans to provide such behavior? Has anyone been able to implement this easily with the existing implementation?

iterable prune

Currently if one have a very large cache, prune can take a very long time blocking other tasks. It would be nice to have a way to prune parts of the cache, do other work and continue pruning. If lru-cache had some form of iterator in its public API this could be easily achieve.

Using maxAge does not check for item's age. It checks for last access time.

I'm not sure if this is intended behaviour. Up to version 2.5.0 setting maxAge caused removal of item from cache after maxAge milliseconds. At the moment the check is not made against total age of item but against its last access date.

This means that cached item can be stored indefinately if they are accessed often. Item will be removed only if it's accessed after time greater than maxAge.

Is this intended behaviour? If it is it should be made clear in the documentation.

getOrCreate() method

This seems like a very common use case, and in fact it's the preferred way you use a cache in Rails. Is there any reason it's not implemented?

cache.getOrCreate(key, () => { expensive computation })

Where:

LRU.prototype.fetch = function (key, fn) {
  if (this.has(key)) return this.get(key)
  var result = fn()
  this.set(key, result)
  return result
}

Add an environment configuration to disable cache

The logic is similar to the reason https://github.com/gajus/bluefeather#map adds BLUEFEATHER_MAX_CONCURRENCY configuration:

This method is identical to Bluebird#map except that the concurrency setting can be overridden using BLUEFEATHER_MAX_CONCURRENCY environment variable. Controlling max concurrency using environment variables enables debugging of the codebase without refactoring the code.

Sometimes you want to quickly check if cache is the causing the underlying issue. Having a way to disable LRU cache with environment variable would be useful.

Setting to a negative value disables the cache

It would be nice if I could pass a negative value to the cache to disable it.

This would come handy in integration-tests of my app.

I would implement it and make a pull request, just asking before if that is something that you would merge.

Iteration API

It would be nice to be able to iterate over at least all the keys in the cache

covert `.get()`

This is a strange use case but I need a .get() that doesn't effect the LRU state.

Basically, I need to check a property in the object against the request to know if it's a valid hit to the LRU.

test failure no-symbol.js

On node 6.9.1, running tap 8

TypeError: Symbol is not a function
    at net.js:122:20
    at NativeModule.compile (bootstrap_node.js:497:7)
    at NativeModule.require (bootstrap_node.js:438:18)
    at internal/child_process.js:6:13
    at NativeModule.compile (bootstrap_node.js:497:7)
    at NativeModule.require (bootstrap_node.js:438:18)
    at child_process.js:12:23
    at NativeModule.compile (bootstrap_node.js:497:7)
    at Function.NativeModule.require (bootstrap_node.js:438:18)
    at Function.Module._load (module.js:426:25)

Performance tests

I'm hesitant to use this module when there are no performance tests. How well does this module compare to other lru implementations? Another one I am looking at is js-lru.

itemCount is not reduced when trim() is executed

When trim() is executed to remove the items when length > max then itemCount is not reduced. Because of that cache.keys().length becomes more than max.

For example
var LRU = require("lru-cache");
var options = { max: 5 };
var cache = LRU(options);
cache.set("key1", "value1");
cache.set("key2", "value2");
cache.set("key3", "value3");
cache.set("key4", "value4");
cache.set("key5", "value5");
cache.set("key6", "value6");

cache.keys() now returns [ 'key6',
'key5',
'key4',
'key3',
'key2',
] and cache.keys().length returns 6

when you do add one more value to the cache like cache.set("key7", "value7"); then
cache.keys() returns
[ 'key7',
'key6',
'key5',
'key4',
'key3',
,
] and cache.keys().length returns 7.

I wonder whether this will lead to a memory leak when we add more items to the cache even if there is "max" property is set.

length (value, key)

My cache stores path->path. As such, the keys kind of take up as much space as the values. I could do length(v) => v.length * 2, but length(v,k) => v.length + k.length would be ideal.

reverse forEach

would be great if it would be possible to iterate over lru entries in ascending order of recent-ness

For each doesn't remove all stale entries

As for each has two boundaries namely: k which decrements and i which increments, it will not delete all stale children inside the cache.

Example:

Cache has 3 entries, all stale, the least recently used one won't be removed from the cache.

What is the mean about option: max? what is the unit? byte? or kb?

I try below code:

var options = { max: 100,
    length: function (n, key) {console.log(`-${n} ${key}-`); return n + key.length;},
    dispose: function (key, n) { console.log(`delete ${key}`);},
    maxAge: 1000 * 60 * 60
    
}
var cache = LRU(options);
const repl = require('repl');

const replServer = repl.start({prompt: '> '});
for(var i = 0 ; i < 100000; i++){
    cache.set('k' + i, 'v' + i);
}

I had set max = 100, and length function And put 100000 item into cache. But it i can get every item, Why? the max does not work?

maxAge not working in Node 6 Express app

Hi,

today i noticed in my Node (v6.0.0) Express app that maxAge is not working properly, it expires much earlier than it should:

const router = require('express').Router();
const LRU = require('lru-cache');
const activeTokensCache = new LRU({
  max: 1000,
  maxAge: 1000 * 60 * 60 * 24 * 7  // 7 days
});

router.get('/test-cache/:addToCache?', (req, res) => {
  if (req.params.addToCache) {
    const maxAge = 120 * 60 * 1000 // 120 min
    activeTokensCache.set('test', 'value', maxAge);
    return res.send('Added to cache');
  } else {
    const token = activeTokensCache.get('test');
    const response = token === undefined ? 'UNDEFINED' : token
    res.send(response);
  }
});

According to code, token should expire after 120 min. In my case, it expires after 2 min.
Here's how i tested it:

I call url to add it to cache

example.com/test-cache/1
Added to cache

After one min, item is still there:

example.com/test-cache
value

2 min after a previous call it disappears:

example.com/test-cache
UNDEFINED

When i omit maxAge on set() call, and set 120 min on global config, it expires after 5 min, which is really strange. Here's the code to test that:

const router = require('express').Router();
const LRU = require('lru-cache');
const activeTokensCache = new LRU({
  max: 1000,
  maxAge: 120 * 60 * 1000 // 120 min
});

router.get('/test-cache/:addToCache?', (req, res) => {
  if (req.params.addToCache) {
    activeTokensCache.set('test', 'value');
    return res.send('Added to cache');
  } else {
    const token = activeTokensCache.get('test');
    const response = token === undefined ? 'UNDEFINED' : token
    res.send(response);
  }
});

I don't have idea what could be a problem.

Also, some additional info: I'm running Node in Docker container (https://hub.docker.com/r/risingstack/alpine, tag 3.3-v6.0.0-3.5.0) with Docker compose. Server timezone is UTC, but that shouldn't be an issue since everything is done on the server.

Do you know what could be an issue?

Thanks.

Clarification of length usage

Could someone clarify

  • how is the length in options being used by this library and
  • a few examples on how to set it correctly

For example, in the docs (under usage) I see
length: function (n, key) { return n * 2 + key.length }

Does this mean the key length should be added every time?
What if I am storing array of complex JS objects using a string key?
Should I calculate length as array length plus key length? Or do I need to consider the object size as well?

A few examples would be really helpful.

Thanks
Z

Performance and Memory Issues (Worse now with 3.2.0)

Hi guys,

We've been using lru-cache in our product for a couple weeks now in tonicdev and have noticed some performance and memory issues. We use it all the time and love the work you guys are doing. For some context, we set the size of the cache to be 64 * 1000 * 1000 (~64MB). Our cache is storing string for keys and values (path1 -> path2). So the length calculation is just key.length + value.length (this isn't super accurate since its not 1 byte per char, but its kind of on inconsequential for what we're experiencing). So basically the cache can have as many as like 800,000 items.

Basically, we are seeing an explosion of memory use, and separately severe performance degradation once we hit the size limitation of the cache (the work of a cache miss far outweighs the benefits for cache hits). We are currently running 2.7.0, but this has gotten (significantly) worse in 3.2.0. @pouwerkerk has collected the results of a reduction we wrote (which measures worst case performance: constantly missing the cache and thus always resulting in one removal):

screen shot 2015-12-14 at 3 25 56 pm

Here you can see that once we hit the magic cutoff where we have reached the limitation of the cache size, performance degrades to up to 10s of milliseconds per retrieval (whereas before that point it had sub-millisecond performance).

Now this is the performance of 3.2.0:

screen shot 2015-12-14 at 3 31 26 pm

We believe the culprit is the new reverseKeys function which seems to create an array of the entire size of the cache on every call.

Either way, we have taken the time to write an alternate implementation that uses a doubly linked list (we based it on ideas here: http://www.geeksforgeeks.org/implement-lru-cache/ ) and thus actually slightly improves performance once the max cache size is hit (since no more new objects ever need to be created - graph below, 3.2.0 left out):

screen shot 2015-12-14 at 3 33 31 pm

We've put up the code here: https://github.com/playgroundtheory/fast-lru . It contains also the test cases in the test/ directory. You can npm install each one and just node main.js. We've also put our data here: https://docs.google.com/spreadsheets/d/1fzdFYhtd2_-BLimCPGAW_qJhKsDwigKBvWxx_n_gkDs/edit#gid=0

We wanted to run this by you guys because we know lots of packages depend on this, but we only wrote our lru to serve our needs for now (didn't both with most the methods, or maxAge, etc). All those are certainly doable and should not affect anything, but just will take a while to complete. We were hoping to get your feedback whether you thought a merge would be worthwhile, and if it is we could start moving in that direction but if not we can just keep ours up on the separate repo. Also, we only just wrote this and will be spending the rest of the day integrating it into our system, so of course would also appreciate making sure we didn't write anything incorrectly that could explain the discrepancy.

Thanks!

Francisco

No changelog

Please add changelog at least for major releases.

Simple usage leaks memory

The below code leaks memory for me at a steady rate of approximately 100KB per second.

var lru = require('lru-cache');

var leaks = lru(1);
var index = 0;

setInterval(function() {
    index += 1;
    if (index === 10) {
        index = 0;
    }
    leaks.set(('key' + index), 'item');
}, 1);

There must be something I am doing wrong here, though I can't seem to figure out what that is. Any input would be appreciated!

calling set() inside of dispose() creates an infinite loop?

Hey there,

this may just be a case of me implementing this module incorrectly, but I'm running into an issue where I need to call cache.set() inside of the dispose handler, which seems to result in an endless set -> dispose -> set -> dispose... loop.

use case: I am caching a single API response from a server ( cache length === 1 ). When a user hits the route, they are served the cache.

If the cache is older than 1 hour, a new request should be made and stored into the cache, prior to serving the new value to the user. If this API request fails, the prior "stale" cache should be re-set for another hour, so that there is no data downtime.

Here is my code...

const cache = lru({
  max: 1,
  maxAge: ONE_HOUR,
  stale: true,
  dispose: recache,
});

function recache(key = null, value = null) {
  let prevData;
  if (key && value) {
    prevData = value;
  } else if (cache.peek('data').length) {
    prevData = cache.peek('data');
  }
  return apiRequest(endpoint, { timeout: 5000 })
    .then(({ data }) => {
      // if we got back data, set them.
      if (data && data.length) {
        return Promise.resolve(cache.set('data', data));
      }
      // otherwise, return error
      return Promise.reject(reqError(500, 'No data returned from the API.'));
    })
    .catch((err) => {
      // something went wrong, re-set the old cache values.
      return Promise.resolve(cache.set('data', prevData));
    });
}

function checkCache() {
  if (cache.has('data')) {
    return Promise.resolve();
  }
  return recache();
}

router.get('/', (req, res) => {
  checkCache()
    .then(() => res.json(cache.peek('data')))
    .catch((err) => {
      res.status(500).json({
        error: err.message,
      });
    });
});

again, I may just be implementing incorrectly, but I would appreciate any advice or input. :) It's not entirely clear to me how to use this module for one data set, that I don't want to "refresh" when it's accessed -- rather I want it to be reliably re-cached each hour.

Object and arrays as keys not working

Hi, you've made a great, very useful library!
But it seems that .get() doesn't work with keys that are objects or arrays. I have v4.0.0 of the library and v4.3.1 of node:

$ node
> var lru = require('lru-cache');
undefined
> var cache = lru();
undefined
> cache
LRUCache {}
> cache.set('1', 1);
true
> cache.get('1'); // this is OK
1
> cache.set(2, 3);
true
> cache.get(2) // again OK
3
> cache.set({ a: 1, b : 1 }, 4);
true
> cache.get({ a: 1, b : 1 }) // oops
undefined
> cache.set([1,2,3,4], 5);
true
> cache.get([1,2,3,4]) // no no
undefined
> cache.keys() // however it seems that all keys were saved
[ [ 1, 2, 3, 4 ], { a: 1, b: 1 }, 2, '1' ]
> cache.values() // and all values too
[ 5, 4, 3, 1 ]

Please advise if I'm doing something wrong. Thanks!

Using objects as cache keys

As I'm sure you know, using objects as cache keys causes a 100% collision rate for all object keys. All object keys are stored with a key [object Object] and therefore resolve to the same value.

Would you be open to a PR to allow users to specify objects as cache keys?

We could use an array as the underlying store, for the object section or for the whole cache (slower). Here's the basic implementation I'd add:

const cacheArray = []

function get(key) {
  const hit = cacheArray.find(elem => elem.key === key)
  if (hit) {
    // LRU staleness and touch logic here
    return hit.value
  }
  return false
}

function set(key, value) {
  cacheArray.push({key, value})
  // LRU eviction logic here
}

If you don't want to do this, no worries, but I'd love to send README PR to mention that cache keys should not be an object (or array).

IE compatibility

I ran into an IE bug when using LRUCache with numeric keys.

The bug is documented here. Here's the important part:

All IEs that support Object.create seem to be affected. If there are only numeric properties in the created object and no new keyword has been used to initialize the same, hasOwnProperty check as well as isPropertyEnumerable will miserably fail.

The bug affects LRUCache's hOP check during LRUCache.prototype.set. In IE, if I only have numeric keys and try to set with an existing key, set will think that the key doesn't yet exist and create a new entry instead of overwriting the existing entry.

There are a couple ways we can get around this

1 Modify hOP to use the in operator. This is safe because hOP is only used on this._cache and this._cache has no prototype.

function hOP (obj, key) {
  return key in obj;
}

2 Modify the creation of this._cache. If we set a configurable numeric property and then delete it, the object will then behave correctly.

function makeObject() {
  var obj = Object.create(null);
  delete Object.defineProperty(obj, 0, {configurable: true})[0];
  return obj;
}

@isaacs do you have any preference on which fix to apply? 2 seems like the safer route, since hOP's behavior will be unchanged. There won't be much of a performance hit since objects are only created in LRUCache.prototype.reset. I'm happy to open a PR.

npm test failing locally

> tap test --branches=100 --functions=100 --lines=100 --statements=100

test/basic.js ..................................... 521/521
test/foreach.js ..................................... 72/72
test/inspect.js ..................................... 28/28
test/no-symbol.js ................................. 521/521
test/serialize.js ................................... 56/56
total ........................................... 1198/1198

  1198 passing (5s)

  ok
ERROR: No coverage files found.
---------------|----------|----------|----------|----------|----------------|
File           |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
---------------|----------|----------|----------|----------|----------------|
 lib/          |      100 |      100 |      100 |      100 |                |
  lru-cache.js |      100 |      100 |      100 |      100 |                |
---------------|----------|----------|----------|----------|----------------|
All files      |      100 |      100 |      100 |      100 |                |
---------------|----------|----------|----------|----------|----------------|

npm ERR! Test failed.  See above for more details.

Coverage files are being generated in .nyc_output, but maybe istanbul just doesn't know where to look for them?

2.7.2 breaks backwards compatibility

With [email protected] this code works. It stores an object in the cache using a mongo ObjectID as key:

var LRU = require('lru-cache');
var ObjectID = require('mongodb').ObjectID;

var cache = LRU();
var key = new ObjectID();
cache.set(key, {}) // works fine

Something changed in [email protected] that broke backwards compatibility, as now the call to cache.set complains about the key not being a string:

TypeError: key must be a string or number. object
    at typeCheckKey (..node_modules/lru-cache/lib/lru-cache.js:18:11)
    at LRUCache.set (...node_modules/lru-cache/lib/lru-cache.js:171:3)
    at repl:1:7
    ...

This new behaviour sounds reasonable to me, but I think it should be fixed in a major release (not in 2.7.x), as it breaks backwards compatibility. What do you think?

I'm using node 4.2.1 if that helps.

MRU & Max Safe Integer

I can see a potential flaw in your _mru counter. We're using lru-cache as our services receive several thousand requests a second. If there is never any reduction in the MRU counter, eventually it'll overflow the Number.MAX_SAFE_INTEGER and things will begin to go pair shaped.

To create ourselves a safety net, we have implemented an interval that resets the cache every hour. Would you consider a configurable option to do something like this in your module? Or maybe just something that resets when it sees the MRU is at the MAX_SAFE_INTEGER?

The method get doesn't update the "recently used"-ness of the key as the doc says

The documentation says (under the get and set methods):

Both of these will update the "recently used"-ness of the key. They do what you think.

But the get method doesn't update the element age. I checked the source code, and the now attribute of the hit isn't updated. I made this simple test code to check and confirm this:

var LRU = require("lru-cache");

var cache = LRU( {
    max: 100,
    maxAge: 10000
} );

cache.set( "1234", 1 );

setTimeout( function() {
    cache.set( "1234", 2 );
    console.log( "testing after 5s: " + cache.get( "1234" ) );
}, 5000 );

setTimeout( function() {
    console.log( "testing after 9s: " + cache.get( "1234" ) );
}, 9000 );

setTimeout( function() {
    console.log( "testing after 11s: " + cache.get( "1234" ) );
}, 11000 );

setTimeout( function() {
    console.log( "testing after 16s: " + cache.get( "1234" ) );
}, 16000 );

If the get method updates the age of the key, shouldn't the last timeout (16s) print the value 2 again instead of undefined?

`load()` methods

We have .dump() and .dumpLRU, would be nice if you could do something like.

var lru = require('lru-cache').load(JSON.parse(fs.readFileSync('./dump.json').toString()))

Maybe a matching one for loadLRU.

Patch welcome: Use -1 as maxAge to always automatically expire

In isaacs/async-cache#6, @kadishmal uses 0 as the maxAge to automatically expire entries.

However, a maxAge of 0 is used as just "no maximum age" (so items never expire).

Changing maxAge of 0 to mean "automatically expire" is a huge breaking change, in a really subtle way that's bound to bite a lot of people unnecessarily. So, I'd rather not do that.

However, this module could accept -1 as a maxAge value and use that to mean "automatically expire", which at least provides a workaround.

Patch welcome for this. Please include docs and test.

option to set maxAge on a cache key

Right now the maxAge is setup on the options of the lru-cache instance.
Would it be useful to specify the maxAge when doing a set? ie. LRU.set('key', 'value', 3000)

Performance issue on Node 4x

On NodeJS 4x, when configuring lru-cache with a max setting above 8192, behavior gradually becomes very slow. The longer it runs, the slower it gets.

Starting with a max of 8193, the program abruptly slows down soon after the maximum number of elements have been reached. Soon it will take upwards of 30 seconds to process 5000 set/removes. As the max setting is raised higher and higher, performance still slows down but the program needs to run longer and longer to reach the same level of performance degradation.

I haven't been able to reproduce this behavior on any of these earlier releases of Node/iojs:

  • iojs-3.3.1
  • iojs-2.5.0
  • iojs-1.8.4
  • node-0.12.7
  • node-0.11.16
  • node-0.10.40

This is probably a V8 bug but worth making this known here.

Note: I forked this module and changed it to use Map instead of Object.create(null) and the issue is resolved. Not sure if switching to a Map is the right choice for this module due to backward compatibility (and browser support) but it looks like it could be a good solution going forward. I haven't pushed my code public yet but let me know if you'd be interested in going that direction.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.