Giter Club home page Giter Club logo

download-ipfs-distribution-action's Introduction

IPFS is an open system to manage data without a central server

Check out our website at ipfs.tech.

For papers on IPFS, please see the Academic Papers section of the IPFS Docs.

License

MIT.

download-ipfs-distribution-action's People

Contributors

dependabot[bot] avatar galargh avatar ipfs-mgmt-read-write[bot] avatar lidel avatar web-flow avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

Forkers

seanpm2001

download-ipfs-distribution-action's Issues

Add caching/fallback when unable to find the latest version

Problem

Turns out #9 + #10 did not solve the problem for a scenario where user omits the version and action needs to fetch addtional metadata to find out what is the latest one:

use cached dist if fetching new  fails-2022-02-11_21-17
https://github.com/ipfs/distributions/runs/5136166478?check_suite_focus=true#step:3:92

This causes our nightlies to fail ipfs/distributions#631

Solution

I believe it is better to default to have some fallback or cached version than to fail CI when dist.ipfs.io is unstable.

Places which we need to harden:

Thoughts @aschmahmann @galargh ?

retry on curl error

This action uses curl multiple times. If any of the HTTP requests fails, the entire CI job will fail.
Unfortunately, out HTTP gateways are sometimes overloaded, and timeouts are more common that one would expect.

I believe we could improve devexp by retrying a few times before returning an error that would fail the CI.

Perhaps curl --retry 5 ? Afaik it is pretty good (it has exponential backoff enabled by default). We could also use --retry-all-errors if it is supported by the version of curl present on github.

Caveat: I don't think retrying plays well with redirected output โ€“ we may need to save output to a file instead, using explicit -o filename so it can be resumed correctly (see this warning)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.