Giter Club home page Giter Club logo

Comments (10)

mgruhler avatar mgruhler commented on August 15, 2024

@ipa-fxm Thanks, we need to change this at some time... The result currently is compatible with the groovy one. But we should start to get rid of those warnings...

from cob_robots.

fmessmer avatar fmessmer commented on August 15, 2024

@ipa-mig:
ping

from cob_robots.

fmessmer avatar fmessmer commented on August 15, 2024

@ipa-srd-fg
While you investigate the costmap node and configuration for multi-robot support, could you take care of this at the same time please? Don't know whether this actually still exists...@ipa-mig?

from cob_robots.

ipa-srd-fg avatar ipa-srd-fg commented on August 15, 2024

Sure.
Furthermore, I still get the deprecation warnings from above.

from cob_robots.

mgruhler avatar mgruhler commented on August 15, 2024

@ipa-srd-fg perfect, thanks.

I actually already tried to start it last week, but didn't get around to make progress...
Best drop by my office tomorrow so that we can discuss how to proceed best.

What needs to be done to fix this issue:

  • Set up new parameter style for one robot (best take a r@w, you can find a working example in ipa_navigation/ipa_navigation_config)
  • test in simulation
  • test on hardware
  • port to all other robots
  • test on Cob

from cob_robots.

mgruhler avatar mgruhler commented on August 15, 2024

@ipa-srd-fg as discussed, you can find a draft of the adapted structure on my remote, branch fix/deprecated_costmap_params (Link). Currently only for r@w3-2.

Can you check if this works?

from cob_robots.

ipa-srd-fg avatar ipa-srd-fg commented on August 15, 2024

As discussed with @ipa-mig, the deprecation warning is not only an issue for local_costmap_params.yaml, but also for the costmaps of the ipa_navigation repositories. Since I have not had much to do with the costmap node, I am currently not that familiar with the new parameter style. Therefore, I would like to postpone this issue until I have finished the multi robot support in order to tackle one problem after the other, if that is ok.

from cob_robots.

fmessmer avatar fmessmer commented on August 15, 2024

I'm fine with that as long as we remember this issue and eventually solve it 😉

from cob_robots.

mgruhler avatar mgruhler commented on August 15, 2024

Not forgotten :-) I have a draft (for navigation) on a feature branch which seems to work in simulation.
But we need to test this further and also on hardware. As it is for r@w3-2, testing it on another r@w make sense.

Once those tests are complete, we "just" have to port it to the other robots...

from cob_robots.

mgruhler avatar mgruhler commented on August 15, 2024

fixed in #470 and ipa320/cob_navigation#66

from cob_robots.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.