Giter Club home page Giter Club logo

Comments (8)

MangelMaxime avatar MangelMaxime commented on August 16, 2024

Hello 128 inotify instance doesn't seems like a loot.

If possible you can increase that limit: https://dev.to/rubiin/ubuntu-increase-inotify-watcher-file-watch-limit-kf4

I am not sure if this will helps, but in general on Unix system I set .NET to use Polling for watching files. You can do that by this setting export DOTNET_USE_POLLING_FILE_WATCHER=true in your .bashrc or .zshrc file.

from ionide-vscode-fsharp.

JustinChristensen avatar JustinChristensen commented on August 16, 2024

I understand your perspective here, and I'm aware I'd be able to adjust that limit or force it to use a different polling mechanism, but this is the first time I've ever been confronted with this as a problem, and Ionide isn't the only program I run that relies on inotify.

From my perspective this is a clear bug somewhere (whether its a bug in vscode itself or Ionide I can't say), and it shouldn't be consuming 120-some inotify instances just to work on one project in one instance of vscode.

128 instances is the default setting, and for most people running watchers they'll never even come close to that limit if the programs they're running make correct use of this resource.

from ionide-vscode-fsharp.

JustinChristensen avatar JustinChristensen commented on August 16, 2024

Also 128 is just the upper bound it ran into where it couldn't spawn any more inotify instances. If something is going haywire and continuing to try and create them even setting it to 600 wouldn't solve the problem - it would just cause Ionide to eventually be consuming 600 inotify instances.

from ionide-vscode-fsharp.

MangelMaxime avatar MangelMaxime commented on August 16, 2024

I don't know from my experience VSCode/Ionide is not the only program that has this issues on my machines that's why I proposed to increase the limit.

For now this is a workaround until someone has an idea how to debug this issue or fix it.

from ionide-vscode-fsharp.

TheAngryByrd avatar TheAngryByrd commented on August 16, 2024

Since we use FileSystemWatcher for changes to fsproj and related files it's a dotnet runtime issue. dotnet/runtime#62869

from ionide-vscode-fsharp.

JustinChristensen avatar JustinChristensen commented on August 16, 2024

Yeah, but if I understand the API correctly that implies one FileSystemWatcher is one inotify instance? If so, shouldn't Ionide only ever be creating one FileSystemWatcher at a time? Meaning, is something not disposing of FileSystemWatcher's when it should be?

from ionide-vscode-fsharp.

TheAngryByrd avatar TheAngryByrd commented on August 16, 2024

If so, shouldn't Ionide only ever be creating one FileSystemWatcher at a time?

No, we create FileSystemWatcher to watch F# Projects and related files to know when to schedule msbuild project reloading. This could be many depending on your projects.

from ionide-vscode-fsharp.

JustinChristensen avatar JustinChristensen commented on August 16, 2024

Well, in this case I only had one vscode instance open with a slightly modified solution based on https://github.com/elmish/templates/tree/master. Not a large project. I'm testing out Fable for the first time, and then boom I find that Ionide has hogging all of my system's inotify instances.

from ionide-vscode-fsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.