Build lightning fast Progressive Web Apps with zero config and best practices built-in. Go from zero to production ready with Ionic and Stencil (Web Components).
License: MIT License
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
0.6.1
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
git clone https://github.com/ionic-team/ionic-pwa-toolkit.git
cd ionic-pwa-toolkit
npm i
npm start
npm i firebase
npm start
Build info:
preferring built-in module 'punycode' over local alternative at 'D:\dev\pma-backend\ionic-pwa-toolkit\node_modules\punycode\punycode.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
preferring built-in module 'punycode' over local alternative at 'D:\dev\pma-backend\ionic-pwa-toolkit\node_modules\punycode\punycode.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
preferring built-in module 'string_decoder' over local alternative at 'D:\dev\pma-backend\ionic-pwa-toolkit\node_modules\string_decoder\lib\string_decoder.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
preferring built-in module 'string_decoder' over local alternative at 'D:\dev\pma-backend\ionic-pwa-toolkit\node_modules\string_decoder\lib\string_decoder.js', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning
npm i [email protected]
npm start
{ SyntaxError: Unexpected token i in JSON at position 0
at error (D:\dev\pma-backend\ionic-pwa-toolkit\node_modules@stencil\core\node_modules\rollup\dist\rollup.js:170:15)
at Object.error (D:\dev\pma-backend\ionic-pwa-toolkit\node_modules@stencil\core\node_modules\rollup\dist\rollup.js:17509:21)
at D:\dev\pma-backend\ionic-pwa-toolkit\node_modules@stencil\core\node_modules\rollup\dist\rollup.js:17518:29
at
code: 'PLUGIN_ERROR',
plugin: 'json',
id: '\u0000commonjs-proxy:D:\dev\pma-backend\ionic-pwa-toolkit\node_modules\tough-cookie\package.json' }[ ERROR ] Unexpected token i in JSON at position 0
[ ERROR ] rollup died at
D:\dev\pma-backend\ionic-pwa-toolkit\node_modules@stencil\core\dist\compiler\index.js:2061:19 at
Generator.throw () at rejected
(D:\dev\pma-backend\ionic-pwa-toolkit\node_modules@stencil\core\dist\compiler\index.js:2017:65) at
[56:02.0] build failed, watching for changes... in 6.67 s
npm i firebase@latest
npm start
[ WARN ] 'dom-storage' is imported by node_modules\firebase\index.node.js, but could not be resolved – treating it as
an external dependency[ WARN ] 'xmlhttprequest' is imported by node_modules\firebase\index.node.js, but could not be resolved – treating it
as an external dependency[ WARN ] 'dom-storage' is imported by commonjs-external:dom-storage, but could not be resolved – treating it as an
external dependency[ WARN ] 'xmlhttprequest' is imported by commonjs-external:xmlhttprequest, but could not be resolved – treating it
as an external dependency
Add this to app-home
import firebase from 'firebase';
firebase.initializeApp({ ... config ... });
firebase.auth().signInWithPopup(new firebase.auth.GoogleAuthProvider());
In console:
code: "auth/operation-not-supported-in-this-environment"
message: "This operation is not supported in the environment this application is running on. "location.protocol" must be http, https or chrome-extension and web storage must be enabled."
Other information:
Windows, Chrome
Windows 10 x64
I'm submitting a ... (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Cannot see file in icon editor
Expected behavior:
Should see file in icon editor
Steps to reproduce:
#27
I'm experimenting adding the sources of the www output folder to a public subfolder in my laravel application, public/pwa. The pwa loads fine when going to myproject.com/pwa but the service worker and other relative links fail because they are all pointing to / when really i need them to point to /pwa/ since the pwa is not at the root of my site.
Is there a way to set this root in the PWA toolkit application source so when running npm run build all file paths generated point to the specified root? I thought this would work by modifyng the host.config.json but no avail.
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
Roberts-MacBook-Pro:myapp robertp$ npm list @stencil/core
[email protected] /Users/robertp/workspace/myapp
└── @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
I get a single error when trying to build (against node v10.0.0) - npm run build
[ ERROR ] typescript: node_modules/@ionic/core/dist/types/utils/overlays.d.ts:9:82
Type 'keyof B' does not satisfy the constraint 'string'. Type 'string | number | symbol' is not assignable
to type 'string'. Type 'number' is not assignable to type 'string'.
L8: };
L9: ction createOverlay<T extends HTMLIonOverlayElement & Requires<keyof B>, B>(element: T, opts: B): Promise<T>;
L10: export declare function dismissOverlay(data: any, role: string | undefined, overlays: OverlayMap, id: number): Promise<void>;
Expected behavior:
I fixed by editing node_modules/@ionic/core/dist/types/utils/overlays.d.ts based on ionic-team/ionic-framework@87fe5ce#diff-24fcc947660e79d1b2f094ec1b7dc3f5. I've cleaned my node_modules couple times and reinstalled to latest ionic-core, and still get the error. So the expected behavior is for this change made 18 days ago yet tags were cut 15 days ago to be in sync?
Other information:
Here's my package.json -
"dependencies": {
"@ionic/core": "^4.0.0-alpha.7",
"@stencil/core": "^0.9.7",
"firebase": "^4.13.1",
"rxjs": "^5.5.11"
},
"devDependencies": {
"@stencil/dev-server": "latest",
"@stencil/sass": "0.0.3",
"@stencil/utils": "latest",
"@types/jest": "^22.2.2",
"jest": "^22.4.4"
},
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Chrome's pull to refresh default feature not working on Chrome for Android
Expected behavior:
I should be able to refresh the current page with Chrome's pull to refresh feature
Steps to reproduce:
Ionic-Pwa-Toolkitnpm run buildFirebase hosting)Firebase project in your project's root directory: firebase inithosting optionwww as public directoryfirebase deployRelated code:
insert any relevant code here
Other information:
Chrome 64.0.3282.137
Android 7.1.1
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] /Users/queaujeanpierre/Documents/PWAApps/couchdb-app-starter/couchdb-app-client
└── @stencil/[email protected]
@ionic/core": "0.0.4-1"
I'm submitting a ... (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
if you are using the ToastController in other app webcomponent ie page ,the page will continuously reload.
Expected behavior:
the toast inside the web component should present and dismiss without emiting to the Listen of the app-main meaning that the 'body:ionToastWillDismiss' is not enough specific and at the time we create the window.addEventListener('swUpdate'... we should be able to get the corresponding toastId ie swtoastId and modify the listen as follolw:
@listen('body:ionToastWillDismiss')
if(toastId === swtoastId {
reload() {
window.location.reload();
}
}
Steps to reproduce:
easy to reproduce clone the ionic -pwa-toolkit in the app-profile add a toastController and create a toast and present it. the app-profile page will continuously reload
Related code:
insert any relevant code here
Other information:
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
When using the sample app, when I click on the profile page, the url appropriately changes to /profile/stencil. If I click on the ion-back-button, we are routed correctly back to /. However, if I click on the browser back button, nothing happens. If I click on the browser back button a second time, we are routed back to /.
Expected behavior:
I expect a single browser back click to navigate back to root, rather than requiring two clicks.
Steps to reproduce:
I think it is described enough in Current behavior. Let me know otherwise!
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
When using a modal in the PWA toolkit (import { ModalController } from '@ionic/core') the modal works and properly displays as designed on desktop web browsers and on my iPad, but it does not show up when on my iPhone 6 (when the modal is called in my iPhone, it does not show up but something does invisibly block the underlying page - cannot press buttons or navigate, etc.).
Expected behavior:
I expect the modal to show up in all devices including on iPhone devices.
Steps to reproduce:
Create a modal in the PWA toolkit and test it on a desktop and tablet device and then test to reproduce the issue on an iPhone (or maybe the same thing will occur on smaller devices - I don't know).
import { Component, Prop, State } from '@stencil/core';
import { ModalController } from '@ionic/core';
@component({
tag: 'app-logon',
styleUrl: 'app-logon.scss'
})
export class AppLogOn {
@Prop({ connect: 'ion-modal-controller' }) modalCtrl: ModalController;
@State() modal: any;
openHelp() {
this.modalCtrl.create({
component: 'app-help'
}).then((modal) => {
this.modal = modal;
this.modal.present();
}).catch((error) => {
console.error(error.message);
}
)
};
Other information:
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Error in console after npm start (from the unchanged cloned repo)
app-profile.md.js:45 Uncaught (in promise) TypeError: Cannot read property 'pushManager' of undefined
at navigator.serviceWorker.getRegistration.then (app-profile.md.js:45)
at <anonymous>
Expected behavior:
no error
Steps to reproduce:
Clone repo
npm install
npm start (as per the README)
Click on Profile page
Toggle Notifications
Related code:
Other information:
Logs true to the console when there is an error (Notifcations toggled on).
No error when toggled false
There's a helpers/util.ts file with what appears to be an unused function urlB64ToUint8Array. Either way, we shouldn't have that kind of thing in here
Im running it for the first time. After running npm start it just builds for hours. I decided to cancel it from the terminal and run npm start again. Then my system becomes unresponsive. Completely unresponsive. I'm using linux mint.
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[ X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Receive the following runtime error on build:
[ ERROR ] Runtime error detected while rendering: ion-app
e.matchMedia is not a function TypeError: e.matchMedia is not a function
at i (evalmachine.:2:2586) at e.render
(evalmachine.:2:3045) at render
(c:\Users\DT911\Documents\IONIC
PROJECTS\my-pwa_alpha3\node_modules@stencil\core\dist\compiler\index.js:10892:63)
at renderUpdate (c:\Users\DT911\Documents\IONIC
PROJECTS\my-pwa_alpha3\node_modules@stencil\core\dist\compiler\index.js:11096:5)
at update (c:\Users\DT911\Documents\IONIC
PROJECTS\my-pwa_alpha3\node_modules@stencil\core\dist\compiler\index.js:11089:13)
at plt.queue.tick (c:\Users\DT911\Documents\IONIC
PROJECTS\my-pwa_alpha3\node_modules@stencil\core\dist\compiler\index.js:11015:34)
at flush (c:\Users\DT911\Documents\IONIC
PROJECTS\my-pwa_alpha3\node_modules@stencil\core\dist\compiler\index.js:12241:33)
at _combinedTickCallback (internal/process/next_tick.js:131:7) at
process._tickCallback (internal/process/next_tick.js:180:9)
Expected behavior:
A successful build without any runtime errors.
Steps to reproduce:
Using a clean ionic/core 4.0.0-alpha.3 PWA Toolkit clone, run build.
Related code:
insert any relevant code here
Other information:
I don't think lazy-img component is something that belong to an starter, in fact I really believe we should have an ion-img as part of ionic/core
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
adding menuToggle attribute to a button produces typescript compilation error:
Property 'menuToggle' does not exist on type 'IonButtonAttributes'.
Expected behavior:
Using ionic components as documented just works.
Steps to reproduce:
Try to implement button component as described here:
https://ionicframework.com/docs/api/components/toolbar/Navbar/
Related code:
<button ion-button icon-only menuToggle>
<ion-icon name='menu'></ion-icon>
</button>Other information:
I'm new to Ionic. Is there documentation about using it with Stencil ?
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
0.7.16+
I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
PS C:\VSCode\git-hub-tim\pwa-toolbox-firebase> npm test
> @stencil/[email protected] test C:\VSCode\git-hub-tim\pwa-toolbox-firebase
> jest --no-cache
FAIL src\components\app-home\app-home.spec.ts
● Test suite failed to run
Cannot find module 'C:VSCodegit-hub-timpwa-toolbox-firebase
ode_modules@stencilcoredist estingindex.js' from 'app-home.tsx'
at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (src/components/app-home/app-home.tsx:3:22)
FAIL src\components\app-profile\app-profile.spec.ts
● Test suite failed to run
Cannot find module 'C:VSCodegit-hub-timpwa-toolbox-firebase
ode_modules@stencilcoredist estingindex.js' from 'app-profile.tsx'
at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (src/components/app-profile/app-profile.tsx:3:22)
FAIL src\components\my-app\my-app.spec.ts
● Test suite failed to run
Cannot find module 'C:VSCodegit-hub-timpwa-toolbox-firebase
ode_modules@stencilcoredist estingindex.js' from 'my-app.tsx'
at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (src/components/my-app/my-app.tsx:3:22)Expected behavior:
Steps to reproduce:
Update package.json
npm install
npm test
Related code:
insert any relevant code here
Other information:
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request
Current behavior:
I am using the component. When I go to the picker, it opens up, I select "Done" without changing the highlighted date/time, and only the hours and PM or AM will display. If I change the date / time, only the changed items will display after selecting done.
Expected behavior:
I would expect the entire date and time would display after closing the prompt module.
Steps to reproduce:
Add ion-datetime component to existing pwa-toolkit, click on field, don't change date and select "done".
Related code:
Offence Date and Time
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
└── @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Added dom [for ion-split-pane] consisting of a ion-menu, andnpm run build goes bonkers.
[ ERROR ] ctrlElm.componentOnReady is not a function TypeError: ctrlElm.componentOnReady is not a function at
resolve
(/Users/rpersaud2/workspace/ionic-pwa-toolkit/node_modules/@stencil/core/dist/compiler/index.js:12225:17)
at Promise (<anonymous>) at loadComponent
(/Users/rpersaud2/workspace/ionic-pwa-toolkit/node_modules/@stencil/core/dist/compiler/index.js:12216:12)
at Object.componentOnReady
(/Users/rpersaud2/workspace/ionic-pwa-toolkit/node_modules/@stencil/core/dist/compiler/index.js:12211:16)
at e.<anonymous> (evalmachine.<anonymous>:2:27814) at evalmachine.<anonymous>:2:1246 at Object.next
(evalmachine.<anonymous>:2:1351) at evalmachine.<anonymous>:2:285 at Promise (<anonymous>) at __awaiter
(evalmachine.<anonymous>:2:62)
Expected behavior:
Clicking on the hamburger should slide out a side menu to the right, and I should have clean build.
Steps to reproduce:
I threw this dom into my-app.tsx from the latest ionic pwa toolkit repo today -
Related code:
render() {
return (
<ion-app>
<main>
<ion-router useHash={false}>
<ion-route url='/' component='app-home'></ion-route>
<ion-route url='/profile/:name' component='app-profile'></ion-route>
<ion-nav></ion-nav>
</ion-router>
<ion-split-pane>
<ion-menu>
<ion-header>
<ion-toolbar>
<ion-title>Menu</ion-title>
</ion-toolbar>
</ion-header>
<ion-content forceOverscroll={false}>
<ion-list>
<ion-list-header>
Navigate
</ion-list-header>
</ion-list>
</ion-content>
</ion-menu>
<ion-router-outlet animated={false} main></ion-router-outlet>
</ion-split-pane>
</main>
</ion-app>
);
Other information:
Resources:
Before submitting an issue, please consult our docs.
$ ionic -v
3.19.1
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
$ npm list @stencil/core
@stencil/[email protected] C:\ae\adaept.com\arehta
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
{
"error": {
"errno": -4058,
"code": "ENOENT",
"syscall": "stat",
"path": "C:\\ae\\adaept.com\\arehta\\www"
}
}
Expected behavior:
It runs
Steps to reproduce:
$ git clone https://github.com/ionic-team/ionic-pwa-toolkit.git arehta
$ cd arehta
$ git remote rm origin
$ npm install
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
. . .
$ npm start
> @stencil/[email protected] start C:\ae\adaept.com\arehta
> npm run dev
> @stencil/[email protected] dev C:\ae\adaept.com\arehta
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"
events.js:183
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE :::3333
at Object._errnoException (util.js:1022:11)
at _exceptionWithHostPort (util.js:1044:20)
at Server.setupListenHandle [as _listen2] (net.js:1351:14)
at listenInCluster (net.js:1392:12)
at Server.listen (net.js:1476:7)
at Object.<anonymous> (C:\ae\adaept.com\arehta\node_modules\@stencil\dev-server\dist\index.js:88:64)
at Generator.next (<anonymous>)
at fulfilled (C:\ae\adaept.com\arehta\node_modules\@stencil\dev-server\dist\index.js:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
[26:06.3] @stencil/core v0.6.1
[26:06.3] build, app, dev mode, started ...
[26:06.3] compile started ...
[26:10.5] compile finished in 4.19 s
[26:12.2] generate bundles started ...
[26:12.2] generate bundles finished in 8 ms
[26:12.2] generate app files started ...
[26:12.2] compile global style start ...
[26:12.2] compile global style finish in 1 ms
[26:12.2] generate app files finished in 83 ms
[26:12.6] build finished, watching for changes... in 6.25 s
Related code:
insert any relevant code here
Other information:
Looks like the server is stuck in the background.
It is not open in any tabs.
W10 x64
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/core v0.9.7
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Build fail
Expected behavior:
Starter works
Steps to reproduce:
Other information:
C:\ae\adaept.com\aepwa>ionic info
[WARN] You are not in an Ionic project directory. Project context may be missing.
cli packages: (C:\Users\peter\AppData\Roaming\npm\node_modules)
@ionic/cli-utils : 2.0.0-rc.6
ionic (Ionic CLI) : 4.0.0-rc.6
System:
NodeJS : v8.11.1
npm : 6.1.0-next.0
OS : Windows 10
C:\ae\adaept.com\aepwa>
I ran npm audit fix and it reported corrected 4 security errors.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Just start with cloning the project and start it but got the following error while turning on notifications.
Uncaught (in promise) TypeError: Cannot read property 'pushManager' of undefined
at navigator.serviceWorker.getRegistration.then (app-profile.js:41)
at <anonymous>
navigator.serviceWorker.getRegistration.then @ app-profile.js:41
Promise resolved (async)
handleSub @ app-profile.js:39
subscribeToNotify @ app-profile.js:34
ev @ app.core.js:702
domApi.$dispatchEvent @ app.core.js:582
Context.emit @ app.core.js:1873
emit @ app.core.js:669
checkedChanged @ ion-toggle.md.js:91
setValue @ app.core.js:1185
setComponentProp @ app.core.js:1102
onDragEnd @ ion-toggle.md.js:127
pointerUp @ ion-gesture.js:622
onMouseUp @ ion-gesture.js:605
plt.domApi.$addEventListener.ev @ app.core.js:722
Expected behavior:
Steps to reproduce:
Just clone and start.
Related code:
reg.pushManager.getSubscription().then((sub) => {
Other information:
Chrome Version 63.0.3239.132 (Official Build) (64-bit)
There's an awful lot of custom code in app-profile.tsx related to managing push notifications. I'm not convinced this is the way we want to tell users to interact with the push service.
This might be a good candidate for an external library or a reusable class we can provide instead of keeping the code in a single component. Unlike the helpers thing, push notifications is a common enough, easily abstracted concept, that it probably makes sense to provide a helper class or utility library for it.
Thoughts?
Hello,
This is more of a question, is there a way to extend the colors for the ionic components in this pwa/stencil project?
Note: myNewlyDefinedColor below instead of 'primary'
<ion-header>
<ion-toolbar color='myNewlyDefinedColor'>
<ion-title>Ionic PWA Toolkit</ion-title>
</ion-toolbar>
</ion-header>
Thank you!
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] /Users/joewoodhouse/src/coreo/guideyouragent-pwa
└── @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
Current behavior:
Running npm test fails.
Expected behavior:
Running npm test should pass.
Steps to reproduce:
npm run testRelated code:
The failure output looks like:
> @stencil/[email protected] test /Users/joewoodhouse/src/coreo/guideyouragent-pwa
> jest --no-cache
FAIL dist/collection/dependencies/components/__tests__/test-app.js
● Test suite failed to run
/Users/joewoodhouse/src/coreo/guideyouragent-pwa/dist/collection/dependencies/components/__tests__/test-app.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export class TestApp {
^^^^^^
SyntaxError: Unexpected token export
at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:305:17)
at Generator.next (<anonymous>)
at new Promise (<anonymous>)
FAIL dist/collection/dependencies/components/__tests__/test-demo-three.js
● Test suite failed to run
/Users/joewoodhouse/src/coreo/guideyouragent-pwa/dist/collection/dependencies/components/__tests__/test-demo-three.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export class TestDemoThree {
^^^^^^
SyntaxError: Unexpected token export
at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:305:17)
at Generator.next (<anonymous>)
at new Promise (<anonymous>)
FAIL dist/collection/dependencies/components/__tests__/test-demo-four.js
● Test suite failed to run
/Users/joewoodhouse/src/coreo/guideyouragent-pwa/dist/collection/dependencies/components/__tests__/test-demo-four.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export class TestDemoFour {
^^^^^^
SyntaxError: Unexpected token export
at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:305:17)
at Generator.next (<anonymous>)
at new Promise (<anonymous>)
FAIL dist/collection/dependencies/components/__tests__/test-demo-six.js
● Test suite failed to run
/Users/joewoodhouse/src/coreo/guideyouragent-pwa/dist/collection/dependencies/components/__tests__/test-demo-six.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export class TestDemoSix {
^^^^^^
SyntaxError: Unexpected token export
at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:305:17)
at Generator.next (<anonymous>)
at new Promise (<anonymous>)
PASS src/components/app-home/app-home.spec.ts
PASS src/components/my-app/my-app.spec.ts
FAIL src/components/app-profile/app-profile.spec.ts
● app-profile › rendering › should work with a name passed
expect(received).toEqual(expected)
Expected value to equal:
"Hello! My name is stencil. My name was passed in through a route param!"
Received:
"Ionic PWA ToolkitHello! My name is stencil. My name was passed in through a route param!"
at Object.<anonymous> (src/components/app-profile/app-profile.spec.ts:83:53)
at step (src/components/app-profile/app-profile.spec.ts:32:23)
at Object.next (src/components/app-profile/app-profile.spec.ts:13:53)
at fulfilled (src/components/app-profile/app-profile.spec.ts:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
Test Suites: 5 failed, 2 passed, 7 total
Tests: 1 failed, 4 passed, 5 total
Snapshots: 0 total
Time: 4.033s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @stencil/[email protected] test: `jest --no-cache`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @stencil/[email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/joewoodhouse/.npm/_logs/2018-02-01T09_20_24_820Z-debug.log
Other information:
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] d:\test\my-pwa
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Running npm start on Windows 7 64bit with node v8.9.4 and npm 5.6.0 results in error. Browser is opened with "Initializing First Build..." title, but app build errors out.
[59:47.8] @stencil/core v0.1.6
[59:47.8] build, app, dev mode, started ...
[59:47.8] compile started ...
[59:47.8] compile finished in less than 1 ms
[59:48.4] generate bundles started ...
[59:48.4] generate bundles finished in less than 1 ms
[ ERROR ] Component tag "app-home" is defined in a bundle but no matching compo
nent was found within this app or
collections.
[ ERROR ] Component tag "my-app" is defined in a bundle but no matching compone
nt was found within this app or
collections.
[ ERROR ] Component tag "app-profile" is defined in a bundle but no matching co
mponent was found within this app or
collections.
[ ERROR ] Component tag "lazy-img" is defined in a bundle but no matching compo
nent was found within this app or
collections.
[59:48.8] build failed, watching for changes... in 999 ms
Expected behavior:
App is built without errors.
Steps to reproduce:
Use "Getting Started" instructions from README.md
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] /home/kael/dev/test/my-pwa
└── @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Fetching the last master commits, something's broken out of the box:
[ ERROR ] Component tag "my-app" is defined in a bundle but no matching component was found within this app or its
collections. at b.components.map.tag
(/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:8235:23) at Array.map
(<anonymous>) at configBundles.map.b
(/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:8231:14) at Array.map
(<anonymous>) at getUserConfigEntryTags
(/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:8229:10) at
generateEntryModules
(/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:8060:44) at
/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:14960:34 at
Generator.next (<anonymous>) at fulfilled
(/home/kael/dev/test/my-pwa/node_modules/@stencil/core/dist/compiler/index.js:14924:58) at
<anonymous>Adding the removed bundle components in stencil.config.js, doesn't fix the thing.
BTW, not sure that running git remote rm origin is the best way to keep up-to-date with the project, I've renamed this remote and I'm rebasing on my local directory. Unless there's a better way ?
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
insert the output from npm list @stencil/core here
I'm submitting a ... (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
When running npm start on Firefox 57, with modules enabled (in about:config) it shows that the app is disabled for this browser. I see the list of features it is testing for and the browser passes with module support enabled.
Expected behavior:
Expected to be able to develop in firefox 57 with module support enabled.
Steps to reproduce:
Related code:
insert any relevant code here
Other information:
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit>npm start
> @stencil/[email protected] start C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit
> npm run dev
> @stencil/[email protected] dev C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"
[17:01.0] @stencil/core v0.6.1
[17:01.0] build, app, dev mode, started ...
[17:01.0] compile started ...
[17:04.1] compile finished in 3.06 s
{ Error: Could not resolve './dist/collection/components/lazy-img/lazy-img.js' from entry:lazy-img
at error (C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit\node_modules\@stencil\core\node_modules\rollup\dist\rollup.js:170:15)
at C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit\node_modules\@stencil\core\node_modules\rollup\dist\rollup.js:19580:25
at <anonymous> code: 'UNRESOLVED_IMPORT' }
[ ERROR ] Could not resolve './dist/collection/components/lazy-img/lazy-img.js' from entry:lazy-img
[ ERROR ] rollup died at
C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit\node_modules\@stencil\core\dist\compiler\index.js:2061:19
at Generator.throw (<anonymous>) at rejected
(C:\Users\daniel.ehrhardt\Desktop\Alles\Geschäftlich\ionic-pwa-toolkit\node_modules\@stencil\core\dist\compiler\index.js:2017:65)
at <anonymous>
[17:04.9] build failed, watching for changes... in 3.87 s
Expected behavior:
App should start dev build
Steps to reproduce:
Clone the repo run npm install and then npm start
Related code:
node -v
v8.9.4
npm -v (same with 5.6.0)
5.7.1
Windows 10 64 bit
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
When <ion-item> component contains multiple lines, it will not automatically expand it’s height to fit the new lines of text
Expected behavior:
Multi-line list expected result
Steps to reproduce:
import { Component} from '@stencil/core';
@Component({
tag: 'app-list',
styleUrl: 'app-list.scss'
})
export class AppList {
render() {
return (
<ion-list>
<ion-item>
<h2>Finn</h2>
<h3>I'm a big deal</h3>
<p>Listen, I've had a pretty messed up day...</p>
</ion-item>
</ion-list>
);
}
}
Related code:
insert any relevant code here
Other information:
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
"@ionic/core": "^0.1.4",
"@stencil/core": "0.7.7",
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Some tests fail.
Expected behavior:
All tests pass.
Steps to reproduce:
git clone https://github.com/ionic-team/ionic-pwa-toolkit.git my-pwa
cd my-pwa
git remote rm origin
npm install
npm test
Related code:
Other information:
> jest --no-cache
PASS src\components\app-home\app-home.spec.ts
FAIL src\components\my-app\my-app.spec.ts
● Test suite failed to run
TypeError: Cannot read property 'getAttribute' of undefined
at Object.<anonymous>.m.ios (node_modules/@ionic/core/dist/ionic.js:5:575)
at Object.<anonymous> (node_modules/@ionic/core/dist/ionic.js:5:1271)
at Object.<anonymous> (src/components/my-app/my-app.tsx:8:1)
at Object.<anonymous> (src/components/my-app/my-app.spec.ts:40:16)
at Generator.next (<anonymous>)
at new Promise (<anonymous>)
at handle (node_modules/worker-farm/lib/child/index.js:44:8)
at process.<anonymous> (node_modules/worker-farm/lib/child/index.js:51:3)
at emitTwo (events.js:126:13)
at process.emit (events.js:214:7)
at emit (internal/child_process.js:772:12)
at _combinedTickCallback (internal/process/next_tick.js:141:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
FAIL src\components\app-profile\app-profile.spec.ts (7.734s)
● app-profile › rendering › should not render any content if there is not a match
expect(received).toEqual(expected)
Expected value to equal:
""
Received:
"Ionic PWA ToolkitHello! My name is . My name was passed in through a route param!"
at Object.<anonymous> (src/components/app-profile/app-profile.spec.ts:66:53)
at step (src/components/app-profile/app-profile.spec.ts:32:23)
at Object.next (src/components/app-profile/app-profile.spec.ts:13:53)
at fulfilled (src/components/app-profile/app-profile.spec.ts:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
● app-profile › rendering › should work with a name passed
expect(received).toEqual(expected)
Expected value to equal:
"Hello! My name is stencil. My name was passed in through a route param!"
Received:
"Hello! My name is . My name was passed in through a route param!"
at Object.<anonymous> (src/components/app-profile/app-profile.spec.ts:85:54)
at step (src/components/app-profile/app-profile.spec.ts:32:23)
at Object.next (src/components/app-profile/app-profile.spec.ts:13:53)
at fulfilled (src/components/app-profile/app-profile.spec.ts:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
Test Suites: 2 failed, 1 passed, 3 total
Tests: 2 failed, 2 passed, 4 total
Snapshots: 0 total
Time: 10.36s
Ran all test suites.
npm ERR! Test failed. See above for more details.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
Current behavior:
Running npm start completes build with "build finished, watching for changes..." message, but app is never loaded in browser, stuck with "Initializing First Build" message. After few moments disk read or write (not really sure which) usage ramps up and OS freezes.
Expected behavior:
App is built and displayed in browser.
Steps to reproduce:
Ununtu 17.10 64-bit, nodejs v8.9.4, npm v5.6.0
Use 'Getting started' section from README.md, run npm start.
Resources:
Already check the documentation and the feature is not ready yet.
Stencil version: @stencil/[email protected]
I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Right now is not possible to change the THEME colors variable of the application as you can in IONIC because the variable are taken from a file in the Node_Module folder.
Expected behavior:
Be able to change the applications colors as easily as you can in IONIC just changing a file as you can in IONIC in the theme.scss file.
Steps to reproduce:
Create a new PWA Toolkit app
Other information:
Even thought you can actually change the colors through component scss files and the global scss file it would be way more easier to mantain if you can change the application color in a file as you can do in IONIC, Since this affect pretty much every component built-in the PWA Toolkit.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
"@ionic/core": "4.0.0-alpha.7",
"@stencil/core": "0.9.1"
"@stencil/sass": "0.0.5",
C:\ae\adaept.com\ionic-pwa-toolkit>ionic info
[WARN] You are not in an Ionic project directory. Project context may be missing.
cli packages: (C:\Users\peter\AppData\Roaming\npm\node_modules)
@ionic/cli-utils : 2.0.0-rc.6
ionic (Ionic CLI) : 4.0.0-rc.6
System:
NodeJS : v8.11.1
npm : 6.0.1
OS : Windows 10
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
breaking
Expected behavior:
working
Steps to reproduce:
C:\ae\adaept.com\ionic-pwa-toolkit>npm start
> @stencil/[email protected] start C:\ae\adaept.com\ionic-pwa-toolkit
> npm run dev
> @stencil/[email protected] dev C:\ae\adaept.com\ionic-pwa-toolkit
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"
[38:47.8] @stencil/core v0.9.1
[38:47.8] build, app, dev mode, started ...
[38:47.9] compile started ...
[38:51.7] compile finished in 3.80 s
[ ERROR ] typescript: C:/ae/adaept.com/ionic-pwa-toolkit/src/global/app.ts, line: 1
Module '"C:/ae/adaept.com/ionic-pwa-toolkit/node_modules/@ionic/core/dist/types/index"' has no exported
member 'setupConfig'.
L1: import { setupConfig } from '@ionic/core';
[38:52.1] build failed, watching for changes... in 4.31 s
Other information:
I'm submitting a ... (check one with "x")
[ ] bug report
[X] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
At present, on Ionic when using as a PWA on iOS (11.3), the OS doesn't store the navstate when briefly swapping to another app and returning, meaning the user ends back at the root screen very frequently. The end result is a very non-native feel (see this discussion the ionic forums). I realise that this is a limitation of the OS and not a bug, but it would be helpful if the framework could respond to this by caching the navstate and restoring it somehow to mimic a native feel (until Apple get their act together).
Expected behavior:
User briefly exits an app, enters another, then re-opens the app and finds themselves back on the page they were last in.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
peter@Merry-Christmas MINGW64 /c/ae/adaept.com/aepwa (master)
$ npm list @stencil/core
@stencil/[email protected] C:\ae\adaept.com\aepwa
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Fail
Expected behavior:
Run
Steps to reproduce:
peter@Merry-Christmas MINGW64 /c/ae/adaept.com
$ git clone https://github.com/ionic-team/ionic-pwa-toolkit.git aepwa
Cloning into 'aepwa'...
remote: Counting objects: 371, done.
remote: Compressing objects: 100% (56/56), done.
Receiving oremote: Total 371 (delta 55), reused 83 (delta 44), pack-reused 267
Receiving objects: 100% (371/371), 284.98 KiB | 1.27 MiB/s, done.
Resolving deltas: 100% (217/217), done.
peter@Merry-Christmas MINGW64 /c/ae/adaept.com
$ cd aepwa
peter@Merry-Christmas MINGW64 /c/ae/adaept.com/aepwa (master)
$ git remote rm origin
peter@Merry-Christmas MINGW64 /c/ae/adaept.com/aepwa (master)
$ npm i
> [email protected] install C:\ae\adaept.com\aepwa\node_modules\node-sass
> node scripts/install.js
Cached binary found at C:\Users\peter\AppData\Roaming\npm-cache\node-sass\4.7.2\win32-x64-57_binding.node
> [email protected] postinstall C:\ae\adaept.com\aepwa\node_modules\node-sass
> node scripts/build.js
Binary found at C:\ae\adaept.com\aepwa\node_modules\node-sass\vendor\win32-x64-57\binding.node
Testing binary
Binary is fine
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
added 858 packages from 485 contributors in 26.945s
peter@Merry-Christmas MINGW64 /c/ae/adaept.com/aepwa (master)
$ npm start
> @stencil/[email protected] start C:\ae\adaept.com\aepwa
> npm run dev
> @stencil/[email protected] dev C:\ae\adaept.com\aepwa
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"
events.js:183
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE :::3333
at Object._errnoException (util.js:1022:11)
at _exceptionWithHostPort (util.js:1044:20)
at Server.setupListenHandle [as _listen2] (net.js:1367:14)
at listenInCluster (net.js:1408:12)
at Server.listen (net.js:1492:7)
at Object.<anonymous> (C:\ae\adaept.com\aepwa\node_modules\@stencil\dev-server\dist\index.js:88:64)
at Generator.next (<anonymous>)
at fulfilled (C:\ae\adaept.com\aepwa\node_modules\@stencil\dev-server\dist\index.js:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
[03:04.6] @stencil/core v0.7.24
[03:04.6] build, app, dev mode, started ...
[03:04.6] compile started ...
[03:08.7] compile finished in 4.09 s
[03:08.7] module map started ...
[03:09.5] module map finished in 785 ms
[03:10.6] generate bundles started ...
[03:10.6] generate bundles finished in 9 ms
[03:10.6] generate app files started ...
[03:10.6] compile global style start ...
[03:10.6] compile global style finish in less than 1 ms
[03:10.6] generate app files finished in 34 ms
[03:12.2] build finished, watching for changes... in 7.62 s
Other information:
The app says build finished but does not open.
ENOENT on first run
Ctr-C, then it works on second run
Screen flashes twice on opening
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
C:\ae\aedev\ionic-pwa-toolkit>npm list @stencil/core
@stencil/[email protected] C:\ae\aedev\ionic-pwa-toolkit
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
{
"error": {
"errno": -4058,
"code": "ENOENT",
"syscall": "stat",
"path": "C:\\ae\\aedev\\ionic-pwa-toolkit\\www"
}
}
Expected behavior:
Should work on first run
Screen should not flash twice
Steps to reproduce:
Create
Related code:
insert any relevant code here
Other information:
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
https://raw.githubusercontent.com/ionic-team/ionic-pwa-toolkit/master/src/assets/icon/favicon.ico
Download and try to open with Icon Editor
Expected behavior:
It should be an icon
Windows 10, x64
What is the actual format? How do I create it when the file is not recognized in
a Windows icon editor?
Tested from clone and also direct download.
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
└── @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Build ignores stencil config because configuration is wrong. Configuration in stencil.config.js currently has outputTarget key, but I think it should be outputTargets?
Expected behavior:
Configuration file should be correct so build respects config.
Steps to reproduce:
Run npm build
Related code:
Other information:
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
C:\ae\adaept.com\aepwa>npm list @stencil/core
@stencil/[email protected] C:\ae\adaept.com\aepwa
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
App icon does not show in Chrome
Expected behavior:
App icon displays in Chrome.
NOTE: It works in other browsers.
Steps to reproduce:
Chrome
Chrome Secure
IE11
Edge
Firefox
Related code:
Other information:
https://aepwa-dev.firebaseapp.com/
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
I added an ion-icon to the toolbar and the icon is not shown.
Expected behavior:
Shows the ionic icon in the toolbar.
Related code:
<ion-header md-height='56px'>
<ion-toolbar color='primary'>
<ion-buttons>
<ion-icon id='ionic-icon' name='ionic'></ion-icon>
</ion-buttons>
<ion-title>Ionic PWA Toolkit</ion-title>
</ion-toolbar>
</ion-header>
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
Norths-MacBook-Pro-2:ionic-pwa-toolkit north$ npm list @stencil/core
@stencil/[email protected] /Users/north/Documents/development/ionic/ionic-pwa-toolkit
└── @stencil/[email protected]
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
When executing the tests with npm test (after applying the fix from this PR #14) one test is failing. That test is app-profile › rendering › should work with a name passed
Here is the full output:
Norths-MacBook-Pro-2:ionic-pwa-toolkit north$ npm test
> @stencil/[email protected] test /Users/north/Documents/development/ionic/ionic-pwa-toolkit
> jest --no-cache
PASS src/components/app-home/app-home.spec.ts
PASS src/components/my-app/my-app.spec.ts
FAIL src/components/app-profile/app-profile.spec.ts
● app-profile › rendering › should work with a name passed
expect(received).toEqual(expected)
Expected value to equal:
"Hello! My name is stencil. My name was passed in through a route param!"
Received:
"Ionic PWA ToolkitHello! My name is stencil. My name was passed in through a route param!"
at Object.<anonymous> (src/components/app-profile/app-profile.spec.ts:83:53)
at step (src/components/app-profile/app-profile.spec.ts:32:23)
at Object.next (src/components/app-profile/app-profile.spec.ts:13:53)
at fulfilled (src/components/app-profile/app-profile.spec.ts:4:58)
at process._tickCallback (internal/process/next_tick.js:109:7)
Test Suites: 1 failed, 2 passed, 3 total
Tests: 1 failed, 4 passed, 5 total
Snapshots: 0 total
Time: 4.162s
Ran all test suites.
npm ERR! Test failed. See above for more details.
It is gathering the text for the entire ion-page. I have a PR that can fix this and bring it up to date
Expected behavior:
npm test when executed should run all the tests, and all tests should pass.
The ideal output is:
> @stencil/[email protected] test /Users/north/Documents/development/ionic/ionic-pwa-toolkit
> jest --no-cache
PASS src/components/app-home/app-home.spec.ts
PASS src/components/my-app/my-app.spec.ts
PASS src/components/app-profile/app-profile.spec.ts
Test Suites: 3 passed, 3 total
Tests: 5 passed, 5 total
Snapshots: 0 total
Time: 4.533s
Ran all test suites.
Steps to reproduce:
Related code:
The PR will select the correct element in the component with this:
const pElement = element.querySelector('ion-content p');
expect(pElement.textContent).toEqual('Hello! My name is stencil. My name was passed in through a route param!');Other information:
I am going to submit a PR for this :D
Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/core v0.7.24
I'm submitting a ... (check one with "x")
[ X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
I'm not sure if I am misunderstanding something in the newest PWA toolkit, but sometimes when I run "npm run devWithSW" it deletes the sw.js file from the build and there is no service worker loaded in the browser. To get the sw.js back, I have to re-build ("npm run build"). But, after I rebuild and run "npm run devWithSW", it deletes the sw.js again.
Here is the sw.js in the www folder after build:
Note the sw.js is gone from the www folder after "npm run devWithSW":
Note that there is no service worker in the browser after "npm run devWithSW":
Expected behavior:
I expect the sw.js to be there everytime after running "npm run devWithSW" so that a service worker is properly loaded in the browser.
Steps to reproduce:
Using Visual Code for the Ionic PWA Toolkit, run build. Note the sw.js file in the build folder (www). Now, run devWithSW and note how the sw.js is deleted and that there is no service worker loaded in the browser. This does not occur eveytime, but enough times where you should be able to replicate it after a few tries.
Related code:
insert any relevant code here
Other information:
I'm submitting a ...
[ ] bug report
[ X] feature request
[ ] support request
Current behavior:
Splash screen not showing on iOS
Expected behavior:
Splash screen is showing on iOS, and can be generated through ionic resources
Steps to reproduce:
Launch the application on an iPhone and expect to see a splash screen
Related code:
According to this article, apple-touch-startup-image metatag is missing.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
Running Windows 10 x64
Git Bash client
$ npm list @stencil/core
@stencil/[email protected] C:\ae\aedhpwa
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Build hangs
Expected behavior:
I do not know
Steps to reproduce:
Fork the repo
Follow build instructions using forked repo
The system is stuck here:
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
0.9.1
I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Opens with unsupported IE
Expected behavior:
Open with a supported browser
OR
Command line info provided for open using Chrome or other browser
Steps to reproduce:
Build with npm start
Related code:
C:\ae\adaept.com\aepwa>npm start
> [email protected] start C:\ae\adaept.com\aepwa
> npm run dev
> [email protected] dev C:\ae\adaept.com\aepwa
> sd concurrent "stencil build --dev --watch" "stencil-dev-server"
[20:28.9] @stencil/core v0.9.1
[20:28.9] build, app, dev mode, started ...
[20:29.0] compile started ...
[20:31.4] compile finished in 2.39 s
[20:31.4] module map started ...
[20:31.9] module map finished in 507 ms
[20:32.7] generate bundles started ...
[20:32.7] generate bundles finished in 10 ms
[20:32.7] generate app files started ...
[20:32.8] compile global style start ...
[20:32.8] compile global style finish in 3 ms
[20:32.8] generate app files finished in 73 ms
[20:33.9] build finished, watching for changes... in 4.94 s
Other information:
I clone a fresh ionic-pwa-toolkit, then run
npm install
However, the npm start command, it shows errors
OS: Windows 10
NPM: 5.6.0
Node: 8.9.2
Resources:
Before submitting an issue, please consult our docs.
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[ ] bug report
[x ] feature request
[ ] support request
Current behavior:
I would like to use developer tools to locally see the sw.js and cache images that I have added to the application. If I deploy my code to a server, I can see the service worker and the cached items. Locally I cannot see the cached items at all.
Expected behavior:
Would like to see the cached items from the service worker
Resources:
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected] /dev/shm/baz
└── UNMET DEPENDENCY @stencil/[email protected]
I'm submitting a ... (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
npm init stencil
npx: installed 1 in 1.146s
👋 Welcome to Stencil Create App!What kind of project do you want to create?
✔ Pick a starter › 💎 ionic-pwa (Everything you need to build fast, production ready PWAs)
✔ Project name … barWe are about to clone "ionic-team/ionic-pwa-toolkit" into "./bar"
✔ Confirm? … yes💎 Cloning ionic-team/ionic-pwa-toolkit...
🏃 Changing directories...
✂️ Preparing repo...
📦 Installing packages...🎉 All done!
cd ./bar
npm startCheck out the docs: https://stenciljs.com/pwa/
shawn@shawn /run/shm $ cd ./bar
shawn@shawn /run/shm/bar $ npm start@stencil/[email protected] start /dev/shm/bar
npm run dev@stencil/[email protected] dev /dev/shm/bar
sd concurrent "stencil build --dev --watch" "stencil-dev-server"sh: 1: sd: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! @stencil/[email protected] dev:sd concurrent "stencil build --dev --watch" "stencil-dev-server"
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the @stencil/[email protected] dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.npm ERR! A complete log of this run can be found in:
npm ERR! /home/shawn/.npm/_logs/2018-06-15T18_16_40_030Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @stencil/[email protected] start:npm run dev
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @stencil/[email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.npm ERR! A complete log of this run can be found in:
npm ERR! /home/shawn/.npm/_logs/2018-06-15T18_16_40_040Z-debug.log
Other information:
there is no 'sd' command built in nor listed as a npm dependency. I'm running Linux Mint 18.3
Note that I started this with npm init stencil, selecting the PWA option, which completed without error.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
@stencil/[email protected]
I'm submitting a ... (check one with "x")
[X ] bug report
Current behavior:
After fresh setup, if you switch the version of ionic core in package.json to the latest like so:
"dependencies": {
"@ionic/core": "4.0.0-alpha.4",
"@stencil/core": "0.8.0"
},
You get a bad build with errors reporting no ToastController exported. There is a remaining reference to ToastController that needs to be changed to:
@Prop({ connect: 'ion-toast-controller' }) toastCtrl: HTMLIonToastControllerElement;
...which fixes the build.
It's either in my-app or app-profile; can't remember.
I can use stencil with ngrx?, to manage the status of my app
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
C:\ae\adaept.com\aepwa>npm list @stencil/core
@stencil/[email protected] C:\ae\adaept.com\aepwa
`-- @stencil/[email protected]
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:
Expected behavior:
No errors
Steps to reproduce:
Latest version
Related code:
Other information:
https://aepwa-dev.firebaseapp.com/
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.