Comments (3)
Looking here:
if (isset($item->task_id)) {
$this->xrechnung->setDocumentPositionQuantity($item->quantity, "HUR");
} else {
$this->xrechnung->setDocumentPositionQuantity($item->quantity, "H87");
}
Perhaps instead of checking if task_id is set, we can use type_id
'1' == product
'2' == service
I think this would work better than relying on task, also, i believe isset($task_id) will always return true.
@ddomhoff thanks for raising these points. We've been discussing how we can handle e-invoices better. I believe the best solution here is to provide a mapping of Invoice Ninja fields => EInvoice fields so that users can customize the exact fields required for their purpose. It is on my list of things to do.
from invoiceninja.
Thanks for your reply and sorry for not going more into the code before submitting.
We do not use tasks/time tracking, so I guess you are right and this part is just not working as intended. But would there be a frontend representation of type_id?
from invoiceninja.
@turbo124 @ddomhoff I checked in a fix for the amount. The payment means are way more diffuclt to solve properly... Maybe @turbo124 will implement it in a future feature branch
from invoiceninja.
Related Issues (20)
- Number of pages out of sight on A4-printouts; margin-, padding-settings with no effect HOT 4
- Easy and fast switch currency while creating quota/invoice/PO HOT 4
- FR: ZUGFeRD for Invoiceninja HOT 2
- TWIG: duration-variable returns raw-data and duration_raw returns empty value HOT 1
- Add tasks to invoice from the invoice page
- Ability to enter have more address on clients (multiple delivery/shipping) HOT 1
- Missing Update Icon HOT 1
- Product's standard quantity 0 not respected in invoice creation HOT 1
- import bug (payments): "Applied" amts don't get applied (but vtd does) - after recent patch! HOT 10
- Use unique fields as a proxy for updating rather than ignoring/inserting a new record. HOT 3
- Feat request: Allow declaring my own unique identifiers (+disclaim yours) HOT 1
- select invoice design
- Trigger webhook when refund is created
- Feat request: Allow invoices to be created without item info HOT 1
- Feature Request: Creating payment should create minimal invoice info
- Summarize multiple quotes into one project and pull another quote into an existing project
- Customers+Invoices imports show false-positive success HOT 12
- Unable to view Optional Item *and* Promo Code in Payment Link HOT 2
- Meta: For bug reports, add comments for WinStore app logs location
- [Feature Request] deactivating some coutries if it not neccesary
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from invoiceninja.