Invenio-Memento

Invenio module makes your site Memento compliant.

This is an experimental developer preview release.

Free software: GPLv2 license
Documentation: https://pythonhosted.org/invenio-memento/

invenio-memento's People

Contributors

Stargazers

Watchers

invenio-memento's Issues

Entry point initialization for invenio_memento.view:blueprint

Trying to run a cli command for invenio memento gave me this:

Traceback (most recent call last):
  File "/Users/dinossimpson/.environments/ils2/bin/invenio", line 11, in <module>
    sys.exit(cli())
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/flask/cli.py", line 374, in main
    return AppGroup.main(self, *args, **kwargs)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/click/core.py", line 1061, in invoke
    cmd_name, cmd, args = self.resolve_command(ctx, args)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/click/core.py", line 1100, in resolve_command
    cmd = self.get_command(ctx, cmd_name)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/flask/cli.py", line 345, in get_command
    rv = info.load_app().cli.get_command(ctx, name)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/flask/cli.py", line 223, in load_app
    rv = self.create_app(self)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/invenio_base/app.py", line 159, in create_cli_app
    app = create_app(debug=get_debug_flag())
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/invenio_base/app.py", line 127, in _create_app
    modules=blueprints,
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/invenio_base/app.py", line 193, in blueprint_loader
    ), entry_points=entry_points, modules=modules)
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/invenio_base/app.py", line 230, in _loader
    init_func(ep.load())
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2302, in load
    return self.resolve()
  File "/Users/dinossimpson/.environments/ils2/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2308, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'invenio_memento.view'

Possibly a typo, fixed in #19

global: removal of Flask-CLI

tests: addition of test_example_app.py

The package contains examples/app.py example application, but there is no test
for it in tests/test_example_app.py. It should be added. See existing examples:

tests: simplify doctest execution

The following cookiecutter change:

inveniosoftware/cookiecutter-invenio-module#98

should be propagated to this Invenio module.

Namely, in run-tests.sh, the sphinx for doctests is invoked after pytest run:

$ tail -3 ./\{\{\ cookiecutter.project_shortname\ \}\}/run-tests.sh
sphinx-build -qnNW docs docs/_build/html && python setup.py test && sphinx-build -qnNW -b doctest docs docs/_build/doctest

This sometimes led to problems on Travis CI with the second sphinx-build run due
to "disappearing" dependencies after the example application was tested.

A solution that worked for invenio-marc21 (see
inveniosoftware/invenio-marc21#49 (comment))
and that was integrated in cookiecutter (see
inveniosoftware/cookiecutter-invenio-module#98) was to
run doctest execution in pytest, removing the second sphinx-build invocation.

This both solved Travis CI build failures and simplified test suite execution.

Note that this change may necessitate to amend the code tests etc so that things
would be executed with the Flask application context (see
inveniosoftware/invenio-marc21@09e98fc).

Recommend Projects