intuit / common-xtext-expression-language Goto Github PK

Is your feature request related to a problem? Please describe.

dateFormat and addToDate function does not validate the dateFormat supplied as input to the function and accepts any String.

Describe the solution you'd like

Restrict access to only valid dateFormats supported by SimpleDateFormat. The validation should be compile-time rather than at runtime.

Additional context

See Xtext Validations for pointers. You will either need to change the grammar or add custom validation.

Is your feature request related to a problem? Please describe.

The sort function does not support sorting primitive arrays like below
sort(["foo", "bar", "foobar"])

Describe the solution you'd like
Support the example above

Is your feature request related to a problem? Please describe.

The filter function does not support filtering primitive arrays like below
filter(["foo", "bar", "foobar"], length(it)==3)

This is mainly because it does not support the it reference

Describe the solution you'd like

Add support for it operator in filter function, so that it supports primitive array

Is your feature request related to a problem? Please describe.

Given 2 dates, the function should return the difference in days/weeks/months/years

Describe the solution you'd like

Given 2 dates in a given format, I should be able to get the difference in either DAYS/WEEKS/MONTHS/YEAR.
Syntax: dateDifference(input1, input2, format, chronoUnit)

ChronoUnit values:
DAYS
WEEKS
MONTHS
YEARS

Formats it should support:
MM/dd/yyyy
yyyyMMdd
yyyy-MM-dd

Open to other suggestions for syntax

Is your feature request related to a problem? Please describe.

The feature should provide the dayOfWeek for a given date

Describe the solution you'd like

Given a date (not the timestamp part), the feature should provide the day of the week -> dayOfWeek(input, format)
Open to other suggestions for the syntax
Format:
MM/dd/yyyy
yyyyMMdd
yyyy-MM-dd

Is your feature request related to a problem? Please describe.

There are no tests to make sure the grammar is correct.

Describe the solution you'd like

Add sufficient tests to validate the grammar. You can add the parsing tests to the com.intuit.dsl.expression.tests project

Sample test

Additional Context
[Xtext Unit testing] (https://www.eclipse.org/Xtext/documentation/303_runtime_concepts.html#testing)

Is your feature request related to a problem? Please describe.

The filter function does not support filtering primitive arrays like below
remove(["foo", "bar", "foobar"], length(it)==3)

This is mainly because it does not support it reference

Describe the solution you'd like

Add support for it operator in remove function, so that it supports a primitive array

Is your feature request related to a problem? Please describe.

Code coverage is low because of insufficient tests

Describe the solution you'd like

Add tests to bring the coverage up.

Additional context

Tests are written in spock groovy framework.

Is your feature request related to a problem? Please describe.
I have an array of objects like below

[ 
  {...},
  {...}
  ...
]

I want to map it to a new array like below

[
  { "someKey" : {...} },
  { "someKey" : {...} },
  ...
]

It is not possible to perform such a transformation using the map method.

Describe the solution you'd like

Below is an example of pickFIrst function usage.

pickFirst(a,b,c -> it != null)

It already has a concept of it reference, which is a self-reference to the current object while iterating over a,b and c.

We can apply this concept to the map function so that the above transformation can be achieved by

map(myArray -> {
  someKey = it
 })

Describe alternatives you've considered
None of the supported functions support this usecase

Additional context