instructure-react / react-tokeninput Goto Github PK

Key 188 is letter "Б" of the Russian alphabet, and using it in "inputKeydownMap" in "combobox.js" makes it difficult to enter text

 inputKeydownMap: {
    8: 'removeLastToken', // delete
    13: 'selectOnEnter', // enter
    188: 'selectOnEnter', // comma
    27: 'hideOnEscape', // escape
    38: 'focusPrevious', // up arrow
    40: 'focusNext' // down arrow
  },

Please change this.isOpen to this.state.isOpen in componentWillReceiveProps of combobox.js,

Its hiding the list on re-rendering of component.

when we type name which doesn't exist in list (names.js) and then click outside the TokenInput box any where on screen then that typed content becomes selected one.
please fix it up

Build a webpack bundle that doesn't include names.js

That creates a lot of noise and most of that could will not be used anyway.

As reported by accessibility testing:

The “close button” text should be changed to “Delete “tag name” tag”. Leave off the “button” text,
because it has a role of button already. [For tag named "Code"], the text would be
changed to "Delete Code tag".

Unable to use this module post npm install.. had a look at your example in the repo but its difficult to get it right.

Could you please update the readMe so that anyone installing this module on their project knows how to quickly get this awesome component up and running ?

Hey guys. Excellent widget! Handles a lot of cases and saved me a lot of time. Any chance you could add a prop to have the X button be on the left of the token rather than the right?

In option.js there's a use of React.createClass, using your package gives this warning -

Warning: exports: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Perhaps break the list into multiple lines when it becomes too long?

When we use multiple TokenInput one below the another.
Then options suggested of above list is coming background of second TokenInput.

Is it possible to set a placeholderText for the input field ?