Giter Club home page Giter Club logo

lsst's Introduction

LSST

Large Synoptic Survey Telescope control interface

To run in Docker:

Run without Docker:

lsst's People

Contributors

aibsen avatar floumicaza avatar jgalazm avatar spereirag avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

lsst-ts

lsst's Issues

Readme install instructions don't work

As in issues #9 and #10, installation (in my computer) for the "run without docker" section should be

Not sure if both npm install steps are necessary though

Charts crashes when changing from playback to live mode

It happens after a while. This is the traceback of the error, there is an issue with "timeLine.setExtent" calling "charts.setSelection" since timeLine performs setState and setExtent is called in componentDidUpdate, which generates an infiniteloop..
I'm rolling back to when it worked and starting a new branch from there: e0c3605 to charts-refactor2

The problem appears here: 793cae6

and this is the traceback:

image

"Run without docker" fails: Can't resolve prop-types

After running npm start in the LSST-app directory I get two Failed to compile: ... Module not found: Can't resolve 'prop-types' errors

The console output is the following:

(virtualenv) jose@jose-samsung:/media/jose/Docs/github/LSST/LSST-app$ npm start

> [email protected] start /media/jose/Docs/github/LSST/LSST-app
> concurrently "cd ../LSST-server && python3 server.py" "npm-run-all -p watch-css start-js"

[1] 
[1] > [email protected] start-js /media/jose/Docs/github/LSST/LSST-app
[1] > react-scripts start
[1] 
[1] 
[1] > [email protected] watch-css /media/jose/Docs/github/LSST/LSST-app
[1] > npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive
[1] 
[1] 
[1] > [email protected] build-css /media/jose/Docs/github/LSST/LSST-app
[1] > node-sass-chokidar src/ -o src/
[1] 
[1] Rendering Complete, saving .css file...
[1] Wrote CSS to /media/jose/Docs/github/LSST/LSST-app/src/components/SurveyControls/PlayerControls/PlayerControlsLib.css
[1] Wrote 1 CSS files to /media/jose/Docs/github/LSST/LSST-app/src/
[1] [HPM] Proxy created: function (pathname) {
[1]         return mayProxy(pathname) && pathname.match(context);
[1]       }  ->  http://localhost:5000
[1] [HPM] Proxy created: function (pathname) {
[1]         return mayProxy(pathname) && pathname.match(context);
[1]       }  ->  http://localhost:5000
[1] [HPM] Proxy rewrite rule created: "/backend*" ~> "/"
[1] Starting the development server...
[1] 
[1] Failed to compile.
[1] 
[1] ./~/react-load-script/lib/index.js
[1] Module not found: Can't resolve 'prop-types' in '/media/jose/Docs/github/LSST/LSST-app/node_modules/react-load-script/lib'
[1] Compiling...
[1] Failed to compile.
[1] 
[1] ./~/react-load-script/lib/index.js
[1] Module not found: Can't resolve 'prop-types' in '/media/jose/Docs/github/LSST/LSST-app/node_modules/react-load-script/lib'

Error when installing d3-celestial

When running npm install on the d3-celestial folder I'm getting this error (at the end)

Here other people reported the same issue
nodejs/node-gyp#809

I deleted node-modules and~./node-gyp and restarted but did not work.

Finally the solution that worked for me was deleting the node-modules folder and running

    sudo ln -s `which nodejs` /usr/bin/node
    sudo npm install

Then, if I delete node-modules and run npm install I get the same error, but if instead I use sudo npm install I don't.

The error:

jose@jose-samsung:/media/jose/Docs/github/LSST/d3-celestial$ npm install

> [email protected] install /media/jose/Docs/github/LSST/d3-celestial/node_modules/contextify
> node-gyp rebuild

make: Entering directory '/media/jose/Docs/github/LSST/d3-celestial/node_modules/contextify/build'
  CXX(target) Release/obj.target/contextify/src/contextify.o
../src/contextify.cc: In static member function ‘static v8::Local<v8::Context> ContextWrap::createV8Context(v8::Local<v8::Object>)’:
../src/contextify.cc:131:68: warning: ‘v8::Local<v8::Object> v8::Function::NewInstance() const’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         Local<Object> wrapper = Nan::New(constructor)->NewInstance();
                                                                    ^
In file included from /home/jose/.node-gyp/8.2.1/include/node/v8.h:26:0,
                 from /home/jose/.node-gyp/8.2.1/include/node/node.h:63,
                 from ../src/contextify.cc:1:
/home/jose/.node-gyp/8.2.1/include/node/v8.h:3674:52: note: declared here
   V8_DEPRECATED("Use maybe version", Local<Object> NewInstance() const);
                                                    ^
/home/jose/.node-gyp/8.2.1/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/contextify.cc:150:16: error: ‘class v8::ObjectTemplate’ has no member named ‘SetAccessCheckCallbacks’
         otmpl->SetAccessCheckCallbacks(GlobalPropertyNamedAccessCheck,
                ^
../src/contextify.cc: In static member function ‘static void ContextWrap::GlobalPropertyGetter(v8::Local<v8::String>, const Nan::PropertyCallbackInfo<v8::Value>&)’:
../src/contextify.cc:182:80: warning: ‘v8::Local<v8::Value> v8::Object::GetRealNamedProperty(v8::Local<v8::String>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         Local<Value> rv = Nan::New(ctx->sandbox)->GetRealNamedProperty(property);
                                                                                ^
In file included from /home/jose/.node-gyp/8.2.1/include/node/v8.h:26:0,
                 from /home/jose/.node-gyp/8.2.1/include/node/node.h:63,
                 from ../src/contextify.cc:1:
/home/jose/.node-gyp/8.2.1/include/node/v8.h:3228:30: note: declared here
                 Local<Value> GetRealNamedProperty(Local<String> key));
                              ^
/home/jose/.node-gyp/8.2.1/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/contextify.cc: In static member function ‘static void ContextWrap::GlobalPropertyQuery(v8::Local<v8::String>, const Nan::PropertyCallbackInfo<v8::Integer>&)’:
../src/contextify.cc:209:67: warning: ‘v8::Local<v8::Value> v8::Object::GetRealNamedProperty(v8::Local<v8::String>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
         if (!Nan::New(ctx->sandbox)->GetRealNamedProperty(property).IsEmpty() ||
                                                                   ^
In file included from /home/jose/.node-gyp/8.2.1/include/node/v8.h:26:0,
                 from /home/jose/.node-gyp/8.2.1/include/node/node.h:63,
                 from ../src/contextify.cc:1:
/home/jose/.node-gyp/8.2.1/include/node/v8.h:3228:30: note: declared here
                 Local<Value> GetRealNamedProperty(Local<String> key));
                              ^
/home/jose/.node-gyp/8.2.1/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/contextify.cc:210:71: warning: ‘v8::Local<v8::Value> v8::Object::GetRealNamedProperty(v8::Local<v8::String>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
             !Nan::New(ctx->proxyGlobal)->GetRealNamedProperty(property).IsEmpty()) {
                                                                       ^
In file included from /home/jose/.node-gyp/8.2.1/include/node/v8.h:26:0,
                 from /home/jose/.node-gyp/8.2.1/include/node/node.h:63,
                 from ../src/contextify.cc:1:
/home/jose/.node-gyp/8.2.1/include/node/v8.h:3228:30: note: declared here
                 Local<Value> GetRealNamedProperty(Local<String> key));
                              ^
/home/jose/.node-gyp/8.2.1/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
contextify.target.mk:95: recipe for target 'Release/obj.target/contextify/src/contextify.o' failed
make: *** [Release/obj.target/contextify/src/contextify.o] Error 1
make: Leaving directory '/media/jose/Docs/github/LSST/d3-celestial/node_modules/contextify/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/jose/.nvm/versions/node/v8.2.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:125:13)
gyp ERR! stack     at ChildProcess.emit (events.js:213:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.4.0-104-generic
gyp ERR! command "/home/jose/.nvm/versions/node/v8.2.1/bin/node" "/home/jose/.nvm/versions/node/v8.2.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js""rebuild"
gyp ERR! cwd /media/jose/Docs/github/LSST/d3-celestial/node_modules/contextify
gyp ERR! node -v v8.2.1
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN [email protected] license should be a valid SPDX license expression

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jose/.npm/_logs/2018-01-08T19_58_33_508Z-debug.log

Using too many ref's is not good practice

See Survey render method for example. The problem is that the code gets hard to mantain and test.

The solution consists (normally), as stated in the docs, on lifting-up and using render callbacks. For example, Survey (parent) should store States (e.g. Data) that are used by (1) childs who need them as input (e.g., MainSkymap or MiniSkymaps): this is the lift up; and (2) childs who modify these values through user interactions (e.g. SurveyControls): these need the render callbacks.

"Run without docker" fails: mysql_config not found

When running pip3 install -r LSST-server/requirements.txt I get a "mysql_config not found" error.

Console output:

Collecting mysqlclient==1.3.12 (from -r LSST-server/requirements.txt (line 19))
  Downloading mysqlclient-1.3.12.tar.gz (89kB)
    100% |████████████████████████████████| 92kB 1.1MB/s 
    Complete output from command python setup.py egg_info:
    /bin/sh: 1: mysql_config: not found
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-ljj5d7vr/mysqlclient/setup.py", line 17, in <module>
        metadata, options = get_config()
      File "/tmp/pip-build-ljj5d7vr/mysqlclient/setup_posix.py", line 44, in get_config
        libs = mysql_config("libs_r")
      File "/tmp/pip-build-ljj5d7vr/mysqlclient/setup_posix.py", line 26, in mysql_config
        raise EnvironmentError("%s not found" % (mysql_config.path,))
    OSError: mysql_config not found
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-ljj5d7vr/mysqlclient/

The solution that worked for me was to install on Ubuntu
sudo apt-get install libmysqlclient-dev
according to this SO post: https://stackoverflow.com/questions/5178292/pip-install-mysql-python-fails-with-environmenterror-mysql-config-not-found

Maybe it is just something weird on my computer, but I prefer to leave it here for the records.

There is some tests missing.

The following components don't have tests yet :

  • CableWraps
  • Charts
  • Dome → DomePerspectives → Front View, Louvers, SideView
  • HistogramD3
  • Misc
  • Scatterplot
  • ServerAlerts
  • SkyMap has a problem with the celestial connection because it's asynchronous. An idea is to work with promises in the test, like how we did in survey_lifecycle.test.js for the setDataByDate test.
  • Timeline

Date formats are confusing

It is not clear when a date object is or should be in a specific format (LSST or standard JS).
This is inconvienent, and causes the need of "deep cloning" the data array (see Charts.setData) and messes with SurveyControls inputs.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.