Giter Club home page Giter Club logo

manga-tagger's Introduction

GitHub all releases GitHub issues

Manga Tagger Logo

A tool to rename and write metadata to digital manga chapters

Background and Inspiration

Where do I even start...well, I really enjoy Japanese culture, specifically anime and manga. While there is a lot of support for American comics in a digital format, the same cannot be said about manga. One day, I stumbled across Free Manga Downloader, which allowed me to start my digital manga library. However, the one pitfall of the application is the lack of capability for grabbing metadata.

Being an American comic fan, I regularly use ComicRack and Comic Tagger. While Comic Tagger works with manga, it wasn't made for manga and so it's implementation in that regard is lackluster. And thus, this project was born...

Features

  • Direct integration with Free Manga Downloader 2
  • Scrapes metadata from Anilist and MyAnimeList (using Jikan)
  • Fully automated batch processing
  • Extremely easy integration with DataDog for log monitoring
  • Multithreaded for handling multiple files at a time
  • Writes metadata in the ComicRack format (using comicinfo.xml)
  • Full support for strictly CBZ files

Support

Log issues via GitHub

Contributing

Pull requests are always welcome. For major changes, please open an issue first to discuss what you would like to change.

If you have any questions, please feel free to reach out on our GitHub Discussions.

License

MIT

manga-tagger's People

Contributors

inpacchi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

manga-tagger's Issues

Alpha-Build Installation Process?

Tested using a fresh Windows 10 VM. Installed the dependencies then ran executable. Log states that it was able to establish a database connection, however appears to crash. Could be a extension of the previous releases issue with starting the script with nssm outside of a paused state.

image

[BUG] all covers after conversion are the same.

OS: What operating system are you running Manga Tagger on?
Ubuntu server 20.04
Manga Tagger Version: What version of Manga Tagger are you running?
Latest from Docker
Description of the issue: Give a a clear and concise description of what the issue is.
The system works, but if I put chapters 1-10 in downloads. The output has set all covers to chapter 1. All files are named correctly I.e โ€œSun-Ken Rock -.- Chapter 1
Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered?
Sun-Ken Rock
Screenshots (If applicable): Add screenshots to help explain your problem.

Log File: Please make sure JSON logging is enabled and upload the JSON log file.
Nothing in logs shows any form of error

[BUG] Unable to find match, manga being moved.

image

So it makes sense this title isn't in the database, but I think to prevent the titles that do have metadata from mixing with the ones without, the manga should not be copied and deleted over. Or at least the ones that do have metadata should be distinguished somehow from those that don't, perhaps in separate folders.

Not processing any files

Manga Tagger doesn't seem to be able to parse any files, I get this error in logs

2020-12-12 15:07:52,029 | Thread-1 10756 | MangaTaggerLib.utils.SeriesHandler | DEBUG - Event Type: created
2020-12-12 15:07:52,029 | Thread-1 10756 | MangaTaggerLib.utils.SeriesHandler | DEBUG - Event Path: C:\Downloads\Temple\Chapter 001.cbz
2020-12-12 15:07:52,030 | Thread-1 10756 | MangaTaggerLib.utils.SeriesHandler | INFO - Creation event for "C:\Downloads\Temple\Chapter 001.cbz" will be added to the queue
2020-12-12 15:07:52,031 | MTT-7 16548 | MangaTaggerLib.utils.QueueWorker | INFO - Pulling "file created" event from the queue for "C:\Downloads\Temple\Chapter 001.cbz"
2020-12-12 15:07:54,042 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | INFO - Now processing "C:\Downloads\Temple\Chapter 001.cbz"...
2020-12-12 15:07:54,043 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | DEBUG - filename: Chapter 001.cbz
2020-12-12 15:07:54,043 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | DEBUG - directory_path: C:\Downloads\Temple\
2020-12-12 15:07:54,044 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | DEBUG - directory_name: Temple
2020-12-12 15:07:54,045 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | INFO - Attempting to rename "Chapter 001.cbz"...
2020-12-12 15:07:54,046 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | ERROR - Unable to parse filename "Chapter 001.cbz" due to delimiter "-.-" missing
Traceback (most recent call last):
  File "C:\Manga Tagger\MangaTaggerLib\MangaTaggerLib.py", line 139, in file_renamer
    raise UnparsableFilenameError(filename, '-.-')
MangaTaggerLib.errors.UnparsableFilenameError: Unable to parse filename "Chapter 001.cbz" due to delimiter "-.-" missing
2020-12-12 15:07:54,047 | MTT-7 16548 | MangaTaggerLib.MangaTaggerLib | WARNING - Manga Tagger was unable to process "C:\Downloads\Temple\Chapter 001.cbz"

Haven't changed any naming settings in FMD, running defaults.

Installation Issues

I have a discussion open, but figured to create this in case someone else ran into the problem.

Ok so the first go around installing everything I felt like I messed up along the way.

My first issue was not installing in C: drive because dumb me thought that somehow things were more customizable, so I had to back track and try to reinstall everything using exact settings in github.

This was my experience in my attempt to redo it all:

Trying to install MongoDB + Compass proved to be a challenge because I had some Asus programs (Armoury Crate or something) that needed to be stopped but I couldn't so the install required a restart to work properly and I didnt do that. Then I went and clicked connect instead of fill in connections individually (see below)

image

I proceeded to install NSSM and then Manga Tagger:

I noticed on step 4 of manga installer installation:
Change the two highlighted boxes as shown below
-C:
-Manga Tagger
This will create a directory C:\Manga Tagger\Manga Tagger because the zip file contains a Manga Tagger folder already. I noticed that one of the steps involves running the batch file, so this is probably changed due to the updated zipped file. I made it so then the contents of Manga Tagger folder of zip was in C:\Manga Tagger folder.

Once all was said and done I tried to use CMD admin to run nssm start manga_tagger

The error I get: "error manga_tagger: Unexpected status SERVICE_PAUSED in response to START control."

I attempted to do all of this on a separate machine following the steps to a T but run into the same isssue starting the service.

I'm positive it's something I might have missed. Please help.

[BUG] unable to move files from network attached storage

OS: Win 10

Manga Tagger Version: 1.1.5-alpha

Description of the issue: Set FMD downloads to SMB location on mac, where i have my server. mangatagger errors trying to move files from Z:/manga (NAS) to C:/library/manga

Manga Series: Ayashimon

Screenshots (If applicable):
image

Log File: Please make sure JSON logging is enabled and upload the JSON log file.
MangaTagger.log

help senpi

just installed it,
I move a folder with a ".cbz" in this case its folder name "Dad Is A Hero, Mom Is A Spirit, I'm A Reincarnator" and the file name is "Chapter 001.cbz" and then get this error

[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 01-envfile: executing...
[cont-init.d] 01-envfile: exited 0.
[cont-init.d] 10-adduser: executing...


      _         ()
     | |  ___   _    __
     | | / __| | |  /  \ 
     | | \__ \ | | | () |
     |_| |___/ |_|  \__/

Brought to you by linuxserver.io

To support LSIO projects visit:
https://www.linuxserver.io/donate/

GID/UID

User uid: 99
User gid: 100

[cont-init.d] 10-adduser: exited 0.
[cont-init.d] 30-config: executing...
[cont-init.d] 30-config: exited 0.
[cont-init.d] 99-custom-files: executing...
[custom-init] no custom files found exiting...
[cont-init.d] 99-custom-files: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
2022-04-13 00:30:42,150 | MainThread 23424126647112 | MangaTaggerLib.database.Database | INFO - Establishing database connection...
2022-04-13 00:30:42,152 | MainThread 23424126647112 | MangaTaggerLib.database.Database | INFO - Database connection established!
2022-04-13 00:30:42,152 | MainThread 23424126647112 | MangaTaggerLib.utils.AppSettings | INFO - Download directory has been set as "/downloads"
2022-04-13 00:30:42,153 | MainThread 23424126647112 | MangaTaggerLib.database.ProcSeriesTable | INFO - Loading processed series...
2022-04-13 00:30:42,168 | MainThread 23424126647112 | MangaTaggerLib.database.TaskQueueTable | INFO - Loading task queue...
2022-04-13 00:30:42,171 | MainThread 23424126647112 | MangaTaggerLib.database.TaskQueueTable | INFO - Attempting to delete all records in the database...
2022-04-13 00:30:42,174 | MainThread 23424126647112 | MangaTaggerLib.database.TaskQueueTable | INFO - Deletion was successful!
2022-04-13 00:30:42,175 | MainThread 23424126647112 | MangaTaggerLib.MangaTaggerLib | INFO - Starting Manga Tagger - Version 1.2.3-alpha
2022-04-13 00:30:42,176 | MainThread 23424126647112 | MangaTaggerLib.task_queue.QueueWorker | INFO - Watching "/downloads" for new downloads
2022-04-13 00:32:01,124 | Thread-1 23423902681912 | MangaTaggerLib.task_queue.SeriesHandler | INFO - Creation event for "/downloads/Dad Is A Hero, Mom Is A Spirit, I'm A Reincarnator/Chapter 001.cbz" will be added to the queue
2022-04-13 00:32:01,253 | MTT-1 23423906134840 | MangaTaggerLib.task_queue.QueueWorker | INFO - Pulling "file created" event from the queue for "/downloads/Dad Is A Hero, Mom Is A Spirit, I'm A Reincarnator/Chapter 001.cbz"
2022-04-13 00:32:02,269 | MTT-1 23423906134840 | MangaTaggerLib.MangaTaggerLib | INFO - Now processing "/downloads/Dad Is A Hero, Mom Is A Spirit, I'm A Reincarnator/Chapter 001.cbz"...
2022-04-13 00:32:02,270 | MTT-1 23423906134840 | MangaTaggerLib.MangaTaggerLib | INFO - Attempting to rename "Chapter 001.cbz"...
2022-04-13 00:32:02,270 | MTT-1 23423906134840 | MangaTaggerLib.MangaTaggerLib | ERROR - Unable to parse filename "Chapter 001.cbz" due to delimiter "-.-" missing
Traceback (most recent call last):
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 85, in filename_parser
raise UnparsableFilenameError(filename, '-.-')
MangaTaggerLib.errors.UnparsableFilenameError: Unable to parse filename "Chapter 001.cbz" due to delimiter "-.-" missing
2022-04-13 00:32:02,271 | MTT-1 23423906134840 | MangaTaggerLib.task_queue.QueueWorker | ERROR - 'NoneType' object is not subscriptable
Traceback (most recent call last):
File "/app/Manga-Tagger/MangaTaggerLib/task_queue.py", line 188, in process
MangaTaggerLib.process_manga_chapter(path, uuid.uuid1())
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 68, in process_manga_chapter
metadata_tagger(file_path, manga_details[0], manga_details[1], manga_details[2], logging_info)
TypeError: 'NoneType' object is not subscriptable
2022-04-13 00:32:02,271 | MTT-1 23423906134840 | MangaTaggerLib.task_queue.QueueWorker | WARNING - Manga Tagger is unfamiliar with this error. Please log an issue for investigation.

Doesn't run/missing file

The run.bat is calling a 'MangaTagger.py' which isn't present in the source. Don't see any install.bat either to install it with NSSM.

[BUG] "'NoneType' object is not subscriptable"

OS: What operating system are you running Manga Tagger on?
Docker on Linux

Manga Tagger Version: What version of Manga Tagger are you running?
latest and nightly from https://hub.docker.com/r/banhcanh/manga-tagger

Description of the issue: Give a a clear and concise description of what the issue is.
files dropped from fmd2 into the input folder are recognized and formatted correctly. Manga Tagger renames them then displays this message:

2024-05-09 17:15:39,410 | Thread-1 140234709678904 | MangaTaggerLib.task_queue.SeriesHandler | INFO - Moved event for "/downloads/Berserk/Vol. 03 Ch. 000.06 - The Guardians of Desire (4) (LQ).cbz" will be added to the queue

After that nothing happens. Hours go by and the file is never tagged, and never moved to the destination folder.
If I restart it sees the renamed files on the restart and indicastes the format is wrong, but it is in the format that Manga Tagger renamed it to, so not sure why it doesn't recognize the file it created, but maybe that is part of the problem.

2024-05-09 17:25:45,361 | MTT-6 139665536940856 | MangaTaggerLib.MangaTaggerLib | ERROR - Unable to parse filename "Vol. 01 Ch. 000.03 - The Guardians of Desire (1).cbz" due to delimiter "-.-" missing
Traceback (most recent call last):
  File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 86, in filename_parser
    raise UnparsableFilenameError(filename, '-.-')
MangaTaggerLib.errors.UnparsableFilenameError: Unable to parse filename "Vol. 01 Ch. 000.03 - The Guardians of Desire (1).cbz" due to delimiter "-.-" missing
2024-05-09 17:25:45,362 | MTT-7 139665535847224 | MangaTaggerLib.task_queue.QueueWorker | ERROR - 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/app/Manga-Tagger/MangaTaggerLib/task_queue.py", line 189, in process
    MangaTaggerLib.process_manga_chapter(path, uuid.uuid1())
  File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 68, in process_manga_chapter
    metadata_tagger(file_path, manga_details[0], manga_details[1], manga_details[2], logging_info, manga_details[3])
TypeError: 'NoneType' object is not subscriptable
2024-05-09 17:25:45,363 | MTT-1 139665542245176 | MangaTaggerLib.task_queue.QueueWorker | WARNING - Manga Tagger is unfamiliar with this error. Please log an issue for investigation.

Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered?
Berserk for my test, popular series I figured it would be easy to tag.

Screenshots (If applicable): Add screenshots to help explain your problem.
N/A

Log File: Please make sure JSON logging is enabled and upload the JSON log file.
MangaTagger.json

CLI functions

Add CLI functions to use Manga Tagger from the command line

Is it possible to run stand alone?

Just a quick question is possible to run this easily without FMD? Because personally i use a different downloader that actually creates a ComicInfo.xml when it downloads manga (https://doujindownloader.com/ is the app i use). However some of the sites where i source manga from have pretty crappy data compared to that from MAL or AniList, so it would be nice to be able to upgrade the quality of some of my metadata.

However it appears on quick glance that this requires you to use FMD.

Installing exe file

Is there a special way to install everything? I'm opening the exe file and it only comes up with a blank window.

EDIT: Alright, found out you needed to open it in the Manga Tagger folder in C drive. And that to have it start monitoring for new installs, it seems like that executable needs to be open for when the items are downloaded.

Found an issue where I suppose the manga isn't searchable if the name from the source is exact..
image

I'm also getting the errors as with a manga titled exactly as it should be:

image

Everything should be installed since your last settings/config instructions.

[Feature] Downloading Cover Art

Wasn't sure where I could put this, so I will just add this here. Going along with the Komga metadata thing, I found some projects that may be helpful as reference with pulling cover art compatible with Komga at the same time as the metadata.
https://github.com/notdedsec/anicon
https://github.com/Omar-AbdulAzeez/Meine-Manicon/
https://github.com/NicholasDawson/Data-Extractor-for-AniList
At least the first couple are using the Jikan API, but seem to be converting the images to a different form. The third works for Anilist but I am not sure if the dependencies are the same. Since Komga now will pull metadata from the first .cbz for series, all that would be needed is to pull the cover art and a fully automated and pretty solution is within reach. Thank you for all your hard work!

Originally posted by @Ablex222 in #14 (comment)

[BUG] v1.1.2-alpha Fails to Start

OS: What operating system are you running Manga Tagger on?
Windows 10
Manga Tagger Version: What version of Manga Tagger are you running?
v1.1.2-alpha
Description of the issue: Give a a clear and concise description of what the issue is.
Starting new version once selecting FMD folder proceeds to crash and give error.
Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered?

Screenshots (If applicable): Add screenshots to help explain your problem.
image

Log File: Please make sure JSON logging is enabled and upload the JSON log file.

file_renamer fails to parse chapter_number correctly when there is a whitespace in chapter_title

Manga Tagger Version: v1.0.3 973fd1e
Description of the issue: file_renamer fails to parse chapter_number correctly when there is a whitespace in chapter_title, I've come across a handful of series where the name looks something like "ch. 001".

Detailed findings: found that the culprit was inside the while loop that creates the chapter_number variable, if it encounters a whitespace it breaks out and you end up with "000" as your parsed chapter_number.

My dirty workaround was to add an else if to skip over these adding to the index to prevent it from breaking out:

    while i < len(chapter_title):
        substring = chapter_title[i]
        LOG.debug(f'substring: {substring}')

        if substring.isdigit() or substring == '.':
            chapter_number += chapter_title[i]
            i += 1

            LOG.debug(f'chapter_number: {chapter_number}')
            LOG.debug(f'Iterator i: {i}')
        elif substring == ' ':
            i += 1

            LOG.debug(f'Skipping whitespace character')
            LOG.debug(f'Iterator i: {i}')
        else:
            break

Unsure if this covers all eventualities but at least it no longer cares if there are spaces between the delimiter and chapter number.

Manga Tagger & FMD start process

Manga Tagger might not be able to start FMD if it's already been started. Also, Manga Tagger should always close FMD BEFORE doing the FMD setting initialization if FMD is open. I'm not sure if Manga Tagger does this already so this should be checked.

[QUESTION] How to update Jikan?

OS: What operating system are you running Manga Tagger on? Windows 11

Manga Tagger Version: What version of Manga Tagger are you running? Alpha Build Comprehensive v5

Description of the issue: Give a a clear and concise description of what the issue is. Manga Tagger is asking for v4 jikan

Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered? Sword Art Online: Aincrad

Screenshots (If applicable): Add screenshots to help explain your problem. https://i.postimg.cc/vm7GfYzq/image-2023-04-24-234425431.png

Log File: Please make sure JSON logging is enabled and upload the JSON log file. https://pastebin.com/TYC79KqN

[ISSUE] Tagger keeps deleting chapters when found it already processed whether they are empty or not

OS: Linux

Manga Tagger Version: Alpha

Description of the issue:
FMD first download a series of 20 chapters, manga tagger done its job!
But when I check it, 5 of 20 chapters are only 1KB/each, the problem begins here.
Let's bypass the possibility of early tagging when FMD had not finished downloading but tagger does its job since I move the folder manually, the issue is when I try downloading the proper 5 chapters manually, FMD did the job well, then when I move into Manga Tagger's watch folder, it deleted all those chapters, logs showed:
2021-08-05 08:47:25,981 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | WARNING - No changes have been found for "Shiroi Majo 007.cbz"; file currently being processed will be deleted

So in the cases where FMD fails its job, how can we tell the Tagger to do it again?
I think there's no meaning in deleting old chapters when Tagger sees them inside watch folder, just do its job, people might want to use better translation or verion!

Manga Series: Shiroi Majo

Screenshots (If applicable): Only logs as above.

Log File:
Traceback (most recent call last):
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 422, in metadata_tagger
rename_action(file_path, new_file_path, series_title, manga_chapter_number, logging_info)
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 217, in rename_action
raise FileAlreadyProcessedError(current_file_path.name)
MangaTaggerLib.errors.FileAlreadyProcessedError: "Shiroi majo -.- Shiroi majo Chap 009.cbz" has already been processed by Manga Tagger; skipping
2021-08-05 08:47:24,881 | MTT-4 23078096321336 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...
2021-08-05 08:47:24,881 | MTT-4 23078096321336 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...
2021-08-05 08:47:24,882 | MTT-4 23078096321336 | MangaTaggerLib.MangaTaggerLib | INFO - Error: /downloads/Shiroi majo : Directory not empty

2021-08-05 08:47:24,956 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | INFO - Checking for current and previously processed files with filename "Shiroi Majo 006.cbz"...
2021-08-05 08:47:24,957 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | INFO - No files currently currently being processed under the filename "Shiroi Majo 006.cbz". Locking new filename for processing...
2021-08-05 08:47:24,959 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | WARNING - No changes have been found for "Shiroi Majo 006.cbz"; file currently being processed will be deleted

2021-08-05 08:47:24,961 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | ERROR - "Shiroi majo -.- Shiroi majo Chap 006.cbz" has already been processed by Manga Tagger; skipping

Traceback (most recent call last):
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 422, in metadata_tagger
rename_action(file_path, new_file_path, series_title, manga_chapter_number, logging_info)
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 217, in rename_action
raise FileAlreadyProcessedError(current_file_path.name)
MangaTaggerLib.errors.FileAlreadyProcessedError: "Shiroi majo -.- Shiroi majo Chap 006.cbz" has already been processed by Manga Tagger; skipping
2021-08-05 08:47:24,962 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...
2021-08-05 08:47:24,962 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...
2021-08-05 08:47:24,963 | MTT-5 23078095199032 | MangaTaggerLib.MangaTaggerLib | INFO - Error: /downloads/Shiroi majo : Directory not empty

2021-08-05 08:47:25,978 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | INFO - Checking for current and previously processed files with filename "Shiroi Majo 007.cbz"...
2021-08-05 08:47:25,979 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | INFO - No files currently currently being processed under the filename "Shiroi Majo 007.cbz". Locking new filename for processing...
2021-08-05 08:47:25,981 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | WARNING - No changes have been found for "Shiroi Majo 007.cbz"; file currently being processed will be deleted

2021-08-05 08:47:25,983 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | ERROR - "Shiroi majo -.- Shiroi majo Chap 007.cbz" has already been processed by Manga Tagger; skipping

Traceback (most recent call last):
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 422, in metadata_tagger
rename_action(file_path, new_file_path, series_title, manga_chapter_number, logging_info)
File "/app/Manga-Tagger/MangaTaggerLib/MangaTaggerLib.py", line 217, in rename_action
raise FileAlreadyProcessedError(current_file_path.name)
MangaTaggerLib.errors.FileAlreadyProcessedError: "Shiroi majo -.- Shiroi majo Chap 007.cbz" has already been processed by Manga Tagger; skipping
2021-08-05 08:47:25,983 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...
2021-08-05 08:47:25,984 | MTT-7 23078092954424 | MangaTaggerLib.MangaTaggerLib | INFO - Deleting /downloads/Shiroi majo...

Manga Tagger not installing correctly

Original issue

I'm getting an issue when trying to run the following in command prompt:

nssm start manga_tagger
manga_tagger: Unexpected status SERVICE_STOPPED in response to START control.
I can see the Manga Tagger as a service in Windows Services, but when trying to start it manually, I also get the following:

Services

Windows could not start the Manga Tagger on Local Computer. For more information, review the System Event Log. If this is a non-Microsoft service, contact the service vendor, and refer to service-specific error code 3.

Event Viewer says:
The Manga Tagger service terminated with the following service-specific error:

The system cannot find the path specified.

I have the "C:\Manga Tagger" directory present and nssm.exe in "C:\Windows\System32". I've repeated the steps in the guide twice now and haven't gotten any errors aside from very last part.

Resolution

install.bat line 3 does not reflect the correct location for Manga Tagger. Notice the difference in spaces below:
nssm set manga_tagger AppDirectory C:\MangaTagger when it should be nssm set manga_tagger AppDirectory C:\Manga Tagger

Issue with metadata

So this is what my comicinfo.xml looks like

<?xml version="1.0" ?>
<ComicInfo xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <!--Generated by Manga Tagger, an Endless Galaxy Studios project-->
   <Series>Temple</Series>
   <Number>001</Number>
   <Summary>Not knowing what to do with his worldly desires, Akagami Akemitsu aims to live a stoic life. However, the thick karmic blood flowing from him will not permit it! (Source: Kodansha, translated)</Summary>
   <Year>2018</Year>
   <Month>9</Month>
   <Writer>Kimitake Yoshioka</Writer>
   <Penciller>Kimitake Yoshioka</Penciller>
   <Inker>Kimitake Yoshioka</Inker>
   <Colorist>Kimitake Yoshioka</Colorist>
   <Letterer>Kimitake Yoshioka</Letterer>
   <CoverArtist>Kimitake Yoshioka</CoverArtist>
   <Publisher>Comic Days</Publisher>
   <Genre>Comedy,Ecchi,Romance,Harem,Slice of Life</Genre>
   <Web>https://myanimelist.net/manga/120643/Temple</Web>
   <LanguageISO>en</LanguageISO>
   <Manga>Yes</Manga>
   <Notes>Scraped metadata from AniList and MyAnimeList (using Jikan API) on 2020-12-12 09:18 PM IST</Notes>
</ComicInfo>

Everything seems fine, but it's not being read by comicrack. It looks like this
Tried using Komga as well, that's not reading anything either. Is there something wrong with how the metadata is being written or is something wrong on my end?

Processing Errors (Alpha Build)

Program now will run, rename, and create the metadata files correctly. However, it does not seem to be stable. When going from one series to another, a error is encountered and the metadata files fail to be generated. Furthermore, it seems the tagger does not seem to work with series that go by multiple names (Ex. Japanese title and English titles differ), even if there is only one possible search result.

image

On a side note, it may be useful to have a series metadata file created in the parent folder of the processed .cbz files, this way programs like Komga will show a description for the work without having to open one of the nested files.

[BUG] "error - substring not found"

OS: What operating system are you running Manga Tagger on?
Windows 10
Manga Tagger Version: What version of Manga Tagger are you running?
https://github.com/Inpacchi/Manga-Tagger/releases/tag/v1.1.5-alpha
Description of the issue: Give a a clear and concise description of what the issue is.
It keeps failing with an "error - substring not found" error in the logs,
but not graphical error notice.
Manga Series: What manga series (singular or plural) were being tagged when the issue was encountered?
Happens with everything, last one tried was "The Galactic Navy Officer Becomes An Adventurer"
Screenshots (If applicable): Add screenshots to help explain your problem.
No error popups
Log File: Please make sure JSON logging is enabled and upload the JSON log file
Had to rename it before uploading since .json isn't accepted for direct upload by GitHub
MangaTagger.json.txt
This is the log file I setup through NSSM
manga_tager.log
.

Internationalize the user interface.

It'd be nice of people if people that prefer a language other than English were accommodated right?
I intend to make a pull request in the future that localizes the interface using babel. Localizing the dates and stuff and stuff in the metadata should also be considered, but maybe another should be created for that?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.