inigmatus / gap Goto Github PK

check that players crew as well as passengers, are recovered.
check that player's vessel is not destroyed

jrossignol/ContractConfigurator#351

Waiting on Nereid to hop on board this one.

Fixed in jrossignol/ContractConfigurator#373

Test this.

See: https://bubbl.us/mindmap?h=934b/5fc8d0/37aoS1/A8mNuU

Recommend leaving SSI to just offering parts, and testing parts, and STS spacecraft.

Recommend making Wright Aeronautical the agency responsible for FirstFlight (makes more sense historically).

This also includes updating all dependencies to the correct files

This also includes adding dependencies that don't exist yet, but commenting them out until they do.

requires mk1 crew cabin availability, but not required for craft.

Update asset:

Save fishing vessel with light on for night missions.

Also update the text to remove verbiage to use/spawn it to catch kerbals. Confusing. Also confirm its spawning ok, and that Kerbals and vessel are not owned or controllable.

http://forum.kerbalspaceprogram.com/index.php?/topic/124994-105dec-6-2015-contract-pack-giving-aircraft-a-purpose-gap-02-air-flights-tours-coast-guard-sts/&do=findComment&comment=2314995

Would be cool if there were some sort of airport shuttle/bus/van available to pickup passengers spawned at the Astronaut Complex for airflights and be required to load them on a plane. Would work well with an STS mission using my AstroVan II. Would need to set a VesselParameterGroup to ensure contract passed on the aircraft/STS and not on the airport shuttle/van/bus.

RecoverVessel does not work to recognize as completed if player recovers vessel in KSC View.

Bug jrossignol/ContractConfigurator#343

Work around is to load craft, and recover it.

Test loading Nightingale Kerman.
Test flying over.
Test warping over.

• Pray and hope to G-d that you find something reasonably stable.

Test future enhancement jrossignol/ContractConfigurator#149

add neg funds to contracts in exchange for parts.

KSC Coast Guard: Buoy Drop (drop three beacons in the waters off KSC) (see maritime missions for possible copy/merger)

suggestion from steve_v
http://forum.kerbalspaceprogram.com/index.php?/topic/124994-105dec-6-2015-contract-pack-giving-aircraft-a-purpose-gap-02-air-flights-tours-coast-guard-sts/&do=findComment&comment=2311666

solo barnstorm. don't want to kill any paying passengers now would we? for a prestige (reputation) only boost.

use NewKerbal()

Test jrossignol/ContractConfigurator#359

and apply fix.

Rotate Crews on KSC Island.

Mostly done, but could use a re-write to use NewKerbal() and list functions to randomize SpawnPassengers, else I actually might make this one require picking up the staff at the astronaut complex via a SpawnVessel TourBus.

Yup. This needs a flag. A nice jet aircrafty sorta flag.

jrossignol/ContractConfigurator#357

Low level priority. Could be useful when developing STS missions since many of them will have the same code.

jrossignol/ContractConfigurator#366

Test this enhancement if/when developed.

This is also the same issue as other issues raised with CC:

SpawnVessel crew not recognized by HasPassengers
Workaround: use name = RandomKerbalName(Random()) in SpawnVessel/Crew and name = @/TourBus.Kerbals().ElementAt(0) in HasPassengers - see BugTest

It means you gotta learn how to submit it!

jrossignol/ContractConfigurator#369

Test fix using latest CC dev. If confirmed fixed, delete Declassification dev.

• KSP-3: KSC Island Airfield Preparation Mission (land at KSCI with 2 Kerbals, walk one to Tower control room WP, walk the other to a hangar WP) - nearly done. test hangar waypoint, test control room waypoint.

I really want to absorb maculator's KAB into GAP.
suggestion from Schmitty21 to include mach 1 and mach 2 contracts.

I just realized I've been developing KSCI: 3 Hour Tour for 0.2 release when in fact I've been developing KSCI Flight 38 seaplane trip to 3rd island. scheduled for release in 0.6. Ha! Oh well, glad to have most of the work done. I need to rename all relevant issues to KSCI Beach Resort Getaway or whatever I decide.

add PQS to future contracts, comment lat/long.

These existing contracts need PQS commented:

Coast Guard: SOS Speedboat - commented
Island Tours: Shoreline - commented
KSC Airlines: Test Flight 10 - commented (new point entirely, test on conversion)
KSP: Islands Survey - commented

Only contracts that expect random locations need lat/long

Need to submit an enhancement to CC for this.

-Rename Group
-And also rename KSC-Air-Charters-A.cfg to KSC Airlines: Charter Flights and update group accordingly

Use random() for flight number and number of kerbals (2-6 passengers)

wasn't gonna mention this. poor Nightingale already was swamped with 1.9.0 stuff. Could be a critical bug. Needs test case and submission. Will be kind and wait to mention it to him until I have give him a tidy package.

I think it's related to the behavior changes KSP made on contract completion that was affecting kerbals not getting removed after contract completion. now vessels are not getting removed after contract completion. I tried using DestroyVessel to do the clean up, but it causes a weird bug where if the contract completes on RecoverVessel (not related to those intended to be destroyed), the recovered vessel appears near the admin building in Space Center view waiting to be recovered there, and freezes Space Center until you do so.

I like the logo. It may be too dark blue though. That or get a nice colorful standout logo with palm trees.

to be consistent with DEVNOTES.

KSC Island Tours: Submarine Tour (to -200m) (spawn debris at bottom of ocean?, WP near it required for picture taking by passengers)

Need a contract to go to a waypoint underwater. Use SpawnVessel to spawn a piece of debris from the GAP\Assets folder.

Waypoint preferably between KSC and KSC Islands.

Should be easy to create. Simply copy from IslandTours-Shoreline.cfg and modify as needed. WaypointGenerator behavior PQS node will need a negative altitude I think. Read up on the CC wiki for more info: https://github.com/jrossignol/ContractConfigurator/wiki/WaypointGenerator-Behaviour

jrossignol/ContractConfigurator#353

caused by KSP bug. Nightingale has raised issue with KSP.

a paying passenger wants to go on his first airplane ride, cheap reward.

Update contracts with variable SpawnKerbals: Coast Guard, and Charters

IslandTours-Flight-38 - KSC Island Tours: Seaplane Tour: Flight 38 - Seats: (4-8)
return to KSC 2-4 Kerbals as optional completion & bonus

CoastGuard-RescuePilot - KSC Coast Guard: Mayday: Rescue (PilotName)
1-3 pilots/air crew

CoastGuard-RescueFishermen - KSC Coast Guard: S.O.S. Reported: @/shipName
2-6 crew

CoastGuard-RescueClimbers - KSC Coast Guard: Medevac: Rescue climbers on K2
1-3 climbers

*Airlines-Flight-20 - KSC Airlines: Charter Flight 20 - Seats: 4-8
2-4

*Airlines-Flight-40 - KSC Airlines: Charter Flight 40 - Seats: 2-8 (for science)
2-4

RELEASE CHECKLIST:

• Proofread Mindmap: is progression logical and does it make sense?
• Confirm all contract titles match DEVNOTES, Mindmap, CHANGELOG, Balance Sheet
• Balance rewards, penalties, and weights: https://docs.google.com/spreadsheets/d/1vmZkfWamAaeuTsKL1_yes4l-eoMTrmJZ9zvgp3NkjaM/edit?pref=2&pli=1#gid=0
• Proofread all contract requirements for required contracts and required parts
• Uncomment dependencies
• Set GAP version name in Groups.cfg
• Set minimum CC version in Groups.cfg
• Set GAP version name in Strategia.cfg
• Update README
• Create new PDF version of Mindmap
• Fly all missions stock
• Fly all missions with Command Seat (Take Command mod)
• Test random generator limits
• Update CHANGELOG with release date

-Final GitHub upload

• Set GAP version name in AVC's GAP.version file but don't upload it to GitHub yet
• Do not include any AVC xml files! You must only include the dll and GAP.version else CKAN will break.
• Release to GitHub, KerbalStuff, and forum thread

-GitHub upload AVC

Update all Contracts to Development/NewContract code format

disableOnStateChange in the Not param, with a HasPassengers child was not disabling on state change until I used lowercase false.