Giter Club home page Giter Club logo

Comments (7)

saiprasannasastry avatar saiprasannasastry commented on July 28, 2024

Hi, can you please address the comments on the PR

from infoblox-go-client.

dhawal55 avatar dhawal55 commented on July 28, 2024

Why are these attributes hard-coded in code?

infoblox-go-client/object_manager.go

Lines 63 to 69 in 6e85b72

func (objMgr *ObjectManager) getBasicEA(cloudAPIOwned Bool) EA {
ea := make(EA)
ea["Cloud API Owned"] = cloudAPIOwned
ea["CMP Type"] = objMgr.cmpType
ea["Tenant ID"] = objMgr.tenantID
return ea
}

The go-client should allow users to set the required attributes instead of the ones in the code above

from infoblox-go-client.

somashekhar avatar somashekhar commented on July 28, 2024

These are the default EAs we get once CNA license is being installed and used. So we have made sure to get them in this method, so that subsequent methods can use them.

from infoblox-go-client.

dhawal55 avatar dhawal55 commented on July 28, 2024

Thank you @somashekhar. Is the CNA license required in order to use this library?

from infoblox-go-client.

somashekhar avatar somashekhar commented on July 28, 2024

If you don't have CNA then you should add these EAs manually and get library working.

from infoblox-go-client.

dhawal55 avatar dhawal55 commented on July 28, 2024

from infoblox-go-client.

somashekhar avatar somashekhar commented on July 28, 2024

Agree. That would be a better solution. Do make sure nothing breaks and also add respective UTs.
@AvRajath can you once confirm this proposal does not break anything in our existing Terraform plugin.

from infoblox-go-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.