Giter Club home page Giter Club logo

Comments (1)

rhossili avatar rhossili commented on July 28, 2024

@claytonpeters

IMO, there are two separate issues here.

  1. Totally agree that there should be a check for error returned by BuildRequest before calling SendRequest here.

  2. The above won't address the example case of an invalid Host attribute. As you suggested, this can be addressed by validating HostConfig in Init. In addition, I noticed that there's a call to ValidateConnector here that is supposed to perform a validation by actually making a connection. However, the implementation has been commented out (see https://github.com/infobloxopen/infoblox-go-client/blob/master/connector.go#L378-L384). Perhaps we can resurrect that?

from infoblox-go-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.