For example Track, Album, and Artist. I'm using the library for a music project and it just makes it harder to work with different classes of the same name.

I suggest refactoring them to be FmTrack, FmArtist and FmAlbum. You can easily distinguish the purpose of the object using that simple prefix.

Issue to track remaining tag methods

• tag.getInfo
• tag.getSimilar
• tag.getTopAlbums
• tag.getTopArtists
• tag.getTopTags
• tag.getTopTracks
• tag.getWeeklyArtistChart
• tag.getWeeklyChartList
• tag.search
• track.addTags
• track.getTags
• track.getTopTags
• track.removeTag
• user.getPersonalTags
• user.getTopTags
• album.addTags
• album.removeTag
• artist.addTags
• artist.removeTag
• chart.getTopTags

Issue to track remaining artist commands

API Progress

• artist.getTopArtists
• artist.addTags
• artist.getCorrection
• artist.getPastEvents
• artist.getPodcast
• artist.getTopFans
• artist.removeTag

Issue to track remaining share methods

Api Progress

• album.share
• artist.share
• track.share
• event.share

Testing the demo, it doesn't throw an exception is just keeps waiting.

Debugging I found out that the problem is in the signature generation, in ToMD5()

Anybody else experiencing this?

EDIT: there is a System.IO.FileNotFoundException happening, not sure if is trying to load an assembly and failing.

EDIT: decided to use a custom implementation of MD5 instead of the MyConvert package and everything is working. See here

userApi.GetTopAlbums has wrong parameter, "username" has to be "user"

See discussion in #63

See 229968e

Maybe MBID type + command constructor overloading

to make everything consistent

e.g. Auth -> LastAuth, IAuth -> ILastAuth, AlbumApi -> LastAlbumApi

artist.topAlbums -> artist.getTopAlbums
artist.topTracks -> artist.getTopTracks

See PROGRESS.md

Issue to track remaining track methods.

API Progress

• track.addTags
• track.ban
• track.getBuylinks
• track.getCorrection
• track.getFingerprintMetadata
• track.getTags
• track.getTopFans
• track.getTopTags
• track.removeTag
• track.unban

In reference to PR #29

When getting info for the album "Shrek the Third" by "Harry Chapin", a beta tester found a bug. Further looking into it and it seems to be related to Last.FM using an object instead of an array when there is only one tag.

also, any command returning LastResponse<List>

I broke something when reformatting

Any way to avoid this dependency?

Error Found: The supported APIs test detected the following errors:
This API is not supported for this application type - Api=System.Security.Cryptography.MD5CryptoServiceProvider. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Security.Cryptography.HashAlgorithm. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Security.Cryptography.MD5. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.SerializableAttribute. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Char.ToString(System.IFormatProvider). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Security.Cryptography.MD5CryptoServiceProvider.#ctor. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Security.Cryptography.HashAlgorithm.ComputeHash(System.Byte[]). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Globalization.TextInfo.ToTitleCase(System.String). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Text.Encoding.get_ASCII. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Text.Encoding.GetString(System.Byte[]). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.String.Format(System.String,System.Object,System.Object,System.Object). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Globalization.CultureInfo.GetCultureInfo(System.String). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Reflection.PropertyInfo.op_Inequality(System.Reflection.PropertyInfo,System.Reflection.PropertyInfo). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.SerializableAttribute.#ctor. Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.
This API is not supported for this application type - Api=System.Reflection.PropertyInfo.op_Equality(System.Reflection.PropertyInfo,System.Reflection.PropertyInfo). Module=MSCORLIB, PUBLICKEYTOKEN=B77A5C561934E089. File=MyConvert.dll.

Asking for Matt & Kim returns Matt. Nobody likes Matt.

Commit 1729119 added a switch to catch request exceptions from api actions, should preserve more information if this is used.

See this StackOverflow comment

So it's obvious it's referring to user authentication specifically

part of documenting anon usage better

Remove MyConvert from nuspec,
update json.net to 6.0.8

{
    "scrobbles": {
        "scrobble": {
            "track": {
                "#text": "Again",
                "corrected": "0"
            },
            "artist": {
                "#text": "Various",
                "corrected": "0"
            },
            "album": {
                "#text": "",
                "corrected": "0"
            },
            "albumArtist": {
                "#text": "",
                "corrected": "0"
            },
            "timestamp": "1425152860",
            "ignoredMessage": {
                "#text": "Artist name failed filter: Various",
                "code": "1"
            }
        },
        "@attr": {
            "accepted": "0",
            "ignored": "1"
        }
    }
}

Should look at @attr.ignored

Last.fm syntax is different for some reason

This issue is to track progress on all event-related methods.

API Progress

• event poco
• event.attend
• event.getAttendees
• event.getInfo
• event.getShouts
• event.shout
• artist.getEvents
• artist.getPastEvents
• get.getEvents
• user.getEvents
• user.getPastEvents
• user.getRecommendedEvents
• venue.getEvents
• venue.getPastEvents

Proposing renaming them all according to the API method they implement:

AlbumApi.AddShoutCommand -> album.addShout -> AlbumAddShoutCommand
AlbumApi.GetAlbumInfoCommand -> album.getInfo -> AlbumGetInfoCommand
TrackApi.LoveTrackCommand -> track.love -> TrackLoveCommand
TrackApi.AddShoutCommand -> track.addShout -> TrackAddShoutCommand
TrackApi.GetSimilarTracksCommand -> track.getSimilar -> TrackGetSimilarCommand

etc.

More info: http://blog.stephencleary.com/2012/07/dont-block-on-async-code.html

It doesn't add anything Only used in Syro for making reflection nicer

Need to check branching strats, AppVeyor can only generate packages from one branch iirc

See changes in dc81899

Having the xBrain cryptography dll in the repo isn't good.

I think people will benefit more from the sample if it can be built upon without references to the core code.

HttpClient should be persisted for as long as the application needs it. Currently each call to the SDK creates a new one.

Work is to allow an HttpClient to be registered with the SDK. Simplest way seems to be IoC/DI but need to keep it simple to use for applications without that in place.

To simplify DI and example code. Existing *Api classes presented as properties on new class object.

var auth = new LastAuth("apikey", "apisecret");

// wait for authentication
var response = await auth.GetSessionTokenAsync("username", "pass");

if (response.Success && auth.HasAuthenticated) {
    var trackApi = new TrackApi(auth);
    var loved = await trackApi.LoveTrackAsync("CIRCLONT6A [141.98][Syrobonkus mix]", "Aphex Twin");
}

becomes

var lastApi = new SuperLastApi(apikey, apisecret, httpclient, scrobbler);

var response = lastApi.Auth.GetSessionTokenAsync();
if (response.Success && lastApi.Auth.HasAuthenticated)
{
var loved = lastApi.Track.LoveAsync("CIRCLONT6A [141.98][Syrobonkus mix]", "Aphex Twin");
}

http://www.youtube.com/watch?v=mqUUlBwtKNs

http://stackoverflow.com/questions/16751772/how-do-i-use-travis-ci-with-c-sharp-or-f

Turns out interactivity SDK is unavaible on Windows 10.

If the search term returns nothing the sdk throws a null exception.

AppVeyor is set up to build both packages with the same version

Moved to #63

Issue to track remaining geo methods

• geo.getEvents
• geo.getMetroArtistChart
• geo.getMetroHypeArtistChart
• geo.getMetroHypeTrackChart
• geo.getMetroTrackChart
• geo.getMetroUniqueArtistChart
• geo.getMetroUniqueTrackChart
• geo.getMetroWeeklyChartlist
• geo.getMetros
• geo.getTopArtists
• geo.getTopTracks

This issue is to track progress of methods relating to buy links on the API.

API Progress

• Create buylink poco
• album.getBuyLinks
• track.getBuyLinks

Identical commands send different headers on WPF vs Windows Phone

WPF
Content-Type: application/x-www-form-urlencoded
Host: ws.audioscrobbler.com
Content-Length: 260
Expect: 100-continue

Windows Phone
Accept: */*
Content-Length: 260
Accept-Encoding: identity
Content-Type: application/x-www-form-urlencoded
User-Agent: NativeHost
Host: ws.audioscrobbler.com
Connection: Keep-Alive
Pragma: no-cache

After some testing it seems that the Last.fm API doesn't handle the Expect: 100-continue header.

https://github.com/inflatablefriends/lastfm/blob/master/src/IF.Lastfm.Core/Api/Commands/TrackApi/TrackUpdateNowPlayingCommand.cs#L50

TotalSeconds is a double, which can be fractional. This causes a failure with a "MissingParameter" error. The right thing to do is probably to round fractional seconds off to the nearest whole second.

and integrate it into the AppVeyor process