inetic / libclub Goto Github PK

I would like to point out that identifiers like "__BINARY_DECODER_H__" and "__CLUB_HUB_H__" do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

There are a number of places in the code that use syntax such as..

e.template put(mid.timestamp);

This does not compile on MSVC(vs2017 with C++14 enabled), the compiler does not understand this syntax

I removed the .template and does compile--

e.put(mid.timestamp);

MSVC trips up here giving a warning that there are duplicate copy constructors for both decode and encode.

decoder(const decoder&);
decoder(decoder&);

inline
decoder::decoder(const decoder& d)
: _was_error(d._was_error) {
_current.begin = d._current.begin;
_current.end = d._current.end;
}

inline
decoder::decoder(decoder& d)
: _was_error(d._was_error) {
_current.begin = d._current.begin;
_current.end = d._current.end;
}
They are identical so we can remove the non-const versions-- and the problem goes away

EDIT: I see why you were doing this-- the compiler is invoking the wrong copy constructor in encode(encode), and calling the Sequence instead..

Guess the only solution is to disable this warning.