throws "TypeError: Object.keys called on non-object" on json with x:y = null about nconf HOT 6 CLOSED

tentative fix : dont merge in nulls in Provider.prototype._execute

// provider.js:542

-      if (action === 'get' && typeof response === 'object' && !Array.isArray(response)) {
+      if (action === 'get' && response!=null && typeof response === 'object' && !Array.isArray(response)) {

from nconf.

above suggestion fails tests.

This patch below seems to pass all nconf self tests
[ this fix returns x:y == undefined, rather than x:y == null, for the test case above.. so its perhaps not a perfect fix ]

diff --git lib/nconf/provider.js lib/nconf/provider.js
index e83c3c6..cc5ad18 100644
--- lib/nconf/provider.js
+++ lib/nconf/provider.js
@@ -540,7 +540,8 @@ Provider.prototype._execute = function (action, syncLength /* [arguments] */) {

       // Merge objects if necessary
       if (action === 'get' && typeof response === 'object' && !Array.isArray(response)) {
-        mergeObjs.push(response);
+        if (response!=null)
+          mergeObjs.push(response);
         response = undefined;
       }
     }

from nconf.

the first time you run npm test if fails .. run it again, its fine.
maybe this is why travis flags nconf master as 'build fail'

[ so my pull request has a travis build fail.. but nconf master has the same travis build fail, ..
Im in automated-build-face-palm land :-]

thx for listening

from nconf.

ok, so now Ive fixed a problem that happens the first time you run npm test - it fails 2 tests because it cant find store.json.

Basically store.json is only created by a later test, which means the first test run will always fail.

so... I added code to call save, thus writing out store.json [file.saveSync],
so when the subsequent test does a search for the file it finds it.

Can you review when you have a moment and merge if your happy with these changes??

thanks again for nconf!

from nconf.

my fixes/fork here, btw - https://github.com/justgord/nconf

from nconf.

fixed in f9b24f1
null values will not default to undefined with this fix

from nconf.