Giter Club home page Giter Club logo

Comments (6)

mhamann avatar mhamann commented on July 19, 2024 3

nconf v0.12.1 has been released with this change.

from nconf.

kahluagenie avatar kahluagenie commented on July 19, 2024 1

would love to see a publish of this as well!

from nconf.

adenhertog avatar adenhertog commented on July 19, 2024

I'm also getting hit by this, can a publish be done with the fix commit - ce212b2 ? 🙏

from nconf.

mhamann avatar mhamann commented on July 19, 2024

yes, this would be good to backport and publish. my only hesitation is that defineGetter is deprecated. We can probably replace it with Object.defineProperty() instead.

from nconf.

Jamie-BitFlight avatar Jamie-BitFlight commented on July 19, 2024

If anyone still has this issue, you can work around it using this fix.
https://gist.github.com/Jamie-BitFlight/d15ad615249d60b02dfb72e0162ad5f9

from nconf.

xfournet avatar xfournet commented on July 19, 2024

@mhamann defineGetter is what is currently used in nconf 0.12.0 and the patch don't change anything regarding that. You could probably review what is better in another issue.
I created a backport PR in v0.x branch (#402). Would be possible to release a new 0.x version with the fix ?

from nconf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.