Giter Club home page Giter Club logo

Comments (7)

Marak avatar Marak commented on July 19, 2024

What are you trying to do? The code you posted doesn't make sense. With the default settings, a hook will already be listening for STDIN from the terminal. hook.io also comes with a built-in repl ( --repl ).

If you really need to use a vanilla repl, you'll have to change some of hook.io's default configuration settings.

Unsure about any issues with nconf here, could be a red herring + unvalidated user input problem in nconf.

from nconf.

CrabBot avatar CrabBot commented on July 19, 2024

The code is the minimum to reproduce.

We have a process that that's communicating via hook.io and is additionally using the REPL for debugging. The hook.io binding is a couple layers deep, and the REPL context binding is at the top level, so even if there were hooks, it doesn't really make sense in this case. The error still occurs with STDIN ignored, FWIW.

from nconf.

Marak avatar Marak commented on July 19, 2024

When I run the code you posted,

hookio = require('hook.io');
require('repl').start({})
new hookio.Hook

I get

^CMarak-Squiress-MacBook-Pro-2:hook.io maraksquires$ node test.js 

readline.js:121
    var lines = prompt.split(/[\r\n]/);
                       ^
TypeError: Object #<Object> has no method 'split'
    at Interface.setPrompt (readline.js:121:24)
    at new REPLServer (repl.js:128:7)
    at Object.start (repl.js:251:14)
    at Object.<anonymous> (/Users/maraksquires/dev/hook.io/test.js:2:17)
    at Module._compile (module.js:446:26)
    at Object..js (module.js:464:10)
    at Module.load (module.js:353:31)
    at Function._load (module.js:311:12)
    at Array.0 (module.js:484:10)
    at EventEmitter._tickCallback (node.js:190:38)
Marak-Squiress-MacBook-Pro-2:hook.io maraksquires$ 

I can't read your mind. The code you posted shows starting a node repl and then creating a hook with default settings. Anything else I can't comment on.

from nconf.

CrabBot avatar CrabBot commented on July 19, 2024

I already explained how it's being used, and provided a minimum code to reproduce. I'm not sure why your code is returning a different error, but I've confirmed the same error on multiple boxes with multiple people with fresh npm installs of hook.io and fresh checkouts. (0.8.10)

Honestly, this bug is completely avoidable by starting the REPL after the hook, so I'm happy to provide more info if you can provide something specific that you need in this non-minimum reproducible example.

from nconf.

Marak avatar Marak commented on July 19, 2024

I switched to node 0.8.x and am now seeing the same error.

Looks like bad input being passed into nconf from hook.io and causing nconf to crash.

Should be fixed in nconf so that it won't crash / will throw a meaningful message.

Should be fixed in hook.io so that the bad input ( probably invalid config location / options ) are never passed in.

from nconf.

bmeck avatar bmeck commented on July 19, 2024

Marak can you test now that we will be returning the root of configs when given null or undefined as the key

from nconf.

indexzero avatar indexzero commented on July 19, 2024

This is unrelated to nconf

from nconf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.