Memory Store in the chain of stores causes save to fail about nconf HOT 6 CLOSED

I encountered this same problem and traced the same bit through the code.

Looking at the vows tests, I found this:

  "When using nconf": {                                                            
    "with the memory store": {                                                     
...                                                                             
      "the save() method": {                                                       
        "without a callback": {                                                    
          "should throw an exception": function () {                               
            assert.throws(function () { nconf.save() });                           
          }                                                                        

It, of course, does throw an exception (Object.keys called on non-object), but that's probably not the exception it should be throwing.

I was about to fix this and submit a pull request, but I'm not really sure what the intended behavior is here.

from nconf.

+1

from nconf.

In some ways this is similar to issue #20

From the investigation: "When you save your configuration, it does so for all the stores, including the 'system' store, for which saving makes no sense. However, for your 'file' store it works fine. Hence, you see an error but it still saves."

The fix quote: "This is fixed in [email protected] if you try to save when you have a store which has no .save() or .saveSync() methods, we will not throw an error, we will just ignore it and not save."

My preference would be to see the same in the memory store.

from nconf.

This should be fixed as of PR #38, would you mind testing this @davidcl64 and @jlank?

from nconf.

Will do - it might take me a bit to get to it, but the provider changes look good.

from nconf.

Fixed by #38

from nconf.